2 Commits

Author SHA1 Message Date
Tommy Parnell
9c4db3c5cb stop 2018-11-15 12:46:21 -05:00
Tommy Parnell
83949b45d1 upgrade insecure 2018-11-15 12:39:44 -05:00
7 changed files with 24 additions and 3 deletions

View File

@@ -14,7 +14,7 @@ build_script:
dotnet pack src\HardHat\HardHat.csproj --configuration Release --output ..\..\output /p:Version=0.0.1-build-$env:APPVEYOR_BUILD_NUMBER dotnet pack src\HardHat\HardHat.csproj --configuration Release --output ..\..\output /p:Version=0.0.1-build-$env:APPVEYOR_BUILD_NUMBER
} }
test_script: test_script:
- ps: dotnet test src\HardHat.UnitTests\HardHat.UnitTests.csproj - ps: dotnet test src\HardHat.UnitTests\HardHat.UnitTests.csproj /p:CollectCoverage=true /p:CoverletOutputFormat=opencover
artifacts: artifacts:
- path: output\**.nupkg - path: output\**.nupkg
deploy: deploy:

View File

@@ -25,10 +25,11 @@ namespace HardHat.UnitTests
FormAction = new HashSet<string>() { "http://*.example.com" }, FormAction = new HashSet<string>() { "http://*.example.com" },
FrameAncestors = new HashSet<string>() { "http://*.example.com" }, FrameAncestors = new HashSet<string>() { "http://*.example.com" },
PluginTypes = new HashSet<string>() { "http://*.example.com" }, PluginTypes = new HashSet<string>() { "http://*.example.com" },
Sandbox = SandboxOption.AllowPointerLock Sandbox = SandboxOption.AllowPointerLock,
UpgradeInsecureResponse = true
}); });
Assert.Equal<string>(@"default-src 'self' 'none' http://*.example.com; script-src http://*.example.com; style-src http://*.example.com; img-src http://*.example.com; connect-src http://*.example.com; font-src http://*.example.com; object-src http://*.example.com; media-src http://*.example.com; child-src http://*.example.com; form-action http://*.example.com; frame-ancestors http://*.example.com; sandbox allow-pointer-lock; plugin-types http://*.example.com;", builder); Assert.Equal<string>(@"default-src 'self' 'none' http://*.example.com; script-src http://*.example.com; style-src http://*.example.com; img-src http://*.example.com; connect-src http://*.example.com; font-src http://*.example.com; object-src http://*.example.com; media-src http://*.example.com; child-src http://*.example.com; form-action http://*.example.com; frame-ancestors http://*.example.com; sandbox allow-pointer-lock; plugin-types http://*.example.com; upgrade-insecure-requests;", builder);
} }
[Fact] [Fact]

View File

@@ -3,6 +3,10 @@
<TargetFramework>netcoreapp2.1</TargetFramework> <TargetFramework>netcoreapp2.1</TargetFramework>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
<PackageReference Include="coverlet.msbuild" Version="2.3.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Microsoft.AspNetCore.Http.Abstractions" Version="2.1.1" /> <PackageReference Include="Microsoft.AspNetCore.Http.Abstractions" Version="2.1.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0" /> <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0" />
<PackageReference Include="Moq" Version="4.7.25" /> <PackageReference Include="Moq" Version="4.7.25" />

View File

@@ -13,6 +13,10 @@ namespace HardHat.Builders
{ {
throw new ArgumentNullException(nameof(policy)); throw new ArgumentNullException(nameof(policy));
} }
if(policy.DefaultSrc.Count > 0 && policy.DefaultSrc.Contains(CSPConstants.None))
{
//todo throw exception in this case
}
if (policy.DefaultSrc != null && policy.DefaultSrc.Count > 0) if (policy.DefaultSrc != null && policy.DefaultSrc.Count > 0)
{ {
stringBuilder.Append(Constants.CSPDirectives.DefaultSrc); stringBuilder.Append(Constants.CSPDirectives.DefaultSrc);
@@ -91,6 +95,10 @@ namespace HardHat.Builders
stringBuilder.Append(Constants.CSPDirectives.PluginTypes); stringBuilder.Append(Constants.CSPDirectives.PluginTypes);
stringBuilder.Append($" {string.Join(" ", policy.PluginTypes)}; "); stringBuilder.Append($" {string.Join(" ", policy.PluginTypes)}; ");
} }
if(policy.UpgradeInsecureResponse)
{
stringBuilder.Append($"{Constants.CSPDirectives.UpgradeInsecureRequests}; ");
}
return stringBuilder.ToString().TrimEnd(); return stringBuilder.ToString().TrimEnd();
} }
} }

View File

@@ -52,6 +52,7 @@
internal const string FormAction = "form-action"; internal const string FormAction = "form-action";
internal const string FrameAncestors = "frame-ancestors"; internal const string FrameAncestors = "frame-ancestors";
internal const string PluginTypes = "plugin-types"; internal const string PluginTypes = "plugin-types";
internal const string UpgradeInsecureRequests = "upgrade-insecure-requests";
} }
} }
} }

View File

@@ -68,5 +68,7 @@ namespace HardHat
/// </summary> /// </summary>
public bool OnlySendReport { get; set; } = false; public bool OnlySendReport { get; set; } = false;
public bool UpgradeInsecureResponse { get; set; } = false;
} }
} }

View File

@@ -204,6 +204,11 @@ namespace HardHat
Policy.Sandbox = sandboxOption ?? throw new ArgumentNullException(nameof(sandboxOption)); Policy.Sandbox = sandboxOption ?? throw new ArgumentNullException(nameof(sandboxOption));
return this; return this;
} }
public ContentSecurityPolicyBuilder WithUpgradeInsecureResponse(bool enable = true)
{
Policy.UpgradeInsecureResponse = enable;
return this;
}
public ContentSecurityPolicy BuildPolicy() => Policy; public ContentSecurityPolicy BuildPolicy() => Policy;
} }