From d517869fd5c1abdc3e3b6f036d16fd8ac136b8a0 Mon Sep 17 00:00:00 2001 From: Tommy Parnell Date: Sun, 24 May 2015 17:52:45 -0400 Subject: [PATCH] tidy things up --- appveyor.yml | 2 +- readme.md | 16 ++++++++-------- .../QueryThings.cs | 4 ++-- .../RequestTests/EndpointInterfaceTesting.cs | 10 ---------- src/NetrunnerDb.Net/Repository.cs | 18 ++++++++++++++++++ src/NetrunnerDb.Net/Responses/DecklistByDay.cs | 10 ---------- 6 files changed, 29 insertions(+), 31 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index b32e45a..6fd8cc0 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -1,4 +1,4 @@ -version: 1.0.{build} +version: 1.1.{build} configuration: Release nuget: account_feed: true diff --git a/readme.md b/readme.md index 140121e..0f3fb2d 100644 --- a/readme.md +++ b/readme.md @@ -10,14 +10,14 @@ A simple API wrapper over the netrunner db. To put it simply -``` -new Repository().GetRequest() - -OR - -new Repository().GetCards() - -new Repository().GetRequest(01001) +```csharp +var result = new Repository().GetCards(); +var result = new Repository().GetCard("CardId (example, noise = 01001)"); +var result = new Repository().GetSets(); +var result = new Repository().GetSet("tsb (set code, all set codes can be found by querying GetCards())"); +var result new Repository().GetDecklist("Decklist ID, can be found in the URL of the decklist") +var targetDate = new DateTime(2014, 01, 01); +new Repository().GetDecklistForDay(targetDate) ``` diff --git a/src/NetrunnerDb.Net.AcceptanceTests/QueryThings.cs b/src/NetrunnerDb.Net.AcceptanceTests/QueryThings.cs index b5c2684..fad5dd7 100644 --- a/src/NetrunnerDb.Net.AcceptanceTests/QueryThings.cs +++ b/src/NetrunnerDb.Net.AcceptanceTests/QueryThings.cs @@ -31,13 +31,13 @@ namespace NetrunnerDb.Net.AcceptanceTests [Test] public void Decklist() { - Assert.AreEqual(20866, new Repository().GetRequest("20866").First().Id); + Assert.AreEqual(20866, new Repository().GetDecklist("20866").First().Id); } [Test] public void DecklistByDate() { var targetDate = new DateTime(2014, 01, 01); - Assert.IsTrue(new Repository().GetRequest(targetDate.ToString("MM/dd/yyyy")).All(a => + Assert.IsTrue(new Repository().GetDecklistForDay(targetDate).All(a => { var parseDate = DateTime.Parse(a.Creation); return (parseDate >= targetDate && parseDate <= parseDate.AddDays(1).AddMinutes(-1)); diff --git a/src/NetrunnerDb.Net.UnitTests/RequestTests/EndpointInterfaceTesting.cs b/src/NetrunnerDb.Net.UnitTests/RequestTests/EndpointInterfaceTesting.cs index e111562..cbdd8db 100644 --- a/src/NetrunnerDb.Net.UnitTests/RequestTests/EndpointInterfaceTesting.cs +++ b/src/NetrunnerDb.Net.UnitTests/RequestTests/EndpointInterfaceTesting.cs @@ -19,16 +19,6 @@ namespace NetrunnerDb.Net.UnitTests.RequestTests } - [Test] - public void TestDecklistEndpointDateTimeOverride() - { - var mockedDatetime = new DateTime(2014, 1, 1); - var decklistByDate = new DecklistByDate(mockedDatetime); - var decklistEndpoint = decklistByDate.EndPoint(); - var date = decklistEndpoint.Split('/').Last(); - Assert.AreEqual(date, "2014-01-01"); - } - [Test] public void TestDecklistEndpoint() { diff --git a/src/NetrunnerDb.Net/Repository.cs b/src/NetrunnerDb.Net/Repository.cs index 0e00b23..8e59e6c 100644 --- a/src/NetrunnerDb.Net/Repository.cs +++ b/src/NetrunnerDb.Net/Repository.cs @@ -77,5 +77,23 @@ namespace NetrunnerDb.Net { return GetRequest(code); } + /// + /// Get a decklist by its id + /// + /// + /// + public IList GetDecklist(string decklistId) + { + return GetRequest(decklistId); + } + /// + /// Get all decklists for one day + /// + /// + /// + public IList GetDecklistForDay(DateTime date) + { + return GetRequest(date.ToString("yyyy-MM-dd")); + } } } diff --git a/src/NetrunnerDb.Net/Responses/DecklistByDay.cs b/src/NetrunnerDb.Net/Responses/DecklistByDay.cs index 6037b2b..9105cb0 100644 --- a/src/NetrunnerDb.Net/Responses/DecklistByDay.cs +++ b/src/NetrunnerDb.Net/Responses/DecklistByDay.cs @@ -9,10 +9,6 @@ namespace NetrunnerDb.Net.Responses { public DecklistByDate() { } - public DecklistByDate(DateTime endpoint) - { - Endpoint = endpoint; - } [JsonProperty("id")] public int Id { get; set; } @@ -31,14 +27,8 @@ namespace NetrunnerDb.Net.Responses [JsonProperty("cards")] public IDictionary Cards { get; set; } - private DateTime? Endpoint { get; set; } - public override string EndPoint(string parameter = "") { - if (Endpoint.HasValue) - { - return string.Format("/api/decklists/by_date/{0}", Endpoint.Value.ToString("yyyy-MM-dd")); - } if (string.IsNullOrWhiteSpace(parameter)) { throw new ArgumentNullException("parameter");