From 81de4cfc01af49da4b7d1199c9413ead197ccbaf Mon Sep 17 00:00:00 2001 From: Tommy Parnell Date: Mon, 11 May 2015 21:16:44 -0400 Subject: [PATCH] seal up unsealed classes, clean up using statements --- src/Untappd.Net.UnitTests/Request/TestRepository.cs | 9 ++++----- .../Responses/Actions/TestCheckInAction.cs | 4 ---- .../Responses/Actions/TestSimpleActions.cs | 4 ---- .../Authentication/AuthenticatedUntappdCredentials.cs | 2 +- .../Authentication/UnAuthenticatedUntappdCredentials.cs | 2 +- .../Exception/EndpointConfigurationException.cs | 2 +- src/Untappd.Net/Exception/HttpErrorException.cs | 5 ----- src/Untappd.Net/Request/Repository.cs | 9 ++++----- src/Untappd.Net/Request/RepositoryGet.cs | 2 +- src/Untappd.Net/Request/RepositoryPost.cs | 2 +- src/Untappd.Net/Responses/Actions/RemoveFromWishList.cs | 6 +----- src/Untappd.Net/SingleObjectArrayConverter.cs | 2 +- 12 files changed, 15 insertions(+), 34 deletions(-) diff --git a/src/Untappd.Net.UnitTests/Request/TestRepository.cs b/src/Untappd.Net.UnitTests/Request/TestRepository.cs index c31e186..7f170ae 100644 --- a/src/Untappd.Net.UnitTests/Request/TestRepository.cs +++ b/src/Untappd.Net.UnitTests/Request/TestRepository.cs @@ -1,15 +1,14 @@ using System.Collections.Generic; using System.Collections.ObjectModel; +using System.IO; using System.Threading.Tasks; using Moq; -using Newtonsoft.Json; using NUnit.Framework; using RestSharp; -using Untappd.Net.Request; -using Untappd.Net.Responses.BeerInfo; -using Untappd.Net.Responses.Actions; -using System.IO; using Untappd.Net.Authentication; +using Untappd.Net.Request; +using Untappd.Net.Responses.Actions; +using Untappd.Net.Responses.BeerInfo; namespace Untappd.Net.UnitTests.Request { diff --git a/src/Untappd.Net.UnitTests/Responses/Actions/TestCheckInAction.cs b/src/Untappd.Net.UnitTests/Responses/Actions/TestCheckInAction.cs index 09df9b1..4c71942 100644 --- a/src/Untappd.Net.UnitTests/Responses/Actions/TestCheckInAction.cs +++ b/src/Untappd.Net.UnitTests/Responses/Actions/TestCheckInAction.cs @@ -1,8 +1,4 @@ using System; -using System.Collections.Generic; -using System.Linq; -using System.Text; -using System.Threading.Tasks; using NUnit.Framework; using Untappd.Net.Responses.Actions; diff --git a/src/Untappd.Net.UnitTests/Responses/Actions/TestSimpleActions.cs b/src/Untappd.Net.UnitTests/Responses/Actions/TestSimpleActions.cs index 9aa1429..75adbb5 100644 --- a/src/Untappd.Net.UnitTests/Responses/Actions/TestSimpleActions.cs +++ b/src/Untappd.Net.UnitTests/Responses/Actions/TestSimpleActions.cs @@ -1,8 +1,4 @@ using System; -using System.Collections.Generic; -using System.Linq; -using System.Text; -using System.Threading.Tasks; using NUnit.Framework; using Untappd.Net.Responses.Actions; diff --git a/src/Untappd.Net/Authentication/AuthenticatedUntappdCredentials.cs b/src/Untappd.Net/Authentication/AuthenticatedUntappdCredentials.cs index c216fe2..415e888 100644 --- a/src/Untappd.Net/Authentication/AuthenticatedUntappdCredentials.cs +++ b/src/Untappd.Net/Authentication/AuthenticatedUntappdCredentials.cs @@ -4,7 +4,7 @@ using System.Collections.ObjectModel; namespace Untappd.Net.Authentication { - public class AuthenticatedUntappdCredentials : UntappdCredentials, IAuthenticatedUntappdCredentials + public sealed class AuthenticatedUntappdCredentials : UntappdCredentials, IAuthenticatedUntappdCredentials { /// /// Pass your authenticated access token diff --git a/src/Untappd.Net/Authentication/UnAuthenticatedUntappdCredentials.cs b/src/Untappd.Net/Authentication/UnAuthenticatedUntappdCredentials.cs index ae9a674..a86468d 100644 --- a/src/Untappd.Net/Authentication/UnAuthenticatedUntappdCredentials.cs +++ b/src/Untappd.Net/Authentication/UnAuthenticatedUntappdCredentials.cs @@ -4,7 +4,7 @@ using System.Collections.ObjectModel; namespace Untappd.Net.Authentication { - public class UnAuthenticatedUntappdCredentials : UntappdCredentials, IUnAuthenticatedUntappdCredentials + public sealed class UnAuthenticatedUntappdCredentials : UntappdCredentials, IUnAuthenticatedUntappdCredentials { /// /// UnAuthenticated request. Pass your API id and secret diff --git a/src/Untappd.Net/Exception/EndpointConfigurationException.cs b/src/Untappd.Net/Exception/EndpointConfigurationException.cs index 14db0d5..432a918 100644 --- a/src/Untappd.Net/Exception/EndpointConfigurationException.cs +++ b/src/Untappd.Net/Exception/EndpointConfigurationException.cs @@ -3,7 +3,7 @@ namespace Untappd.Net.Exception { [Serializable] - public class EndpointConfigurationException : BaseUntappdException + public sealed class EndpointConfigurationException : BaseUntappdException { /// /// Called when a class has an empty endpoint diff --git a/src/Untappd.Net/Exception/HttpErrorException.cs b/src/Untappd.Net/Exception/HttpErrorException.cs index 90d1cb2..be1e06f 100644 --- a/src/Untappd.Net/Exception/HttpErrorException.cs +++ b/src/Untappd.Net/Exception/HttpErrorException.cs @@ -1,9 +1,4 @@ using System; -using System.Collections.Generic; -using System.Globalization; -using System.Linq; -using System.Text; -using System.Threading.Tasks; using Newtonsoft.Json; using RestSharp; diff --git a/src/Untappd.Net/Request/Repository.cs b/src/Untappd.Net/Request/Repository.cs index f557c14..52b4fde 100644 --- a/src/Untappd.Net/Request/Repository.cs +++ b/src/Untappd.Net/Request/Repository.cs @@ -1,16 +1,15 @@ -using System.Collections.Generic; +using System; +using System.Collections.Generic; using System.Net; using System.Threading.Tasks; using Newtonsoft.Json; -using Newtonsoft.Json.Linq; using RestSharp; -using Untappd.Net.Exception; -using System; using Untappd.Net.Authentication; +using Untappd.Net.Exception; namespace Untappd.Net.Request { - public partial class Repository + public sealed partial class Repository { internal IRestClient Client; internal IRestRequest Request; diff --git a/src/Untappd.Net/Request/RepositoryGet.cs b/src/Untappd.Net/Request/RepositoryGet.cs index 1daabad..a34e428 100644 --- a/src/Untappd.Net/Request/RepositoryGet.cs +++ b/src/Untappd.Net/Request/RepositoryGet.cs @@ -5,7 +5,7 @@ using Untappd.Net.Exception; namespace Untappd.Net.Request { - public partial class Repository + public sealed partial class Repository { /// /// Get the things! diff --git a/src/Untappd.Net/Request/RepositoryPost.cs b/src/Untappd.Net/Request/RepositoryPost.cs index f5bffbb..d3edffa 100644 --- a/src/Untappd.Net/Request/RepositoryPost.cs +++ b/src/Untappd.Net/Request/RepositoryPost.cs @@ -3,7 +3,7 @@ using Untappd.Net.Authentication; namespace Untappd.Net.Request { - public partial class Repository + public sealed partial class Repository { /// /// do a post with actions diff --git a/src/Untappd.Net/Responses/Actions/RemoveFromWishList.cs b/src/Untappd.Net/Responses/Actions/RemoveFromWishList.cs index 9623913..39586c3 100644 --- a/src/Untappd.Net/Responses/Actions/RemoveFromWishList.cs +++ b/src/Untappd.Net/Responses/Actions/RemoveFromWishList.cs @@ -1,8 +1,4 @@ -using System; -using System.Collections.Generic; -using System.Linq; -using System.Text; -using System.Threading.Tasks; +using System.Collections.Generic; using RestSharp; using Untappd.Net.Request; diff --git a/src/Untappd.Net/SingleObjectArrayConverter.cs b/src/Untappd.Net/SingleObjectArrayConverter.cs index 1d5ce7b..693168f 100644 --- a/src/Untappd.Net/SingleObjectArrayConverter.cs +++ b/src/Untappd.Net/SingleObjectArrayConverter.cs @@ -10,7 +10,7 @@ namespace Untappd.Net /// Deserialize json as T if json schema defines an object. /// /// - internal class SingleObjectArrayConverter : JsonConverter + internal sealed class SingleObjectArrayConverter : JsonConverter where T : new() { public override bool CanConvert(Type objectType)