From 1ae4482fe5a84ceaaa7b773c3ed72e849d8947df Mon Sep 17 00:00:00 2001 From: laurenspriem Date: Thu, 25 Apr 2024 10:53:42 +0530 Subject: [PATCH] [mob][photos] Always check big clusters first for suggestions --- .../face_ml/feedback/cluster_feedback.dart | 48 +++++++++---------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/mobile/lib/services/machine_learning/face_ml/feedback/cluster_feedback.dart b/mobile/lib/services/machine_learning/face_ml/feedback/cluster_feedback.dart index b017aa6919..f56286e5d6 100644 --- a/mobile/lib/services/machine_learning/face_ml/feedback/cluster_feedback.dart +++ b/mobile/lib/services/machine_learning/face_ml/feedback/cluster_feedback.dart @@ -474,30 +474,30 @@ class ClusterFeedbackService { final checkSizes = [kMinimumClusterSizeSearchResult, 20, 10, 5, 1]; late Map clusterAvgBigClusters; for (final minimumSize in checkSizes.toSet()) { - if (smallestPersonClusterSize >= minimumSize) { - clusterAvgBigClusters = await _getUpdateClusterAvg( - allClusterIdsToCountMap, - ignoredClusters, - minClusterSize: minimumSize, - ); - w?.log( - 'Calculate avg for ${clusterAvgBigClusters.length} clusters of min size $minimumSize', - ); - final List<(int, double)> suggestionsMeanBigClusters = - _calcSuggestionsMean( - clusterAvgBigClusters, - personClusters, - ignoredClusters, - goodMeanDistance, - ); - w?.log( - 'Calculate suggestions using mean for ${clusterAvgBigClusters.length} clusters of min size $minimumSize', - ); - if (suggestionsMeanBigClusters.isNotEmpty) { - return suggestionsMeanBigClusters - .map((e) => (e.$1, e.$2, true)) - .toList(growable: false); - } + // if (smallestPersonClusterSize >= minimumSize) { + clusterAvgBigClusters = await _getUpdateClusterAvg( + allClusterIdsToCountMap, + ignoredClusters, + minClusterSize: minimumSize, + ); + w?.log( + 'Calculate avg for ${clusterAvgBigClusters.length} clusters of min size $minimumSize', + ); + final List<(int, double)> suggestionsMeanBigClusters = + _calcSuggestionsMean( + clusterAvgBigClusters, + personClusters, + ignoredClusters, + goodMeanDistance, + ); + w?.log( + 'Calculate suggestions using mean for ${clusterAvgBigClusters.length} clusters of min size $minimumSize', + ); + if (suggestionsMeanBigClusters.isNotEmpty) { + return suggestionsMeanBigClusters + .map((e) => (e.$1, e.$2, true)) + .toList(growable: false); + // } } } w?.reset();