From 165bcb5c6e76510638437f6126cff4d0aa25363e Mon Sep 17 00:00:00 2001 From: ashilkn Date: Tue, 2 Apr 2024 13:47:57 +0530 Subject: [PATCH 1/3] fix: white bg for loading state when viewing images, turned it to black. when swiping on light theme, this comes up a 'white flash' on the right which looked odd. We use black bg when viewing images. --- mobile/lib/ui/viewer/file/detail_page.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/mobile/lib/ui/viewer/file/detail_page.dart b/mobile/lib/ui/viewer/file/detail_page.dart index 779243c27b..b589d6b62c 100644 --- a/mobile/lib/ui/viewer/file/detail_page.dart +++ b/mobile/lib/ui/viewer/file/detail_page.dart @@ -140,6 +140,7 @@ class _DetailPageState extends State { ), extendBodyBehindAppBar: true, resizeToAvoidBottomInset: false, + backgroundColor: Colors.black, body: Center( child: Stack( children: [ From 53184da7fb3b15e2b244bc1a65cf9f5782abd7a1 Mon Sep 17 00:00:00 2001 From: ashilkn Date: Tue, 2 Apr 2024 13:49:05 +0530 Subject: [PATCH 2/3] fix: loading icon's color in light theme when viewing images --- mobile/lib/ui/viewer/file/zoomable_image.dart | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mobile/lib/ui/viewer/file/zoomable_image.dart b/mobile/lib/ui/viewer/file/zoomable_image.dart index 90a4fae250..ff6bceb736 100644 --- a/mobile/lib/ui/viewer/file/zoomable_image.dart +++ b/mobile/lib/ui/viewer/file/zoomable_image.dart @@ -59,6 +59,7 @@ class _ZoomableImageState extends State { @override void initState() { + super.initState(); _photo = widget.photo; _logger = Logger("ZoomableImage"); _logger.info('initState for ${_photo.generatedID} with tag ${_photo.tag}'); @@ -70,7 +71,6 @@ class _ZoomableImageState extends State { debugPrint("isZooming = $_isZooming, currentState $value"); // _logger.info('is reakky zooming $_isZooming with state $value'); }; - super.initState(); } @override @@ -135,7 +135,9 @@ class _ZoomableImageState extends State { height: screenRelativeImageHeight, child: Hero( tag: widget.tagPrefix! + _photo.tag, - child: const EnteLoadingWidget(), + child: const EnteLoadingWidget( + color: Colors.white, + ), ), ), ); @@ -143,7 +145,9 @@ class _ZoomableImageState extends State { ), ); } else { - content = const EnteLoadingWidget(); + content = const EnteLoadingWidget( + color: Colors.white, + ); } final GestureDragUpdateCallback? verticalDragCallback = _isZooming From 0053e814c82f4d25f5c7ae7d9cef350415f49fb1 Mon Sep 17 00:00:00 2001 From: ashilkn Date: Tue, 2 Apr 2024 13:49:41 +0530 Subject: [PATCH 3/3] nit: remove unnecessary clipping --- mobile/lib/ui/viewer/file/detail_page.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/mobile/lib/ui/viewer/file/detail_page.dart b/mobile/lib/ui/viewer/file/detail_page.dart index b589d6b62c..4368590eae 100644 --- a/mobile/lib/ui/viewer/file/detail_page.dart +++ b/mobile/lib/ui/viewer/file/detail_page.dart @@ -166,6 +166,7 @@ class _DetailPageState extends State { Widget _buildPageView(BuildContext context) { return PageView.builder( + clipBehavior: Clip.none, itemBuilder: (context, index) { final file = _files![index]; _preloadFiles(index);