From 1fd238a89a93d4fec448e3416abf844390d122ba Mon Sep 17 00:00:00 2001 From: Neeraj Gupta <254676+ua741@users.noreply.github.com> Date: Fri, 16 Aug 2024 09:19:26 +0530 Subject: [PATCH] [cli] Fix temp file deletion on windows --- cli/internal/promt.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/cli/internal/promt.go b/cli/internal/promt.go index 14dccc64d0..5fb3b07db7 100644 --- a/cli/internal/promt.go +++ b/cli/internal/promt.go @@ -214,10 +214,11 @@ func ValidateDirForWrite(dir string) (bool, error) { return false, fmt.Errorf("write permission denied: %v", err) } - // Delete temp file - defer os.Remove(tempFile.Name()) - if err != nil { - return false, err + if tempErr := tempFile.Close(); tempErr != nil { + return false, fmt.Errorf("failed to close temp file: %v", tempErr) + } + if tempErr := os.Remove(tempFile.Name()); tempErr != nil { + return false, fmt.Errorf("failed to remove temp file: %v", tempErr) } return true, nil