From 2071bd07ae7c94d152fbe505c814ec2bbad46f2b Mon Sep 17 00:00:00 2001 From: Manav Rathi Date: Thu, 18 Jul 2024 19:06:37 +0530 Subject: [PATCH] 404 --- web/apps/auth/src/pages/404.tsx | 2 +- web/apps/photos/src/pages/404.tsx | 2 +- .../{shared/next => base/components}/pages/404.tsx | 10 ++++++---- 3 files changed, 8 insertions(+), 6 deletions(-) rename web/packages/{shared/next => base/components}/pages/404.tsx (87%) diff --git a/web/apps/auth/src/pages/404.tsx b/web/apps/auth/src/pages/404.tsx index dcd621c703..55b8b0b860 100644 --- a/web/apps/auth/src/pages/404.tsx +++ b/web/apps/auth/src/pages/404.tsx @@ -1,3 +1,3 @@ -import Page from "@ente/shared/next/pages/404"; +import Page from "@/base/components/pages/404"; export default Page; diff --git a/web/apps/photos/src/pages/404.tsx b/web/apps/photos/src/pages/404.tsx index dcd621c703..55b8b0b860 100644 --- a/web/apps/photos/src/pages/404.tsx +++ b/web/apps/photos/src/pages/404.tsx @@ -1,3 +1,3 @@ -import Page from "@ente/shared/next/pages/404"; +import Page from "@/base/components/pages/404"; export default Page; diff --git a/web/packages/shared/next/pages/404.tsx b/web/packages/base/components/pages/404.tsx similarity index 87% rename from web/packages/shared/next/pages/404.tsx rename to web/packages/base/components/pages/404.tsx index 2118350f4f..3940190c92 100644 --- a/web/packages/shared/next/pages/404.tsx +++ b/web/packages/base/components/pages/404.tsx @@ -1,7 +1,9 @@ -import { PAGES } from "@/accounts/constants/pages"; import { useRouter } from "next/router"; -import { useEffect } from "react"; +import React, { useEffect } from "react"; +/** + * A reusable 404 page. + */ const Page: React.FC = () => { // [Note: 404 back to home] // @@ -21,8 +23,8 @@ const Page: React.FC = () => { const router = useRouter(); useEffect(() => { - router.push(PAGES.ROOT); - }, []); + void router.push("/"); + }, [router]); return <>; };