From 284799bc7ae1ce6183710f79c3f29a406a8b80fd Mon Sep 17 00:00:00 2001 From: Manav Rathi Date: Sun, 30 Jun 2024 17:53:21 +0530 Subject: [PATCH] Second pass --- web/packages/accounts/pages/credentials.tsx | 6 ++---- web/packages/accounts/pages/login.tsx | 4 ++-- web/packages/accounts/pages/signup.tsx | 6 +++--- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/web/packages/accounts/pages/credentials.tsx b/web/packages/accounts/pages/credentials.tsx index f24fbf1550..ab885729fd 100644 --- a/web/packages/accounts/pages/credentials.tsx +++ b/web/packages/accounts/pages/credentials.tsx @@ -231,10 +231,8 @@ const Page: React.FC = ({ appContext }) => { isTwoFactorPasskeysEnabled: true, }); InMemoryStore.set(MS_KEYS.REDIRECT_URL, PAGES.ROOT); - const url = passkeyVerificationRedirectURL( - appName, - passkeySessionID, - ); + const url = + passkeyVerificationRedirectURL(passkeySessionID); setPasskeyVerificationData({ passkeySessionID, url }); openPasskeyVerificationURL({ passkeySessionID, url }); throw Error(CustomError.TWO_FACTOR_ENABLED); diff --git a/web/packages/accounts/pages/login.tsx b/web/packages/accounts/pages/login.tsx index 170a190c9b..3acc87dc2c 100644 --- a/web/packages/accounts/pages/login.tsx +++ b/web/packages/accounts/pages/login.tsx @@ -10,7 +10,7 @@ import { PAGES } from "../constants/pages"; import type { PageProps } from "../types/page"; const Page: React.FC = ({ appContext }) => { - const { appName, showNavBar } = appContext; + const { showNavBar } = appContext; const [loading, setLoading] = useState(true); const [host, setHost] = useState(); @@ -38,7 +38,7 @@ const Page: React.FC = ({ appContext }) => { ) : ( - + ); diff --git a/web/packages/accounts/pages/signup.tsx b/web/packages/accounts/pages/signup.tsx index 72fde8ba74..09efff25bf 100644 --- a/web/packages/accounts/pages/signup.tsx +++ b/web/packages/accounts/pages/signup.tsx @@ -10,7 +10,7 @@ import { SignUp } from "../components/SignUp"; import type { PageProps } from "../types/page"; const Page: React.FC = ({ appContext }) => { - const { appName } = appContext; + const { showNavBar } = appContext; const [loading, setLoading] = useState(true); const [host, setHost] = useState(); @@ -24,7 +24,7 @@ const Page: React.FC = ({ appContext }) => { router.push(PAGES.VERIFY); } setLoading(false); - appContext.showNavBar(true); + showNavBar(true); }, []); const login = () => { @@ -37,7 +37,7 @@ const Page: React.FC = ({ appContext }) => { ) : ( - + )}