From 2c0e8c76c327f75b7ea72f060581e1a0495fc7f9 Mon Sep 17 00:00:00 2001 From: Manav Rathi Date: Thu, 16 May 2024 11:09:02 +0530 Subject: [PATCH] From discussion --- web/apps/photos/src/services/embeddingService.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/web/apps/photos/src/services/embeddingService.ts b/web/apps/photos/src/services/embeddingService.ts index 0c254800ab..17ea5a396d 100644 --- a/web/apps/photos/src/services/embeddingService.ts +++ b/web/apps/photos/src/services/embeddingService.ts @@ -102,6 +102,10 @@ export const syncCLIPEmbeddings = async () => { if (!response.diff?.length) { return; } + // Note: in rare cases we might get a diff entry for an embedding + // corresponding to a file which has been deleted (but whose + // embedding is enqueued for deletion). Client should expect such a + // scenario (all it has to do is just ignore them). const newEmbeddings = await Promise.all( response.diff.map(async (embedding) => { try {