From 2e58400962eef5f0c17dd49ea5f5b60caff047a8 Mon Sep 17 00:00:00 2001
From: AmanRajSinghMourya <amanrajmourya7@gmail.com>
Date: Wed, 3 Sep 2025 10:07:27 +0530
Subject: [PATCH] Add analysis.yaml and minor fix

---
 mobile/packages/sharing/analysis_options.yaml | 72 +++++++++++++++++++
 .../lib/collection_sharing_service.dart       |  2 +-
 mobile/packages/sharing/lib/ente_sharing.dart |  2 +-
 mobile/packages/sharing/pubspec.yaml          | 10 +--
 4 files changed, 79 insertions(+), 7 deletions(-)
 create mode 100644 mobile/packages/sharing/analysis_options.yaml

diff --git a/mobile/packages/sharing/analysis_options.yaml b/mobile/packages/sharing/analysis_options.yaml
new file mode 100644
index 0000000000..1bd78bc1b0
--- /dev/null
+++ b/mobile/packages/sharing/analysis_options.yaml
@@ -0,0 +1,72 @@
+# For more linters, we can check https://dart-lang.github.io/linter/lints/index.html
+# or https://pub.dev/packages/lint (Effective dart)
+# use "flutter analyze ." or "dart  analyze ." for running lint checks
+
+include: package:flutter_lints/flutter.yaml
+linter:
+  rules:
+    # Ref https://github.com/flutter/packages/blob/master/packages/flutter_lints/lib/flutter.yaml
+    # Ref https://dart-lang.github.io/linter/lints/
+    - avoid_print
+    - avoid_unnecessary_containers
+    - avoid_web_libraries_in_flutter
+    - no_logic_in_create_state
+    - prefer_const_constructors
+    - prefer_const_constructors_in_immutables
+    - prefer_const_declarations
+    - prefer_const_literals_to_create_immutables
+    - prefer_final_locals
+    - require_trailing_commas
+    - sized_box_for_whitespace
+    - use_full_hex_values_for_flutter_colors
+    - use_key_in_widget_constructors
+    - cancel_subscriptions
+
+
+    - avoid_empty_else
+    - exhaustive_cases
+
+    # just style suggestions
+    - sort_pub_dependencies
+    - use_rethrow_when_possible
+    - prefer_double_quotes
+    - directives_ordering
+    - always_use_package_imports
+    - sort_child_properties_last
+    - unawaited_futures
+
+analyzer:
+  errors:
+    avoid_empty_else: error
+    exhaustive_cases: error
+    curly_braces_in_flow_control_structures: error
+    directives_ordering: error
+    require_trailing_commas: error
+    always_use_package_imports: warning
+    prefer_final_fields: error
+    unused_import: error
+    camel_case_types: error
+    prefer_is_empty: warning
+    use_rethrow_when_possible: info
+    unused_field: warning
+    use_key_in_widget_constructors: warning
+    sort_child_properties_last: warning
+    sort_pub_dependencies: warning
+    library_private_types_in_public_api: warning
+    constant_identifier_names: ignore
+    prefer_const_constructors: warning
+    prefer_const_declarations: warning
+    prefer_const_constructors_in_immutables: warning
+    prefer_final_locals: warning
+    unnecessary_const: error
+    cancel_subscriptions: error
+    unrelated_type_equality_checks: error
+    unnecessary_cast: info
+
+
+    unawaited_futures: warning # convert to warning after fixing existing issues
+    invalid_dependency: info
+    use_build_context_synchronously: ignore # experimental lint, requires many changes
+    prefer_interpolation_to_compose_strings: ignore # later too many warnings
+    prefer_double_quotes: ignore # too many warnings
+    avoid_renaming_method_parameters: ignore # incorrect warnings for `equals` overrides
diff --git a/mobile/packages/sharing/lib/collection_sharing_service.dart b/mobile/packages/sharing/lib/collection_sharing_service.dart
index 49903b3b6b..0c1217d9cd 100644
--- a/mobile/packages/sharing/lib/collection_sharing_service.dart
+++ b/mobile/packages/sharing/lib/collection_sharing_service.dart
@@ -4,8 +4,8 @@ import 'dart:typed_data';
 import 'package:dio/dio.dart';
 import 'package:ente_crypto_dart/ente_crypto_dart.dart';
 import 'package:ente_network/network.dart';
-import 'package:ente_sharing/models/user.dart';
 import 'package:ente_sharing/errors.dart';
+import 'package:ente_sharing/models/user.dart';
 import 'package:logging/logging.dart';
 
 class CollectionSharingService {
diff --git a/mobile/packages/sharing/lib/ente_sharing.dart b/mobile/packages/sharing/lib/ente_sharing.dart
index 91d543525d..b108fb971d 100644
--- a/mobile/packages/sharing/lib/ente_sharing.dart
+++ b/mobile/packages/sharing/lib/ente_sharing.dart
@@ -1,2 +1,2 @@
-export 'models/user.dart';
 export 'collection_sharing_service.dart';
+export 'models/user.dart';
diff --git a/mobile/packages/sharing/pubspec.yaml b/mobile/packages/sharing/pubspec.yaml
index cec63813d8..7f78e46272 100644
--- a/mobile/packages/sharing/pubspec.yaml
+++ b/mobile/packages/sharing/pubspec.yaml
@@ -8,19 +8,19 @@ environment:
   flutter: ">=3.10.0"
 
 dependencies:
-  flutter:
-    sdk: flutter
+  collection: ^1.17.0
   dio: ^5.0.0
   ente_crypto_dart:
     git:
       url: https://github.com/ente-io/ente_crypto_dart.git
   ente_network:
     path: ../network
-  logging: ^1.0.0
-  collection: ^1.17.0
   fast_base58: ^0.2.1
+  flutter:
+    sdk: flutter
+  logging: ^1.0.0
 
 dev_dependencies:
+  flutter_lints: ^2.0.0
   flutter_test:
     sdk: flutter
-  flutter_lints: ^2.0.0