From 351026377fce5edc73ea85268b755b5a3aacdaf7 Mon Sep 17 00:00:00 2001 From: Manav Rathi Date: Fri, 4 Oct 2024 14:40:30 +0530 Subject: [PATCH] Let it be --- web/packages/shared/themes/components.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/web/packages/shared/themes/components.ts b/web/packages/shared/themes/components.ts index ef3b3731bf..a401a79bb9 100644 --- a/web/packages/shared/themes/components.ts +++ b/web/packages/shared/themes/components.ts @@ -66,14 +66,16 @@ export const getComponents = ( overflowY: "auto", }, "& .MuiDialogActions-root": { - // MUI default is way different, our designs usually want - // the buttons to align with the heading / content. + // MUI default is way since they cluster the buttons to the + // right, our designs usually want the buttons to align with + // the heading / content. padding: "16px", }, ".MuiDialogTitle-root + .MuiDialogContent-root": { // MUI resets this to 0 when the content doesn't use - // dividers (none of ours do). TODO: That is a better - // default, otherwise we end up with double padding. + // dividers (none of ours do). I feel that is a better + // default, since unlike margins, padding doesn't collapse, + // but changing this now would break existing layouts. paddingTop: "16px", }, },