From 70f79ebae492c5ec0fc16a6bf3cb96cc1c839f82 Mon Sep 17 00:00:00 2001
From: Neeraj Gupta <254676+ua741@users.noreply.github.com>
Date: Mon, 28 Oct 2024 15:09:32 +0530
Subject: [PATCH] [server] Change method type

---
 server/cmd/museum/main.go   | 2 +-
 server/pkg/api/file_data.go | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/server/cmd/museum/main.go b/server/cmd/museum/main.go
index dea738d2ae..480d21d32b 100644
--- a/server/cmd/museum/main.go
+++ b/server/cmd/museum/main.go
@@ -424,7 +424,7 @@ func main() {
 	privateAPI.GET("/files/preview/v2/:fileID", fileHandler.GetThumbnail)
 
 	privateAPI.PUT("/files/data", fileHandler.PutFileData)
-	privateAPI.PUT("/files/data/status-diff", fileHandler.FileDataStatusDiff)
+	privateAPI.POST("/files/data/status-diff", fileHandler.FileDataStatusDiff)
 	privateAPI.POST("/files/data/fetch", fileHandler.GetFilesData)
 	privateAPI.GET("/files/data/fetch", fileHandler.GetFileData)
 	privateAPI.GET("/files/data/preview-upload-url", fileHandler.GetPreviewUploadURL)
diff --git a/server/pkg/api/file_data.go b/server/pkg/api/file_data.go
index 149511d1a1..3a3cbbc991 100644
--- a/server/pkg/api/file_data.go
+++ b/server/pkg/api/file_data.go
@@ -48,9 +48,11 @@ func (h *FileHandler) GetFilesData(ctx *gin.Context) {
 	ctx.JSON(http.StatusOK, resp)
 }
 
+// FileDataStatusDiff API won't really return status/diff for deleted files. The clients will primarily use this data to identify for which all files we already have preview generated or it's ML inference is done.
+// This doesn't simulate perfect diff behaviour as we won't maintain a tombstone entries for the deleted API.
 func (h *FileHandler) FileDataStatusDiff(ctx *gin.Context) {
 	var req fileData.IndexDiffRequest
-	if err := ctx.ShouldBindQuery(&req); err != nil {
+	if err := ctx.ShouldBindJSON(&req); err != nil {
 		ctx.JSON(http.StatusBadRequest, ente.NewBadRequestWithMessage(err.Error()))
 		return
 	}