From 731c19d6a9d1380fb4a92d7937122e02a4b79934 Mon Sep 17 00:00:00 2001 From: Manav Rathi Date: Wed, 5 Mar 2025 12:13:39 +0530 Subject: [PATCH] Notes of what needs to be done --- .../pages/gallery/SelectedFileOptions.tsx | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/web/apps/photos/src/components/pages/gallery/SelectedFileOptions.tsx b/web/apps/photos/src/components/pages/gallery/SelectedFileOptions.tsx index fcf1d5c452..e9bc01a1fc 100644 --- a/web/apps/photos/src/components/pages/gallery/SelectedFileOptions.tsx +++ b/web/apps/photos/src/components/pages/gallery/SelectedFileOptions.tsx @@ -48,6 +48,27 @@ interface Props { activeCollectionID: number; isFavoriteCollection: boolean; isUncategorizedCollection: boolean; + /** + * TODO: Need to implement delete-equivalent from shared albums. + * + * Notes: + * + * - Delete action should not be enabled 3 selected (0 Yours). There should + * be separate remove action. + * + * - On remove, if the file and collection both belong to current user, we + * just use move api to existing or uncat collection. + * + * - Otherwise, we call /collections/v3/remove-files (when collection and + * file belong to different users). + * + * - Album owner can remove files of all other users from their collection. + * Particiapant (viewer/collaborator) can only remove files that belong to + * them. + * + * Also note that that user cannot delete files that are not owned by the + * user, even if they are in an album owned by the user. + */ isIncomingSharedCollection: boolean; isInSearchMode: boolean; selectedCollection: Collection;