From 7340e5a10027c8b3f8659003dd98856da77b3c32 Mon Sep 17 00:00:00 2001 From: ashilkn Date: Wed, 16 Jul 2025 11:14:29 +0530 Subject: [PATCH] Fix scroll bar divisions not appearing --- .../scrollbar/custom_scroll_bar_2.dart | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/mobile/apps/photos/lib/ui/viewer/gallery/scrollbar/custom_scroll_bar_2.dart b/mobile/apps/photos/lib/ui/viewer/gallery/scrollbar/custom_scroll_bar_2.dart index 5b2046c507..929be0b726 100644 --- a/mobile/apps/photos/lib/ui/viewer/gallery/scrollbar/custom_scroll_bar_2.dart +++ b/mobile/apps/photos/lib/ui/viewer/gallery/scrollbar/custom_scroll_bar_2.dart @@ -57,7 +57,7 @@ class _CustomScrollBar2State extends State { static const _bottomPadding = 92.0; double? heightOfScrollbarDivider; double? heightOfScrollTrack; - late final bool _showScrollbarDivisions; + late bool _showScrollbarDivisions; // Scrollbar's heigh is not fixed by default. If the scrollable is short // enough, the scrollbar's height can go above the minimum length. @@ -69,6 +69,17 @@ class _CustomScrollBar2State extends State { @override void initState() { super.initState(); + _init(); + } + + @override + void didUpdateWidget(covariant CustomScrollBar2 oldWidget) { + super.didUpdateWidget(oldWidget); + _init(); + } + + void _init() { + _logger.info("Initializing CustomScrollBar2"); if (widget.galleryGroups.groupLayouts.last.maxOffset > widget.heighOfViewport * 5) { _showScrollbarDivisions = true; @@ -94,16 +105,7 @@ class _CustomScrollBar2State extends State { } } - @override - void didUpdateWidget(covariant CustomScrollBar2 oldWidget) { - super.didUpdateWidget(oldWidget); - if (_showScrollbarDivisions) { - _computePositionToTitleMap(); - } - } - Future _computePositionToTitleMap() async { - _logger.info("computing postition to title map"); final result = <({double position, String title})>[]; heightOfScrollTrack = await _getHeightOfScrollTrack(); final maxScrollExtent = widget.scrollController.position.maxScrollExtent;