From 76c5f5cbb68e71da80b744a4d0d3fa400d0dfdf9 Mon Sep 17 00:00:00 2001 From: laurenspriem Date: Tue, 2 Sep 2025 10:28:03 +0530 Subject: [PATCH] Fix all Flutter analyze errors and warnings --- .../library_culling/swipe_culling_page.dart | 31 ++++++++++++------- .../widgets/group_carousel.dart | 2 +- .../widgets/group_summary_popup.dart | 2 +- .../lib/ui/tools/similar_images_page.dart | 2 +- 4 files changed, 22 insertions(+), 15 deletions(-) diff --git a/mobile/apps/photos/lib/ui/pages/library_culling/swipe_culling_page.dart b/mobile/apps/photos/lib/ui/pages/library_culling/swipe_culling_page.dart index d486c469a1..b7656bea57 100644 --- a/mobile/apps/photos/lib/ui/pages/library_culling/swipe_culling_page.dart +++ b/mobile/apps/photos/lib/ui/pages/library_culling/swipe_culling_page.dart @@ -5,7 +5,6 @@ import 'package:flutter_animate/flutter_animate.dart'; import 'package:flutter_card_swiper/flutter_card_swiper.dart'; import 'package:logging/logging.dart'; import 'package:photos/core/configuration.dart'; -import 'package:photos/ente_theme_data.dart'; import 'package:photos/generated/l10n.dart'; import 'package:photos/models/file/file.dart'; import 'package:photos/models/similar_files.dart'; @@ -223,7 +222,7 @@ class _SwipeCullingPageState extends State return AlertDialog( title: Text(AppLocalizations.of(context).deleteAllInGroup), content: Text( - AppLocalizations.of(context).allImagesMarkedForDeletion(groupSize), + AppLocalizations.of(context).allImagesMarkedForDeletion(count: groupSize), ), actions: [ TextButton( @@ -276,8 +275,8 @@ class _SwipeCullingPageState extends State context, title: AppLocalizations.of(context).deletePhotos, body: AppLocalizations.of(context).deletePhotosBody( - filesToDelete.length.toString(), - formatBytes(totalSize), + count: filesToDelete.length.toString(), + size: formatBytes(totalSize), ), firstButtonLabel: AppLocalizations.of(context).delete, isCritical: true, @@ -486,8 +485,8 @@ class _SwipeCullingPageState extends State title: Text(AppLocalizations.of(context).congratulations), content: Text( AppLocalizations.of(context).deletedPhotosWithSize( - deletedCount.toString(), - formatBytes(totalSize), + count: deletedCount.toString(), + size: formatBytes(totalSize), ), ), actions: [ @@ -570,8 +569,12 @@ class _SwipeCullingPageState extends State numberOfCardsDisplayed: 1, backCardOffset: const Offset(0, 0), padding: const EdgeInsets.all(24.0), - cardBuilder: (context, index, percentThresholdX, - percentThresholdY) { + cardBuilder: ( + context, + index, + percentThresholdX, + percentThresholdY, + ) { final fileIndex = currentImageIndex + index; if (fileIndex >= currentGroupFiles.length) { return const SizedBox.shrink(); @@ -648,7 +651,8 @@ class _SwipeCullingPageState extends State ) .animate( controller: - _celebrationController) + _celebrationController, + ) .scaleXY( begin: 0.8, end: 1.2, @@ -669,7 +673,8 @@ class _SwipeCullingPageState extends State ) .animate( controller: - _celebrationController) + _celebrationController, + ) .fadeIn(delay: 200.ms), ], ), @@ -705,8 +710,10 @@ class _SwipeCullingPageState extends State onPressed: currentFile != null ? () => controller.swipe(CardSwiperDirection.right) : null, - icon: Icon(Icons.thumb_up_outlined, - color: theme.primary700), + icon: Icon( + Icons.thumb_up_outlined, + color: theme.primary700, + ), iconSize: 32, ), ], diff --git a/mobile/apps/photos/lib/ui/pages/library_culling/widgets/group_carousel.dart b/mobile/apps/photos/lib/ui/pages/library_culling/widgets/group_carousel.dart index 702efc856a..53e0ecd326 100644 --- a/mobile/apps/photos/lib/ui/pages/library_culling/widgets/group_carousel.dart +++ b/mobile/apps/photos/lib/ui/pages/library_culling/widgets/group_carousel.dart @@ -60,7 +60,7 @@ class GroupCarousel extends StatelessWidget { boxShadow: isCurrentGroup ? [ BoxShadow( - color: theme.primary500.withOpacity(0.3), + color: theme.primary500.withValues(alpha: 0.3), blurRadius: 8, offset: const Offset(0, 2), ), diff --git a/mobile/apps/photos/lib/ui/pages/library_culling/widgets/group_summary_popup.dart b/mobile/apps/photos/lib/ui/pages/library_culling/widgets/group_summary_popup.dart index 6bbab23df2..072d7e45df 100644 --- a/mobile/apps/photos/lib/ui/pages/library_culling/widgets/group_summary_popup.dart +++ b/mobile/apps/photos/lib/ui/pages/library_culling/widgets/group_summary_popup.dart @@ -69,7 +69,7 @@ class GroupSummaryPopup extends StatelessWidget { Padding( padding: const EdgeInsets.symmetric(vertical: 8), child: Text( - AppLocalizations.of(context).storageToBeFreed(formatBytes(totalSize)), + AppLocalizations.of(context).storageToBeFreed(size: formatBytes(totalSize)), style: Theme.of(context).textTheme.bodyMedium?.copyWith( color: theme.warning700, ), diff --git a/mobile/apps/photos/lib/ui/tools/similar_images_page.dart b/mobile/apps/photos/lib/ui/tools/similar_images_page.dart index a393b25675..6b81a02b6d 100644 --- a/mobile/apps/photos/lib/ui/tools/similar_images_page.dart +++ b/mobile/apps/photos/lib/ui/tools/similar_images_page.dart @@ -19,13 +19,13 @@ import "package:photos/theme/text_style.dart"; import 'package:photos/ui/components/buttons/button_widget.dart'; import "package:photos/ui/components/models/button_type.dart"; import "package:photos/ui/components/toggle_switch_widget.dart"; +import "package:photos/ui/pages/library_culling/swipe_culling_page.dart"; import "package:photos/ui/viewer/file/detail_page.dart"; import "package:photos/ui/viewer/file/thumbnail_widget.dart"; import "package:photos/ui/viewer/gallery/empty_state.dart"; import "package:photos/utils/delete_file_util.dart"; import "package:photos/utils/dialog_util.dart"; import "package:photos/utils/navigation_util.dart"; -import 'package:photos/ui/pages/library_culling/swipe_culling_page.dart'; import "package:photos/utils/standalone/data.dart"; enum SimilarImagesPageState {