From a8d3a8bfe8c88708edbce504161b551ec053af07 Mon Sep 17 00:00:00 2001 From: Manav Rathi Date: Mon, 6 May 2024 16:08:23 +0530 Subject: [PATCH] Remove duplicate notarization attempt MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From build logs: • notarization successful Error: The appleIdPassword property is required when using notarization with password credentials at validateNotaryToolAuthorizationArgs (/Users/runner/work/photos-desktop/photos-desktop/desktop/node_modules/electron-notarize/src/validate-args.ts:107:13) Not sure, but at the face of it (since this was not enabled earlier too), our notarization process kicks in during signing because of the presence of env vars, and specifying it again here starts a separate process we haven't configured. --- desktop/electron-builder.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/desktop/electron-builder.yml b/desktop/electron-builder.yml index f62033fb9c..298b1c5f36 100644 --- a/desktop/electron-builder.yml +++ b/desktop/electron-builder.yml @@ -29,5 +29,4 @@ mac: arch: [universal] category: public.app-category.photography hardenedRuntime: true - notarize: true afterSign: electron-builder-notarize