From cba69a84d3882f77fba7ffdf870e9f44b4370d26 Mon Sep 17 00:00:00 2001 From: Neeraj Gupta <254676+ua741@users.noreply.github.com> Date: Tue, 27 Aug 2024 15:39:41 +0530 Subject: [PATCH 1/4] [mob] Skip exporting untranslated strings for store listing --- mobile/crowdin.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mobile/crowdin.yml b/mobile/crowdin.yml index 27c72a52b0..fca358689a 100644 --- a/mobile/crowdin.yml +++ b/mobile/crowdin.yml @@ -6,15 +6,19 @@ files: translation: /lib/l10n/intl_%two_letters_code%.arb dest: /%original_file_name% type: arb + skip_untranslated_files: false - source: /fastlane/metadata/playstore/en-US/*.txt translation: /fastlane/metadata/playstore/%two_letters_code%/%original_file_name% dest: /playstore/%original_file_name% type: txt + skip_untranslated_files: true - source: /fastlane/metadata/android/en-US/*.txt translation: /fastlane/metadata/android/%two_letters_code%/%original_file_name% dest: /fdroid/%original_file_name% type: txt + skip_untranslated_files: true - source: /fastlane/metadata/ios/en-US/*.txt translation: /fastlane/metadata/ios/%two_letters_code%/%original_file_name% dest: /appstore/%original_file_name% type: txt + skip_untranslated_files: true From 5e05e50049c465725769c8556252d3621b671811 Mon Sep 17 00:00:00 2001 From: Neeraj Gupta <254676+ua741@users.noreply.github.com> Date: Tue, 27 Aug 2024 15:46:43 +0530 Subject: [PATCH 2/4] [mob] Fix lint --- mobile/lib/services/user_service.dart | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mobile/lib/services/user_service.dart b/mobile/lib/services/user_service.dart index 4c20429b08..fca3fbcff5 100644 --- a/mobile/lib/services/user_service.dart +++ b/mobile/lib/services/user_service.dart @@ -610,7 +610,8 @@ class UserService { SetupSRPResponse.fromJson(response.data); final serverB = SRP6Util.decodeBigInt(base64Decode(setupSRPResponse.srpB)); - // ignore: need to calculate secret to get M1, unused_local_variable + + // ignore: unused_local_variable final clientS = client.calculateSecret(serverB); final clientM = client.calculateClientEvidenceMessage(); // ignore: unused_local_variable @@ -696,7 +697,7 @@ class UserService { final String srpB = createSessionResponse.data["srpB"]; final serverB = SRP6Util.decodeBigInt(base64Decode(srpB)); - // ignore: need to calculate secret to get M1, unused_local_variable + // ignore: unused_local_variable final clientS = client.calculateSecret(serverB); final clientM = client.calculateClientEvidenceMessage(); final response = await _dio.post( From b9f8f55a30fd6a13de54657f53d746ea7227e441 Mon Sep 17 00:00:00 2001 From: Neeraj Gupta <254676+ua741@users.noreply.github.com> Date: Tue, 27 Aug 2024 15:57:58 +0530 Subject: [PATCH 3/4] [mob] Upgrade crowdin config --- .github/workflows/mobile-crowdin-sync.yml | 1 - mobile/crowdin.yml | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/mobile-crowdin-sync.yml b/.github/workflows/mobile-crowdin-sync.yml index 5f8da62b4d..39062cd6f5 100644 --- a/.github/workflows/mobile-crowdin-sync.yml +++ b/.github/workflows/mobile-crowdin-sync.yml @@ -26,7 +26,6 @@ jobs: download_translations: true localization_branch_name: translations/mobile create_pull_request: true - skip_untranslated_strings: true pull_request_title: "[mobile] New translations" pull_request_body: "New translations from [Crowdin](https://crowdin.com/project/ente-photos-app)" pull_request_base_branch_name: "main" diff --git a/mobile/crowdin.yml b/mobile/crowdin.yml index fca358689a..c478a5ded7 100644 --- a/mobile/crowdin.yml +++ b/mobile/crowdin.yml @@ -6,6 +6,7 @@ files: translation: /lib/l10n/intl_%two_letters_code%.arb dest: /%original_file_name% type: arb + skip_untranslated_strings: false skip_untranslated_files: false - source: /fastlane/metadata/playstore/en-US/*.txt translation: /fastlane/metadata/playstore/%two_letters_code%/%original_file_name% From c2a5f85a02857d45a711d63c1dd97a2d0a15660e Mon Sep 17 00:00:00 2001 From: Neeraj Gupta <254676+ua741@users.noreply.github.com> Date: Tue, 27 Aug 2024 16:02:10 +0530 Subject: [PATCH 4/4] [mob] Skip untranslated strings --- mobile/crowdin.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mobile/crowdin.yml b/mobile/crowdin.yml index c478a5ded7..efe5e4de50 100644 --- a/mobile/crowdin.yml +++ b/mobile/crowdin.yml @@ -6,7 +6,7 @@ files: translation: /lib/l10n/intl_%two_letters_code%.arb dest: /%original_file_name% type: arb - skip_untranslated_strings: false + skip_untranslated_strings: true skip_untranslated_files: false - source: /fastlane/metadata/playstore/en-US/*.txt translation: /fastlane/metadata/playstore/%two_letters_code%/%original_file_name%