From b89378e83896a5e3af755f3dfd2d679862bac4fc Mon Sep 17 00:00:00 2001
From: Neeraj Gupta <254676+ua741@users.noreply.github.com>
Date: Tue, 18 Jun 2024 22:54:42 +0530
Subject: [PATCH] Return bad request if name validation fails

---
 server/ente/errors.go             | 2 --
 server/pkg/controller/passkeys.go | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/server/ente/errors.go b/server/ente/errors.go
index 89fdebb17f..528a92317b 100644
--- a/server/ente/errors.go
+++ b/server/ente/errors.go
@@ -105,8 +105,6 @@ var ErrNotImplemented = errors.New("not implemented")
 
 var ErrInvalidApp = errors.New("invalid app")
 
-var ErrInvalidName = errors.New("invalid name")
-
 var ErrSubscriptionAlreadyClaimed = ApiError{
 	Code:           SubscriptionAlreadyClaimed,
 	HttpStatusCode: http.StatusConflict,
diff --git a/server/pkg/controller/passkeys.go b/server/pkg/controller/passkeys.go
index 3cc6031d0d..926d23cedc 100644
--- a/server/pkg/controller/passkeys.go
+++ b/server/pkg/controller/passkeys.go
@@ -53,7 +53,7 @@ func (c *PasskeyController) RemovePasskey2FA(userID int64) (err error) {
 
 func (c *PasskeyController) RenamePasskey(userID int64, passkeyID uuid.UUID, newName string) (err error) {
 	if len(newName) < 1 || len(newName) > 32 {
-		err = ente.ErrInvalidName
+		err = ente.NewBadRequestWithMessage("friendlyName must be between 1 and 32 characters")
 		return
 	}