From b921ca74935b14122966d9ed439bd778cd372003 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Fri, 10 Jan 2025 08:13:38 +0530
Subject: [PATCH] wip Ungloblicate

---
 web/apps/accounts/src/pages/_app.tsx           | 7 +------
 web/apps/accounts/src/pages/passkeys/index.tsx | 8 ++++----
 web/packages/accounts/types/context.ts         | 4 ----
 3 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/web/apps/accounts/src/pages/_app.tsx b/web/apps/accounts/src/pages/_app.tsx
index 55a45d61f1..4a9ee8542b 100644
--- a/web/apps/accounts/src/pages/_app.tsx
+++ b/web/apps/accounts/src/pages/_app.tsx
@@ -2,7 +2,6 @@ import { staticAppTitle } from "@/base/app";
 import { CustomHead } from "@/base/components/Head";
 import { LoadingOverlay } from "@/base/components/LoadingOverlay";
 import { AttributedMiniDialog } from "@/base/components/MiniDialog";
-import { AppNavbar } from "@/base/components/Navbar";
 import { useAttributedMiniDialog } from "@/base/components/utils/dialog";
 import { useSetupI18n } from "@/base/components/utils/hooks-i18n";
 import { getTheme, THEME_COLOR } from "@/base/components/utils/theme";
@@ -13,14 +12,12 @@ import { CssBaseline } from "@mui/material";
 import { ThemeProvider } from "@mui/material/styles";
 import { t } from "i18next";
 import type { AppProps } from "next/app";
-import React, { useEffect, useMemo, useState } from "react";
+import React, { useEffect, useMemo } from "react";
 import { AppContext } from "../types/context";
 
 import "styles/global.css";
 
 const App: React.FC<AppProps> = ({ Component, pageProps }) => {
-    const [showNavbar, setShowNavbar] = useState(false);
-
     const isI18nReady = useSetupI18n();
     const { showMiniDialog, miniDialogProps } = useAttributedMiniDialog();
 
@@ -32,7 +29,6 @@ const App: React.FC<AppProps> = ({ Component, pageProps }) => {
 
     const appContext = useMemo(
         () => ({
-            showNavBar: setShowNavbar,
             showMiniDialog,
         }),
         [showMiniDialog],
@@ -50,7 +46,6 @@ const App: React.FC<AppProps> = ({ Component, pageProps }) => {
 
                 <AppContext.Provider value={appContext}>
                     {!isI18nReady && <LoadingOverlay />}
-                    {showNavbar && <AppNavbar />}
                     {isI18nReady && <Component {...pageProps} />}
                 </AppContext.Provider>
             </ThemeProvider>
diff --git a/web/apps/accounts/src/pages/passkeys/index.tsx b/web/apps/accounts/src/pages/passkeys/index.tsx
index 3138d041d0..b7d89fab4c 100644
--- a/web/apps/accounts/src/pages/passkeys/index.tsx
+++ b/web/apps/accounts/src/pages/passkeys/index.tsx
@@ -1,6 +1,7 @@
 import { FormPaper } from "@/base/components/FormPaper";
 import { MenuItemDivider, MenuItemGroup } from "@/base/components/Menu";
 import { SidebarDrawer } from "@/base/components/mui/SidebarDrawer";
+import { AppNavbar } from "@/base/components/Navbar";
 import { SingleInputDialog } from "@/base/components/SingleInputDialog";
 import { Titlebar } from "@/base/components/Titlebar";
 import { errorDialogAttributes } from "@/base/components/utils/dialog";
@@ -28,7 +29,7 @@ import {
 import { useAppContext } from "../../types/context";
 
 const Page: React.FC = () => {
-    const { showNavBar, showMiniDialog } = useAppContext();
+    const { showMiniDialog } = useAppContext();
 
     const [token, setToken] = useState<string | undefined>();
     const [passkeys, setPasskeys] = useState<Passkey[]>([]);
@@ -42,8 +43,6 @@ const Page: React.FC = () => {
     }, [showMiniDialog]);
 
     useEffect(() => {
-        showNavBar(true);
-
         const urlParams = new URLSearchParams(window.location.search);
 
         const token = urlParams.get("token");
@@ -53,7 +52,7 @@ const Page: React.FC = () => {
             log.error("Missing accounts token");
             showPasskeyFetchFailedErrorDialog();
         }
-    }, [showNavBar, showPasskeyFetchFailedErrorDialog]);
+    }, [showPasskeyFetchFailedErrorDialog]);
 
     const refreshPasskeys = useCallback(async () => {
         try {
@@ -116,6 +115,7 @@ const Page: React.FC = () => {
 
     return (
         <>
+            <AppNavbar />
             <CenteredFlex>
                 <Box sx={{ maxWidth: "20rem" }}>
                     <Box sx={{ marginBottom: "1rem" }}>
diff --git a/web/packages/accounts/types/context.ts b/web/packages/accounts/types/context.ts
index d625db096c..12f9584802 100644
--- a/web/packages/accounts/types/context.ts
+++ b/web/packages/accounts/types/context.ts
@@ -9,10 +9,6 @@ export interface AccountsContextT {
      * Perform the (possibly app specific) logout sequence.
      */
     logout: () => void;
-    /**
-     * Show or hide the app's navigation bar.
-     */
-    showNavBar: (show: boolean) => void;
     /**
      * Show a "mini dialog" with the given attributes.
      *