From c1587cc5ea851d858e4ca638f346bae73a287a80 Mon Sep 17 00:00:00 2001 From: ashilkn Date: Mon, 22 Apr 2024 11:52:39 +0530 Subject: [PATCH] [mob] Remove redundant clippling and anti aliasing for performance gain --- mobile/lib/ui/viewer/file_details/face_widget.dart | 12 ++++-------- .../ui/viewer/people/cropped_face_image_view.dart | 4 ++-- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/mobile/lib/ui/viewer/file_details/face_widget.dart b/mobile/lib/ui/viewer/file_details/face_widget.dart index beaff4d16b..898dcf8afa 100644 --- a/mobile/lib/ui/viewer/file_details/face_widget.dart +++ b/mobile/lib/ui/viewer/file_details/face_widget.dart @@ -48,7 +48,7 @@ class _FaceWidgetState extends State { @override Widget build(BuildContext context) { - if (Platform.isAndroid) { + if (Platform.isIOS) { return FutureBuilder( future: getFaceCrop(), builder: (context, snapshot) { @@ -277,13 +277,9 @@ class _FaceWidgetState extends State { : BorderSide.none, ), ), - child: ClipRRect( - borderRadius: - const BorderRadius.all(Radius.elliptical(16, 12)), - child: CroppedFaceImageView( - enteFile: widget.file, - face: widget.face, - ), + child: CroppedFaceImageView( + enteFile: widget.file, + face: widget.face, ), ), const SizedBox(height: 8), diff --git a/mobile/lib/ui/viewer/people/cropped_face_image_view.dart b/mobile/lib/ui/viewer/people/cropped_face_image_view.dart index d4877a2d01..2c7768f7fd 100644 --- a/mobile/lib/ui/viewer/people/cropped_face_image_view.dart +++ b/mobile/lib/ui/viewer/people/cropped_face_image_view.dart @@ -76,8 +76,8 @@ class CroppedFaceImageView extends StatelessWidget { offsetY = offsetY / imageToWidgetRatio; } - return ClipRect( - clipBehavior: Clip.antiAlias, + return ClipRRect( + borderRadius: const BorderRadius.all(Radius.elliptical(16, 12)), child: Transform.translate( offset: Offset( offsetX,