From f5754eb2e19f219599d3dd8eec459d0da28b94f4 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 13:01:29 +0530
Subject: [PATCH 01/41] Remove uses of path

---
 .../photos/src/components/Upload/Uploader.tsx |  4 +-
 web/packages/shared/hooks/useFileInput.tsx    | 41 ++++++-------------
 2 files changed, 15 insertions(+), 30 deletions(-)

diff --git a/web/apps/photos/src/components/Upload/Uploader.tsx b/web/apps/photos/src/components/Upload/Uploader.tsx
index fdc6ee9329..90b5f94b4e 100644
--- a/web/apps/photos/src/components/Upload/Uploader.tsx
+++ b/web/apps/photos/src/components/Upload/Uploader.tsx
@@ -324,8 +324,8 @@ export default function Uploader({
     // Trigger an upload when any of the dependencies change.
     useEffect(() => {
         const allItemAndPaths = [
-            /* TODO(MR): ElectronFile | use webkitRelativePath || name here */
-            webFiles.map((f) => [f, f["path"] ?? f.name]),
+            // See: [Note: webkitRelativePath]
+            webFiles.map((f) => [f, f.webkitRelativePath ?? f.name]),
             desktopFiles.map((fp) => [fp, fp.path]),
             desktopFilePaths.map((p) => [p, p]),
             desktopZipItems.map((ze) => [ze, ze[1]]),
diff --git a/web/packages/shared/hooks/useFileInput.tsx b/web/packages/shared/hooks/useFileInput.tsx
index 4eb346d39c..158a71b44e 100644
--- a/web/packages/shared/hooks/useFileInput.tsx
+++ b/web/packages/shared/hooks/useFileInput.tsx
@@ -72,19 +72,27 @@ export default function useFileInput({
         event,
     ) => {
         if (!!event.target && !!event.target.files) {
-            const files = [...event.target.files].map((file) =>
-                toFileWithPath(file),
-            );
-            setSelectedFiles(files);
+            setSelectedFiles([...event.target.files]);
         }
     };
 
+    // [Note: webkitRelativePath]
+    //
+    // If the webkitdirectory attribute of an <input> HTML element is set then
+    // the File objects that we get will have `webkitRelativePath` property
+    // containing the relative path to the selected directory.
+    //
+    // https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory
+    const directoryOpts = directory
+        ? { directory: "", webkitdirectory: "" }
+        : {};
+
     const getInputProps = useCallback(
         () => ({
             type: "file",
             multiple: true,
             style: { display: "none" },
-            ...(directory ? { directory: "", webkitdirectory: "" } : {}),
+            ...directoryOpts,
             ref: inputRef,
             onChange: handleChange,
             ...(accept ? { accept } : {}),
@@ -98,26 +106,3 @@ export default function useFileInput({
         selectedFiles: selectedFiles,
     };
 }
-
-// https://github.com/react-dropzone/file-selector/blob/master/src/file.ts#L88
-export function toFileWithPath(file: File, path?: string): FileWithPath {
-    if (typeof (file as any).path !== "string") {
-        // on electron, path is already set to the absolute path
-        const { webkitRelativePath } = file;
-        Object.defineProperty(file, "path", {
-            value:
-                typeof path === "string"
-                    ? path
-                    : typeof webkitRelativePath === "string" && // If <input webkitdirectory> is set,
-                        // the File will have a {webkitRelativePath} property
-                        // https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory
-                        webkitRelativePath.length > 0
-                      ? webkitRelativePath
-                      : file.name,
-            writable: false,
-            configurable: false,
-            enumerable: true,
-        });
-    }
-    return file;
-}

From f84937f8c1dc38a83e0e4b342bf932a624a17f47 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 13:26:55 +0530
Subject: [PATCH 02/41] Bye ElectronFile

---
 desktop/src/main/dialogs.ts                |  72 ----------
 desktop/src/main/ipc.ts                    |  19 +--
 desktop/src/main/services/dialog.ts        |  10 ++
 desktop/src/main/services/fs.ts            | 154 ---------------------
 desktop/src/main/services/image.ts         |   2 +-
 desktop/src/main/services/upload.ts        |  53 +------
 desktop/src/main/services/watch.ts         |   8 +-
 desktop/src/main/utils-path.ts             |   8 ++
 desktop/src/main/utils-temp.ts             |   2 +-
 desktop/src/preload.ts                     |  14 +-
 web/packages/next/types/ipc.ts             |  30 ++--
 web/packages/shared/hooks/useFileInput.tsx |  23 ---
 12 files changed, 44 insertions(+), 351 deletions(-)
 delete mode 100644 desktop/src/main/dialogs.ts
 create mode 100644 desktop/src/main/services/dialog.ts
 delete mode 100644 desktop/src/main/services/fs.ts
 create mode 100644 desktop/src/main/utils-path.ts

diff --git a/desktop/src/main/dialogs.ts b/desktop/src/main/dialogs.ts
deleted file mode 100644
index f119e3d133..0000000000
--- a/desktop/src/main/dialogs.ts
+++ /dev/null
@@ -1,72 +0,0 @@
-import { dialog } from "electron/main";
-import fs from "node:fs/promises";
-import path from "node:path";
-import type { ElectronFile } from "../types/ipc";
-import { getElectronFile } from "./services/fs";
-import { getElectronFilesFromGoogleZip } from "./services/upload";
-
-export const selectDirectory = async () => {
-    const result = await dialog.showOpenDialog({
-        properties: ["openDirectory"],
-    });
-    if (result.filePaths && result.filePaths.length > 0) {
-        return result.filePaths[0]?.split(path.sep)?.join(path.posix.sep);
-    }
-};
-
-export const showUploadFilesDialog = async () => {
-    const selectedFiles = await dialog.showOpenDialog({
-        properties: ["openFile", "multiSelections"],
-    });
-    const filePaths = selectedFiles.filePaths;
-    return await Promise.all(filePaths.map(getElectronFile));
-};
-
-export const showUploadDirsDialog = async () => {
-    const dir = await dialog.showOpenDialog({
-        properties: ["openDirectory", "multiSelections"],
-    });
-
-    let filePaths: string[] = [];
-    for (const dirPath of dir.filePaths) {
-        filePaths = [...filePaths, ...(await getDirFilePaths(dirPath))];
-    }
-
-    return await Promise.all(filePaths.map(getElectronFile));
-};
-
-// https://stackoverflow.com/a/63111390
-const getDirFilePaths = async (dirPath: string) => {
-    if (!(await fs.stat(dirPath)).isDirectory()) {
-        return [dirPath];
-    }
-
-    let files: string[] = [];
-    const filePaths = await fs.readdir(dirPath);
-
-    for (const filePath of filePaths) {
-        const absolute = path.join(dirPath, filePath);
-        files = [...files, ...(await getDirFilePaths(absolute))];
-    }
-
-    return files;
-};
-
-export const showUploadZipDialog = async () => {
-    const selectedFiles = await dialog.showOpenDialog({
-        properties: ["openFile", "multiSelections"],
-        filters: [{ name: "Zip File", extensions: ["zip"] }],
-    });
-    const filePaths = selectedFiles.filePaths;
-
-    let files: ElectronFile[] = [];
-
-    for (const filePath of filePaths) {
-        files = [...files, ...(await getElectronFilesFromGoogleZip(filePath))];
-    }
-
-    return {
-        zipPaths: filePaths,
-        files,
-    };
-};
diff --git a/desktop/src/main/ipc.ts b/desktop/src/main/ipc.ts
index df6ab7c8ea..bb5daeabac 100644
--- a/desktop/src/main/ipc.ts
+++ b/desktop/src/main/ipc.ts
@@ -16,12 +16,6 @@ import type {
     PendingUploads,
     ZipItem,
 } from "../types/ipc";
-import {
-    selectDirectory,
-    showUploadDirsDialog,
-    showUploadFilesDialog,
-    showUploadZipDialog,
-} from "./dialogs";
 import {
     fsExists,
     fsIsDir,
@@ -39,6 +33,7 @@ import {
     updateAndRestart,
     updateOnNextRestart,
 } from "./services/app-update";
+import { selectDirectory } from "./services/dialog";
 import { ffmpegExec } from "./services/ffmpeg";
 import { convertToJPEG, generateImageThumbnail } from "./services/image";
 import {
@@ -102,6 +97,8 @@ export const attachIPCHandlers = () => {
     // See [Note: Catching exception during .send/.on]
     ipcMain.on("logToDisk", (_, message) => logToDisk(message));
 
+    ipcMain.handle("selectDirectory", () => selectDirectory());
+
     ipcMain.on("clearStores", () => clearStores());
 
     ipcMain.handle("saveEncryptionKey", (_, encryptionKey) =>
@@ -193,16 +190,6 @@ export const attachIPCHandlers = () => {
         faceEmbedding(input),
     );
 
-    // - File selection
-
-    ipcMain.handle("selectDirectory", () => selectDirectory());
-
-    ipcMain.handle("showUploadFilesDialog", () => showUploadFilesDialog());
-
-    ipcMain.handle("showUploadDirsDialog", () => showUploadDirsDialog());
-
-    ipcMain.handle("showUploadZipDialog", () => showUploadZipDialog());
-
     // - Upload
 
     ipcMain.handle("listZipItems", (_, zipPath: string) =>
diff --git a/desktop/src/main/services/dialog.ts b/desktop/src/main/services/dialog.ts
new file mode 100644
index 0000000000..e98a6a9dd6
--- /dev/null
+++ b/desktop/src/main/services/dialog.ts
@@ -0,0 +1,10 @@
+import { dialog } from "electron/main";
+import { posixPath } from "../utils-path";
+
+export const selectDirectory = async () => {
+    const result = await dialog.showOpenDialog({
+        properties: ["openDirectory"],
+    });
+    const dirPath = result.filePaths[0];
+    return dirPath ? posixPath(dirPath) : undefined;
+};
diff --git a/desktop/src/main/services/fs.ts b/desktop/src/main/services/fs.ts
deleted file mode 100644
index 609fc82d7e..0000000000
--- a/desktop/src/main/services/fs.ts
+++ /dev/null
@@ -1,154 +0,0 @@
-import StreamZip from "node-stream-zip";
-import { existsSync } from "node:fs";
-import fs from "node:fs/promises";
-import path from "node:path";
-import { ElectronFile } from "../../types/ipc";
-import log from "../log";
-
-const FILE_STREAM_CHUNK_SIZE: number = 4 * 1024 * 1024;
-
-const getFileStream = async (filePath: string) => {
-    const file = await fs.open(filePath, "r");
-    let offset = 0;
-    const readableStream = new ReadableStream<Uint8Array>({
-        async pull(controller) {
-            try {
-                const buff = new Uint8Array(FILE_STREAM_CHUNK_SIZE);
-                const bytesRead = (await file.read(
-                    buff,
-                    0,
-                    FILE_STREAM_CHUNK_SIZE,
-                    offset,
-                )) as unknown as number;
-                offset += bytesRead;
-                if (bytesRead === 0) {
-                    controller.close();
-                    await file.close();
-                } else {
-                    controller.enqueue(buff.slice(0, bytesRead));
-                }
-            } catch (e) {
-                await file.close();
-            }
-        },
-        async cancel() {
-            await file.close();
-        },
-    });
-    return readableStream;
-};
-
-export async function getElectronFile(filePath: string): Promise<ElectronFile> {
-    const fileStats = await fs.stat(filePath);
-    return {
-        path: filePath.split(path.sep).join(path.posix.sep),
-        name: path.basename(filePath),
-        size: fileStats.size,
-        lastModified: fileStats.mtime.valueOf(),
-        stream: async () => {
-            if (!existsSync(filePath)) {
-                throw new Error("electronFile does not exist");
-            }
-            return await getFileStream(filePath);
-        },
-        blob: async () => {
-            if (!existsSync(filePath)) {
-                throw new Error("electronFile does not exist");
-            }
-            const blob = await fs.readFile(filePath);
-            return new Blob([new Uint8Array(blob)]);
-        },
-        arrayBuffer: async () => {
-            if (!existsSync(filePath)) {
-                throw new Error("electronFile does not exist");
-            }
-            const blob = await fs.readFile(filePath);
-            return new Uint8Array(blob);
-        },
-    };
-}
-
-export const getZipFileStream = async (
-    zip: StreamZip.StreamZipAsync,
-    filePath: string,
-) => {
-    const stream = await zip.stream(filePath);
-    const done = {
-        current: false,
-    };
-    const inProgress = {
-        current: false,
-    };
-    // eslint-disable-next-line no-unused-vars
-    let resolveObj: (value?: any) => void = null;
-    // eslint-disable-next-line no-unused-vars
-    let rejectObj: (reason?: any) => void = null;
-    stream.on("readable", () => {
-        try {
-            if (resolveObj) {
-                inProgress.current = true;
-                const chunk = stream.read(FILE_STREAM_CHUNK_SIZE) as Buffer;
-                if (chunk) {
-                    resolveObj(new Uint8Array(chunk));
-                    resolveObj = null;
-                }
-                inProgress.current = false;
-            }
-        } catch (e) {
-            rejectObj(e);
-        }
-    });
-    stream.on("end", () => {
-        try {
-            done.current = true;
-            if (resolveObj && !inProgress.current) {
-                resolveObj(null);
-                resolveObj = null;
-            }
-        } catch (e) {
-            rejectObj(e);
-        }
-    });
-    stream.on("error", (e) => {
-        try {
-            done.current = true;
-            if (rejectObj) {
-                rejectObj(e);
-                rejectObj = null;
-            }
-        } catch (e) {
-            rejectObj(e);
-        }
-    });
-
-    const readStreamData = async () => {
-        return new Promise<Uint8Array>((resolve, reject) => {
-            const chunk = stream.read(FILE_STREAM_CHUNK_SIZE) as Buffer;
-
-            if (chunk || done.current) {
-                resolve(chunk);
-            } else {
-                resolveObj = resolve;
-                rejectObj = reject;
-            }
-        });
-    };
-
-    const readableStream = new ReadableStream<Uint8Array>({
-        async pull(controller) {
-            try {
-                const data = await readStreamData();
-
-                if (data) {
-                    controller.enqueue(data);
-                } else {
-                    controller.close();
-                }
-            } catch (e) {
-                log.error("Failed to pull from readableStream", e);
-                controller.close();
-            }
-        },
-    });
-    return readableStream;
-};
diff --git a/desktop/src/main/services/image.ts b/desktop/src/main/services/image.ts
index c48e87c5bf..273607c4bc 100644
--- a/desktop/src/main/services/image.ts
+++ b/desktop/src/main/services/image.ts
@@ -1,7 +1,7 @@
 /** @file Image format conversions and thumbnail generation */
 
 import fs from "node:fs/promises";
-import path from "path";
+import path from "node:path";
 import { CustomErrorMessage, type ZipItem } from "../../types/ipc";
 import log from "../log";
 import { execAsync, isDev } from "../utils-electron";
diff --git a/desktop/src/main/services/upload.ts b/desktop/src/main/services/upload.ts
index 9b24cc0ead..a1103a748b 100644
--- a/desktop/src/main/services/upload.ts
+++ b/desktop/src/main/services/upload.ts
@@ -1,10 +1,9 @@
 import StreamZip from "node-stream-zip";
 import fs from "node:fs/promises";
+import path from "node:path";
 import { existsSync } from "original-fs";
-import path from "path";
-import type { ElectronFile, PendingUploads, ZipItem } from "../../types/ipc";
+import type { PendingUploads, ZipItem } from "../../types/ipc";
 import { uploadStatusStore } from "../stores/upload-status";
-import { getZipFileStream } from "./fs";
 
 export const listZipItems = async (zipPath: string): Promise<ZipItem[]> => {
     const zip = new StreamZip.async({ file: zipPath });
@@ -99,51 +98,3 @@ export const markUploadedZipItems = async (
 };
 
 export const clearPendingUploads = () => uploadStatusStore.clear();
-
-export const getElectronFilesFromGoogleZip = async (filePath: string) => {
-    const zip = new StreamZip.async({
-        file: filePath,
-    });
-    const zipName = path.basename(filePath, ".zip");
-
-    const entries = await zip.entries();
-    const files: ElectronFile[] = [];
-
-    for (const entry of Object.values(entries)) {
-        const basename = path.basename(entry.name);
-        if (entry.isFile && basename.length > 0 && basename[0] !== ".") {
-            files.push(await getZipEntryAsElectronFile(zipName, zip, entry));
-        }
-    }
-
-    zip.close();
-
-    return files;
-};
-
-export async function getZipEntryAsElectronFile(
-    zipName: string,
-    zip: StreamZip.StreamZipAsync,
-    entry: StreamZip.ZipEntry,
-): Promise<ElectronFile> {
-    return {
-        path: path
-            .join(zipName, entry.name)
-            .split(path.sep)
-            .join(path.posix.sep),
-        name: path.basename(entry.name),
-        size: entry.size,
-        lastModified: entry.time,
-        stream: async () => {
-            return await getZipFileStream(zip, entry.name);
-        },
-        blob: async () => {
-            const buffer = await zip.entryData(entry.name);
-            return new Blob([new Uint8Array(buffer)]);
-        },
-        arrayBuffer: async () => {
-            const buffer = await zip.entryData(entry.name);
-            return new Uint8Array(buffer);
-        },
-    };
-}
diff --git a/desktop/src/main/services/watch.ts b/desktop/src/main/services/watch.ts
index 73a13c5455..85463ae49e 100644
--- a/desktop/src/main/services/watch.ts
+++ b/desktop/src/main/services/watch.ts
@@ -6,6 +6,7 @@ import { FolderWatch, type CollectionMapping } from "../../types/ipc";
 import { fsIsDir } from "../fs";
 import log from "../log";
 import { watchStore } from "../stores/watch";
+import { posixPath } from "../utils-path";
 
 /**
  * Create and return a new file system watcher.
@@ -46,13 +47,6 @@ const eventData = (path: string): [string, FolderWatch] => {
     return [path, watch];
 };
 
-/**
- * Convert a file system {@link filePath} that uses the local system specific
- * path separators into a path that uses POSIX file separators.
- */
-const posixPath = (filePath: string) =>
-    filePath.split(path.sep).join(path.posix.sep);
-
 export const watchGet = (watcher: FSWatcher) => {
     const [valid, deleted] = folderWatches().reduce(
         ([valid, deleted], watch) => {
diff --git a/desktop/src/main/utils-path.ts b/desktop/src/main/utils-path.ts
new file mode 100644
index 0000000000..b5e358e03b
--- /dev/null
+++ b/desktop/src/main/utils-path.ts
@@ -0,0 +1,8 @@
+import path from "node:path";
+
+/**
+ * Convert a file system {@link filePath} that uses the local system specific
+ * path separators into a path that uses POSIX file separators.
+ */
+export const posixPath = (filePath: string) =>
+    filePath.split(path.sep).join(path.posix.sep);
diff --git a/desktop/src/main/utils-temp.ts b/desktop/src/main/utils-temp.ts
index 3f3a6081e4..5928931f2e 100644
--- a/desktop/src/main/utils-temp.ts
+++ b/desktop/src/main/utils-temp.ts
@@ -2,7 +2,7 @@ import { app } from "electron/main";
 import StreamZip from "node-stream-zip";
 import { existsSync } from "node:fs";
 import fs from "node:fs/promises";
-import path from "path";
+import path from "node:path";
 import type { ZipItem } from "../types/ipc";
 
 /**
diff --git a/desktop/src/preload.ts b/desktop/src/preload.ts
index 61955b5240..52fe068e47 100644
--- a/desktop/src/preload.ts
+++ b/desktop/src/preload.ts
@@ -63,6 +63,9 @@ const openDirectory = (dirPath: string): Promise<void> =>
 const openLogDirectory = (): Promise<void> =>
     ipcRenderer.invoke("openLogDirectory");
 
+const selectDirectory = (): Promise<string | undefined> =>
+    ipcRenderer.invoke("selectDirectory");
+
 const clearStores = () => ipcRenderer.send("clearStores");
 
 const encryptionKey = (): Promise<string | undefined> =>
@@ -174,9 +177,6 @@ const faceEmbedding = (input: Float32Array): Promise<Float32Array> =>
 
 // TODO: Deprecated - use dialogs on the renderer process itself
 
-const selectDirectory = (): Promise<string> =>
-    ipcRenderer.invoke("selectDirectory");
-
 const showUploadFilesDialog = (): Promise<ElectronFile[]> =>
     ipcRenderer.invoke("showUploadFilesDialog");
 
@@ -310,6 +310,7 @@ contextBridge.exposeInMainWorld("electron", {
     logToDisk,
     openDirectory,
     openLogDirectory,
+    selectDirectory,
     clearStores,
     encryptionKey,
     saveEncryptionKey,
@@ -348,13 +349,6 @@ contextBridge.exposeInMainWorld("electron", {
     detectFaces,
     faceEmbedding,
 
-    // - File selection
-
-    selectDirectory,
-    showUploadFilesDialog,
-    showUploadDirsDialog,
-    showUploadZipDialog,
-
     // - Watch
 
     watch: {
diff --git a/web/packages/next/types/ipc.ts b/web/packages/next/types/ipc.ts
index 173b12b17c..d97a7e5643 100644
--- a/web/packages/next/types/ipc.ts
+++ b/web/packages/next/types/ipc.ts
@@ -3,8 +3,6 @@
 //
 // See [Note: types.ts <-> preload.ts <-> ipc.ts]
 
-import type { ElectronFile } from "./file";
-
 /**
  * Extra APIs provided by our Node.js layer when our code is running inside our
  * desktop (Electron) app.
@@ -51,6 +49,18 @@ export interface Electron {
      */
     openLogDirectory: () => Promise<void>;
 
+    /**
+     * Ask the user to select a directory on their local file system, and return
+     * it path.
+     *
+     * We don't strictly need IPC for this, we can use a hidden <input> element
+     * and trigger its click for the same behaviour (as we do for the
+     * `useFileInput` hook that we use for uploads). However, it's a bit
+     * cumbersome, and we anyways will need to IPC to get back its full path, so
+     * it is just convenient to expose this direct method.
+     */
+    selectDirectory: () => Promise<string | undefined>;
+
     /**
      * Clear any stored data.
      *
@@ -122,6 +132,8 @@ export interface Electron {
      */
     skipAppUpdate: (version: string) => void;
 
+    // - FS
+
     /**
      * A subset of file system access APIs.
      *
@@ -332,20 +344,6 @@ export interface Electron {
      */
     faceEmbedding: (input: Float32Array) => Promise<Float32Array>;
 
-    // - File selection
-    // TODO: Deprecated - use dialogs on the renderer process itself
-
-    selectDirectory: () => Promise<string>;
-
-    showUploadFilesDialog: () => Promise<ElectronFile[]>;
-
-    showUploadDirsDialog: () => Promise<ElectronFile[]>;
-
-    showUploadZipDialog: () => Promise<{
-        zipPaths: string[];
-        files: ElectronFile[];
-    }>;
-
     // - Watch
 
     /**
diff --git a/web/packages/shared/hooks/useFileInput.tsx b/web/packages/shared/hooks/useFileInput.tsx
index 158a71b44e..ae1dfcab0a 100644
--- a/web/packages/shared/hooks/useFileInput.tsx
+++ b/web/packages/shared/hooks/useFileInput.tsx
@@ -1,28 +1,5 @@
 import { useCallback, useRef, useState } from "react";
 
-/**
- * [Note: File paths when running under Electron]
- *
- * We have access to the absolute path of the web {@link File} object when we
- * are running in the context of our desktop app.
- *
- * https://www.electronjs.org/docs/latest/api/file-object
- *
- * This is in contrast to the `webkitRelativePath` that we get when we're
- * running in the browser, which is the relative path to the directory that the
- * user selected (or just the name of the file if the user selected or
- * drag/dropped a single one).
- *
- * Note that this is a deprecated approach. From Electron docs:
- *
- * > Warning: The path property that Electron adds to the File interface is
- * > deprecated and will be removed in a future Electron release. We recommend
- * > you use `webUtils.getPathForFile` instead.
- */
-export interface FileWithPath extends File {
-    readonly path?: string;
-}
-
 interface UseFileInputParams {
     directory?: boolean;
     accept?: string;

From d6aeef85d6892a3d9775cc0783c68636ca626695 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 13:33:18 +0530
Subject: [PATCH 03/41] Rearrange

---
 desktop/src/main.ts                           |  2 +-
 desktop/src/main/ipc.ts                       | 25 +++++-----
 desktop/src/main/log.ts                       |  2 +-
 desktop/src/main/menu.ts                      |  2 +-
 desktop/src/main/services/dialog.ts           | 10 ----
 desktop/src/main/services/dir.ts              | 48 +++++++++++++++++++
 desktop/src/main/services/ffmpeg.ts           |  4 +-
 desktop/src/main/{ => services}/fs.ts         |  0
 desktop/src/main/services/image.ts            |  4 +-
 desktop/src/main/services/ml-clip.ts          |  2 +-
 desktop/src/main/services/watch.ts            |  4 +-
 .../{utils-electron.ts => utils/electron.ts}  | 40 +---------------
 desktop/src/main/{utils.ts => utils/index.ts} |  0
 .../src/main/{utils-path.ts => utils/path.ts} |  0
 .../src/main/{utils-temp.ts => utils/temp.ts} |  2 +-
 15 files changed, 74 insertions(+), 71 deletions(-)
 delete mode 100644 desktop/src/main/services/dialog.ts
 create mode 100644 desktop/src/main/services/dir.ts
 rename desktop/src/main/{ => services}/fs.ts (100%)
 rename desktop/src/main/{utils-electron.ts => utils/electron.ts} (53%)
 rename desktop/src/main/{utils.ts => utils/index.ts} (100%)
 rename desktop/src/main/{utils-path.ts => utils/path.ts} (100%)
 rename desktop/src/main/{utils-temp.ts => utils/temp.ts} (98%)

diff --git a/desktop/src/main.ts b/desktop/src/main.ts
index 2774ec730c..4b6db7eac9 100644
--- a/desktop/src/main.ts
+++ b/desktop/src/main.ts
@@ -26,7 +26,7 @@ import { createWatcher } from "./main/services/watch";
 import { userPreferences } from "./main/stores/user-preferences";
 import { migrateLegacyWatchStoreIfNeeded } from "./main/stores/watch";
 import { registerStreamProtocol } from "./main/stream";
-import { isDev } from "./main/utils-electron";
+import { isDev } from "./main/utils/electron";
 
 /**
  * The URL where the renderer HTML is being served from.
diff --git a/desktop/src/main/ipc.ts b/desktop/src/main/ipc.ts
index bb5daeabac..eb8b6cdda8 100644
--- a/desktop/src/main/ipc.ts
+++ b/desktop/src/main/ipc.ts
@@ -16,6 +16,19 @@ import type {
     PendingUploads,
     ZipItem,
 } from "../types/ipc";
+import { logToDisk } from "./log";
+import {
+    appVersion,
+    skipAppUpdate,
+    updateAndRestart,
+    updateOnNextRestart,
+} from "./services/app-update";
+import {
+    openDirectory,
+    openLogDirectory,
+    selectDirectory,
+} from "./services/dir";
+import { ffmpegExec } from "./services/ffmpeg";
 import {
     fsExists,
     fsIsDir,
@@ -25,16 +38,7 @@ import {
     fsRm,
     fsRmdir,
     fsWriteFile,
-} from "./fs";
-import { logToDisk } from "./log";
-import {
-    appVersion,
-    skipAppUpdate,
-    updateAndRestart,
-    updateOnNextRestart,
-} from "./services/app-update";
-import { selectDirectory } from "./services/dialog";
-import { ffmpegExec } from "./services/ffmpeg";
+} from "./services/fs";
 import { convertToJPEG, generateImageThumbnail } from "./services/image";
 import {
     clipImageEmbedding,
@@ -63,7 +67,6 @@ import {
     watchUpdateIgnoredFiles,
     watchUpdateSyncedFiles,
 } from "./services/watch";
-import { openDirectory, openLogDirectory } from "./utils-electron";
 
 /**
  * Listen for IPC events sent/invoked by the renderer process, and route them to
diff --git a/desktop/src/main/log.ts b/desktop/src/main/log.ts
index 22ebb5300a..7fc25a94b0 100644
--- a/desktop/src/main/log.ts
+++ b/desktop/src/main/log.ts
@@ -1,6 +1,6 @@
 import log from "electron-log";
 import util from "node:util";
-import { isDev } from "./utils-electron";
+import { isDev } from "./utils/electron";
 
 /**
  * Initialize logging in the main process.
diff --git a/desktop/src/main/menu.ts b/desktop/src/main/menu.ts
index 12b1ee17d3..990dd40e5d 100644
--- a/desktop/src/main/menu.ts
+++ b/desktop/src/main/menu.ts
@@ -9,7 +9,7 @@ import { allowWindowClose } from "../main";
 import { forceCheckForAppUpdates } from "./services/app-update";
 import autoLauncher from "./services/auto-launcher";
 import { userPreferences } from "./stores/user-preferences";
-import { isDev, openLogDirectory } from "./utils-electron";
+import { isDev, openLogDirectory } from "./utils/electron";
 
 /** Create and return the entries in the app's main menu bar */
 export const createApplicationMenu = async (mainWindow: BrowserWindow) => {
diff --git a/desktop/src/main/services/dialog.ts b/desktop/src/main/services/dialog.ts
deleted file mode 100644
index e98a6a9dd6..0000000000
--- a/desktop/src/main/services/dialog.ts
+++ /dev/null
@@ -1,10 +0,0 @@
-import { dialog } from "electron/main";
-import { posixPath } from "../utils-path";
-
-export const selectDirectory = async () => {
-    const result = await dialog.showOpenDialog({
-        properties: ["openDirectory"],
-    });
-    const dirPath = result.filePaths[0];
-    return dirPath ? posixPath(dirPath) : undefined;
-};
diff --git a/desktop/src/main/services/dir.ts b/desktop/src/main/services/dir.ts
new file mode 100644
index 0000000000..a6917fe27c
--- /dev/null
+++ b/desktop/src/main/services/dir.ts
@@ -0,0 +1,48 @@
+import { shell } from "electron/common";
+import { app, dialog } from "electron/main";
+import path from "node:path";
+import { posixPath } from "../utils/path";
+
+export const selectDirectory = async () => {
+    const result = await dialog.showOpenDialog({
+        properties: ["openDirectory"],
+    });
+    const dirPath = result.filePaths[0];
+    return dirPath ? posixPath(dirPath) : undefined;
+};
+
+/**
+ * Open the given {@link dirPath} in the system's folder viewer.
+ *
+ * For example, on macOS this'll open {@link dirPath} in Finder.
+ */
+export const openDirectory = async (dirPath: string) => {
+    const res = await shell.openPath(path.normalize(dirPath));
+    // shell.openPath resolves with a string containing the error message
+    // corresponding to the failure if a failure occurred, otherwise "".
+    if (res) throw new Error(`Failed to open directory ${dirPath}: res`);
+};
+
+/**
+ * Open the app's log directory in the system's folder viewer.
+ *
+ * @see {@link openDirectory}
+ */
+export const openLogDirectory = () => openDirectory(logDirectoryPath());
+
+/**
+ * Return the path where the logs for the app are saved.
+ *
+ * [Note: Electron app paths]
+ *
+ * By default, these paths are at the following locations:
+ *
+ * - macOS: `~/Library/Application Support/ente`
+ * - Linux: `~/.config/ente`
+ * - Windows: `%APPDATA%`, e.g. `C:\Users\<username>\AppData\Local\ente`
+ * - Windows: C:\Users\<you>\AppData\Local\<Your App Name>
+ *
+ * https://www.electronjs.org/docs/latest/api/app
+ *
+ */
+const logDirectoryPath = () => app.getPath("logs");
diff --git a/desktop/src/main/services/ffmpeg.ts b/desktop/src/main/services/ffmpeg.ts
index 35977409ae..78b7a9e9a3 100644
--- a/desktop/src/main/services/ffmpeg.ts
+++ b/desktop/src/main/services/ffmpeg.ts
@@ -3,12 +3,12 @@ import fs from "node:fs/promises";
 import type { ZipItem } from "../../types/ipc";
 import log from "../log";
 import { withTimeout } from "../utils";
-import { execAsync } from "../utils-electron";
+import { execAsync } from "../utils/electron";
 import {
     deleteTempFile,
     makeFileForDataOrPathOrZipItem,
     makeTempFilePath,
-} from "../utils-temp";
+} from "../utils/temp";
 
 /* Duplicated in the web app's code (used by the WASM FFmpeg implementation). */
 const ffmpegPathPlaceholder = "FFMPEG";
diff --git a/desktop/src/main/fs.ts b/desktop/src/main/services/fs.ts
similarity index 100%
rename from desktop/src/main/fs.ts
rename to desktop/src/main/services/fs.ts
diff --git a/desktop/src/main/services/image.ts b/desktop/src/main/services/image.ts
index 273607c4bc..957fe81200 100644
--- a/desktop/src/main/services/image.ts
+++ b/desktop/src/main/services/image.ts
@@ -4,12 +4,12 @@ import fs from "node:fs/promises";
 import path from "node:path";
 import { CustomErrorMessage, type ZipItem } from "../../types/ipc";
 import log from "../log";
-import { execAsync, isDev } from "../utils-electron";
+import { execAsync, isDev } from "../utils/electron";
 import {
     deleteTempFile,
     makeFileForDataOrPathOrZipItem,
     makeTempFilePath,
-} from "../utils-temp";
+} from "../utils/temp";
 
 export const convertToJPEG = async (imageData: Uint8Array) => {
     const inputFilePath = await makeTempFilePath();
diff --git a/desktop/src/main/services/ml-clip.ts b/desktop/src/main/services/ml-clip.ts
index cdd2baab76..99e512aa61 100644
--- a/desktop/src/main/services/ml-clip.ts
+++ b/desktop/src/main/services/ml-clip.ts
@@ -11,7 +11,7 @@ import * as ort from "onnxruntime-node";
 import Tokenizer from "../../thirdparty/clip-bpe-ts/mod";
 import log from "../log";
 import { writeStream } from "../stream";
-import { deleteTempFile, makeTempFilePath } from "../utils-temp";
+import { deleteTempFile, makeTempFilePath } from "../utils/temp";
 import { makeCachedInferenceSession } from "./ml";
 
 const cachedCLIPImageSession = makeCachedInferenceSession(
diff --git a/desktop/src/main/services/watch.ts b/desktop/src/main/services/watch.ts
index 85463ae49e..5e57df3e5e 100644
--- a/desktop/src/main/services/watch.ts
+++ b/desktop/src/main/services/watch.ts
@@ -3,10 +3,10 @@ import { BrowserWindow } from "electron/main";
 import fs from "node:fs/promises";
 import path from "node:path";
 import { FolderWatch, type CollectionMapping } from "../../types/ipc";
-import { fsIsDir } from "../fs";
 import log from "../log";
 import { watchStore } from "../stores/watch";
-import { posixPath } from "../utils-path";
+import { posixPath } from "../utils/path";
+import { fsIsDir } from "./fs";
 
 /**
  * Create and return a new file system watcher.
diff --git a/desktop/src/main/utils-electron.ts b/desktop/src/main/utils/electron.ts
similarity index 53%
rename from desktop/src/main/utils-electron.ts
rename to desktop/src/main/utils/electron.ts
index e8a98f1dfe..97d05ea6d0 100644
--- a/desktop/src/main/utils-electron.ts
+++ b/desktop/src/main/utils/electron.ts
@@ -1,10 +1,8 @@
 import shellescape from "any-shell-escape";
-import { shell } from "electron"; /* TODO(MR): Why is this not in /main? */
 import { app } from "electron/main";
 import { exec } from "node:child_process";
-import path from "node:path";
 import { promisify } from "node:util";
-import log from "./log";
+import log from "../log";
 
 /** `true` if the app is running in development mode. */
 export const isDev = !app.isPackaged;
@@ -41,39 +39,3 @@ export const execAsync = (command: string | string[]) => {
 };
 
 const execAsync_ = promisify(exec);
-
-/**
- * Open the given {@link dirPath} in the system's folder viewer.
- *
- * For example, on macOS this'll open {@link dirPath} in Finder.
- */
-export const openDirectory = async (dirPath: string) => {
-    const res = await shell.openPath(path.normalize(dirPath));
-    // shell.openPath resolves with a string containing the error message
-    // corresponding to the failure if a failure occurred, otherwise "".
-    if (res) throw new Error(`Failed to open directory ${dirPath}: res`);
-};
-
-/**
- * Open the app's log directory in the system's folder viewer.
- *
- * @see {@link openDirectory}
- */
-export const openLogDirectory = () => openDirectory(logDirectoryPath());
-
-/**
- * Return the path where the logs for the app are saved.
- *
- * [Note: Electron app paths]
- *
- * By default, these paths are at the following locations:
- *
- * - macOS: `~/Library/Application Support/ente`
- * - Linux: `~/.config/ente`
- * - Windows: `%APPDATA%`, e.g. `C:\Users\<username>\AppData\Local\ente`
- * - Windows: C:\Users\<you>\AppData\Local\<Your App Name>
- *
- * https://www.electronjs.org/docs/latest/api/app
- *
- */
-const logDirectoryPath = () => app.getPath("logs");
diff --git a/desktop/src/main/utils.ts b/desktop/src/main/utils/index.ts
similarity index 100%
rename from desktop/src/main/utils.ts
rename to desktop/src/main/utils/index.ts
diff --git a/desktop/src/main/utils-path.ts b/desktop/src/main/utils/path.ts
similarity index 100%
rename from desktop/src/main/utils-path.ts
rename to desktop/src/main/utils/path.ts
diff --git a/desktop/src/main/utils-temp.ts b/desktop/src/main/utils/temp.ts
similarity index 98%
rename from desktop/src/main/utils-temp.ts
rename to desktop/src/main/utils/temp.ts
index 5928931f2e..28aea245d8 100644
--- a/desktop/src/main/utils-temp.ts
+++ b/desktop/src/main/utils/temp.ts
@@ -3,7 +3,7 @@ import StreamZip from "node-stream-zip";
 import { existsSync } from "node:fs";
 import fs from "node:fs/promises";
 import path from "node:path";
-import type { ZipItem } from "../types/ipc";
+import type { ZipItem } from "../../types/ipc";
 
 /**
  * Our very own directory within the system temp directory. Go crazy, but

From 6c4adb112702e0fdbf6a0e33b85ea4a4fe0a9aa1 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 13:37:17 +0530
Subject: [PATCH 04/41] Housekeeping

---
 desktop/src/main.ts                |  6 ------
 desktop/src/main/init.ts           | 21 ---------------------
 desktop/src/main/services/dir.ts   |  2 +-
 desktop/src/main/services/watch.ts |  2 +-
 desktop/src/main/utils/electron.ts |  8 ++++++++
 desktop/src/main/utils/index.ts    |  2 +-
 desktop/src/main/utils/path.ts     |  8 --------
 7 files changed, 11 insertions(+), 38 deletions(-)
 delete mode 100644 desktop/src/main/init.ts
 delete mode 100644 desktop/src/main/utils/path.ts

diff --git a/desktop/src/main.ts b/desktop/src/main.ts
index 4b6db7eac9..9fb9706047 100644
--- a/desktop/src/main.ts
+++ b/desktop/src/main.ts
@@ -401,12 +401,6 @@ const main = () => {
         setDownloadPath(mainWindow.webContents);
         allowExternalLinks(mainWindow.webContents);
 
-        // TODO(MR): Remove or resurrect
-        // The commit that introduced this header override had the message
-        // "fix cors issue for uploads". Not sure what that means, so disabling
-        // it for now to see why exactly this is required.
-        // addAllowOriginHeader(mainWindow);
-
         // Start loading the renderer.
         mainWindow.loadURL(rendererURL);
 
diff --git a/desktop/src/main/init.ts b/desktop/src/main/init.ts
deleted file mode 100644
index d0aee17f8f..0000000000
--- a/desktop/src/main/init.ts
+++ /dev/null
@@ -1,21 +0,0 @@
-import { BrowserWindow } from "electron";
-
-export function addAllowOriginHeader(mainWindow: BrowserWindow) {
-    mainWindow.webContents.session.webRequest.onHeadersReceived(
-        (details, callback) => {
-            details.responseHeaders = lowerCaseHeaders(details.responseHeaders);
-            details.responseHeaders["access-control-allow-origin"] = ["*"];
-            callback({
-                responseHeaders: details.responseHeaders,
-            });
-        },
-    );
-}
-
-function lowerCaseHeaders(responseHeaders: Record<string, string[]>) {
-    const headers: Record<string, string[]> = {};
-    for (const key of Object.keys(responseHeaders)) {
-        headers[key.toLowerCase()] = responseHeaders[key];
-    }
-    return headers;
-}
diff --git a/desktop/src/main/services/dir.ts b/desktop/src/main/services/dir.ts
index a6917fe27c..4e2a8c65e4 100644
--- a/desktop/src/main/services/dir.ts
+++ b/desktop/src/main/services/dir.ts
@@ -1,7 +1,7 @@
 import { shell } from "electron/common";
 import { app, dialog } from "electron/main";
 import path from "node:path";
-import { posixPath } from "../utils/path";
+import { posixPath } from "../utils/electron";
 
 export const selectDirectory = async () => {
     const result = await dialog.showOpenDialog({
diff --git a/desktop/src/main/services/watch.ts b/desktop/src/main/services/watch.ts
index 5e57df3e5e..588279b70a 100644
--- a/desktop/src/main/services/watch.ts
+++ b/desktop/src/main/services/watch.ts
@@ -5,7 +5,7 @@ import path from "node:path";
 import { FolderWatch, type CollectionMapping } from "../../types/ipc";
 import log from "../log";
 import { watchStore } from "../stores/watch";
-import { posixPath } from "../utils/path";
+import { posixPath } from "../utils/electron";
 import { fsIsDir } from "./fs";
 
 /**
diff --git a/desktop/src/main/utils/electron.ts b/desktop/src/main/utils/electron.ts
index 97d05ea6d0..d627ec5c46 100644
--- a/desktop/src/main/utils/electron.ts
+++ b/desktop/src/main/utils/electron.ts
@@ -1,12 +1,20 @@
 import shellescape from "any-shell-escape";
 import { app } from "electron/main";
 import { exec } from "node:child_process";
+import path from "node:path";
 import { promisify } from "node:util";
 import log from "../log";
 
 /** `true` if the app is running in development mode. */
 export const isDev = !app.isPackaged;
 
+/**
+ * Convert a file system {@link filePath} that uses the local system specific
+ * path separators into a path that uses POSIX file separators.
+ */
+export const posixPath = (filePath: string) =>
+    filePath.split(path.sep).join(path.posix.sep);
+
 /**
  * Run a shell command asynchronously.
  *
diff --git a/desktop/src/main/utils/index.ts b/desktop/src/main/utils/index.ts
index 132859a436..1ae35d55d3 100644
--- a/desktop/src/main/utils/index.ts
+++ b/desktop/src/main/utils/index.ts
@@ -1,5 +1,5 @@
 /**
- * @file grab bag of utitity functions.
+ * @file grab bag of utility functions.
  *
  * Many of these are verbatim copies of functions from web code since there
  * isn't currently a common package that both of them share.
diff --git a/desktop/src/main/utils/path.ts b/desktop/src/main/utils/path.ts
deleted file mode 100644
index b5e358e03b..0000000000
--- a/desktop/src/main/utils/path.ts
+++ /dev/null
@@ -1,8 +0,0 @@
-import path from "node:path";
-
-/**
- * Convert a file system {@link filePath} that uses the local system specific
- * path separators into a path that uses POSIX file separators.
- */
-export const posixPath = (filePath: string) =>
-    filePath.split(path.sep).join(path.posix.sep);

From b52c9f558fd686ea7521f34e984d2e9e9cc20e4a Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 13:39:58 +0530
Subject: [PATCH 05/41] Remove cache size overrides

Need a bit more benchmarking or real world feedback to see if this is even something that is helping us.
---
 desktop/src/main.ts             | 27 ---------------------------
 web/packages/next/blob-cache.ts |  2 --
 2 files changed, 29 deletions(-)

diff --git a/desktop/src/main.ts b/desktop/src/main.ts
index 9fb9706047..6f8881dd6e 100644
--- a/desktop/src/main.ts
+++ b/desktop/src/main.ts
@@ -141,30 +141,6 @@ const registerPrivilegedSchemes = () => {
     ]);
 };
 
-/**
- * [Note: Increased disk cache for the desktop app]
- *
- * Set the "disk-cache-size" command line flag to ask the Chromium process to
- * use a larger size for the caches that it keeps on disk. This allows us to use
- * the web based caching mechanisms on both the web and the desktop app, just
- * ask the embedded Chromium to be a bit more generous in disk usage when
- * running as the desktop app.
- *
- * The size we provide is in bytes.
- * https://www.electronjs.org/docs/latest/api/command-line-switches#--disk-cache-sizesize
- *
- * Note that increasing the disk cache size does not guarantee that Chromium
- * will respect in verbatim, it uses its own heuristics atop this hint.
- * https://superuser.com/questions/378991/what-is-chrome-default-cache-size-limit/1577693#1577693
- *
- * See also: [Note: Caching files].
- */
-const increaseDiskCache = () =>
-    app.commandLine.appendSwitch(
-        "disk-cache-size",
-        `${5 * 1024 * 1024 * 1024}`, // 5 GB
-    );
-
 /**
  * Create an return the {@link BrowserWindow} that will form our app's UI.
  *
@@ -321,8 +297,6 @@ const setupTrayItem = (mainWindow: BrowserWindow) => {
  * Older versions of our app used to maintain a cache dir using the main
  * process. This has been deprecated in favor of using a normal web cache.
  *
- * See [Note: Increased disk cache for the desktop app]
- *
  * Delete the old cache dir if it exists. This code was added March 2024, and
  * can be removed after some time once most people have upgraded to newer
  * versions.
@@ -375,7 +349,6 @@ const main = () => {
     // The order of the next two calls is important
     setupRendererServer();
     registerPrivilegedSchemes();
-    increaseDiskCache();
     migrateLegacyWatchStoreIfNeeded();
 
     app.on("second-instance", () => {
diff --git a/web/packages/next/blob-cache.ts b/web/packages/next/blob-cache.ts
index 0e092fed61..e6c3734df2 100644
--- a/web/packages/next/blob-cache.ts
+++ b/web/packages/next/blob-cache.ts
@@ -50,8 +50,6 @@ export type BlobCacheNamespace = (typeof blobCacheNames)[number];
  * ([the WebKit bug](https://bugs.webkit.org/show_bug.cgi?id=231706)), so it's
  * not trivial to use this as a full on replacement of the Web Cache in the
  * browser. So for now we go with this split implementation.
- *
- * See also: [Note: Increased disk cache for the desktop app].
  */
 export interface BlobCache {
     /**

From 4feefb9b8d497fa4a9072b4eec40950ed9776ca7 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 13:41:18 +0530
Subject: [PATCH 06/41] Fix comment

---
 desktop/src/main/log.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/desktop/src/main/log.ts b/desktop/src/main/log.ts
index 7fc25a94b0..d2421da62e 100644
--- a/desktop/src/main/log.ts
+++ b/desktop/src/main/log.ts
@@ -7,9 +7,9 @@ import { isDev } from "./utils/electron";
  *
  * This will set our underlying logger up to log to a file named `ente.log`,
  *
- * - on Linux at ~/.config/ente/logs/main.log
- * - on macOS at ~/Library/Logs/ente/main.log
- * - on Windows at %USERPROFILE%\AppData\Roaming\ente\logs\main.log
+ * - on Linux at ~/.config/ente/logs/ente.log
+ * - on macOS at ~/Library/Logs/ente/ente.log
+ * - on Windows at %USERPROFILE%\AppData\Roaming\ente\logs\ente.log
  *
  * On dev builds, it will also log to the console.
  */

From 8400620488f47e4826877030b3979e94bc66e233 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 13:42:41 +0530
Subject: [PATCH 07/41] Gone from desktop

---
 desktop/src/preload.ts   | 16 ----------------
 desktop/src/types/ipc.ts | 22 ----------------------
 2 files changed, 38 deletions(-)

diff --git a/desktop/src/preload.ts b/desktop/src/preload.ts
index 52fe068e47..ecc800db3c 100644
--- a/desktop/src/preload.ts
+++ b/desktop/src/preload.ts
@@ -44,7 +44,6 @@ import { contextBridge, ipcRenderer, webUtils } from "electron/renderer";
 import type {
     AppUpdate,
     CollectionMapping,
-    ElectronFile,
     FolderWatch,
     PendingUploads,
     ZipItem,
@@ -173,21 +172,6 @@ const detectFaces = (input: Float32Array): Promise<Float32Array> =>
 const faceEmbedding = (input: Float32Array): Promise<Float32Array> =>
     ipcRenderer.invoke("faceEmbedding", input);
 
-// - File selection
-
-// TODO: Deprecated - use dialogs on the renderer process itself
-
-const showUploadFilesDialog = (): Promise<ElectronFile[]> =>
-    ipcRenderer.invoke("showUploadFilesDialog");
-
-const showUploadDirsDialog = (): Promise<ElectronFile[]> =>
-    ipcRenderer.invoke("showUploadDirsDialog");
-
-const showUploadZipDialog = (): Promise<{
-    zipPaths: string[];
-    files: ElectronFile[];
-}> => ipcRenderer.invoke("showUploadZipDialog");
-
 // - Watch
 
 const watchGet = (): Promise<FolderWatch[]> => ipcRenderer.invoke("watchGet");
diff --git a/desktop/src/types/ipc.ts b/desktop/src/types/ipc.ts
index 6e47b7a3a6..c02ed17260 100644
--- a/desktop/src/types/ipc.ts
+++ b/desktop/src/types/ipc.ts
@@ -42,25 +42,3 @@ export interface PendingUploads {
 export const CustomErrorMessage = {
     NotAvailable: "This feature in not available on the current OS/arch",
 };
-
-/**
- * Deprecated - Use File + webUtils.getPathForFile instead
- *
- * Electron used to augment the standard web
- * [File](https://developer.mozilla.org/en-US/docs/Web/API/File) object with an
- * additional `path` property. This is now deprecated, and will be removed in a
- * future release.
- * https://www.electronjs.org/docs/latest/api/file-object
- *
- * The alternative to the `path` property is to use `webUtils.getPathForFile`
- * https://www.electronjs.org/docs/latest/api/web-utils
- */
-export interface ElectronFile {
-    name: string;
-    path: string;
-    size: number;
-    lastModified: number;
-    stream: () => Promise<ReadableStream<Uint8Array>>;
-    blob: () => Promise<Blob>;
-    arrayBuffer: () => Promise<Uint8Array>;
-}

From 14348351a97120c7a897639042e0060ce32e8b56 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 13:44:46 +0530
Subject: [PATCH 08/41] Fix call of undefined

---
 desktop/src/main/utils/temp.ts | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/desktop/src/main/utils/temp.ts b/desktop/src/main/utils/temp.ts
index 28aea245d8..09071c1573 100644
--- a/desktop/src/main/utils/temp.ts
+++ b/desktop/src/main/utils/temp.ts
@@ -76,15 +76,14 @@ interface FileForDataOrPathOrZipItem {
      */
     isFileTemporary: boolean;
     /**
-     * If set, this'll be a function that can be called to actually write the
-     * contents of the source `Uint8Array | string | ZipItem` into the file at
-     * {@link path}.
+     * A function that can be called to actually write the contents of the
+     * source `Uint8Array | string | ZipItem` into the file at {@link path}.
      *
-     * It will be undefined if the source is already a path since nothing needs
-     * to be written in that case. In the other two cases this function will
-     * write the data or zip item into the file at {@link path}.
+     * It will do nothing in the case when the source is already a path. In the
+     * other two cases this function will write the data or zip item into the
+     * file at {@link path}.
      */
-    writeToTemporaryFile?: () => Promise<void>;
+    writeToTemporaryFile: () => Promise<void>;
 }
 
 /**
@@ -101,7 +100,7 @@ export const makeFileForDataOrPathOrZipItem = async (
 ): Promise<FileForDataOrPathOrZipItem> => {
     let path: string;
     let isFileTemporary: boolean;
-    let writeToTemporaryFile: () => Promise<void> | undefined;
+    let writeToTemporaryFile = async () => {};
 
     if (typeof dataOrPathOrZipItem == "string") {
         path = dataOrPathOrZipItem;

From 333f9c58f25ec772eba6159666bdbe312454179a Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 13:56:11 +0530
Subject: [PATCH 09/41] strict 1

---
 desktop/src/main.ts                  |  2 +-
 desktop/src/main/log.ts              |  2 +-
 desktop/src/main/menu.ts             |  3 +-
 desktop/src/main/services/dir.ts     |  2 +-
 desktop/src/main/services/ffmpeg.ts  |  4 +-
 desktop/src/main/services/image.ts   |  2 +-
 desktop/src/main/services/ml-clip.ts |  7 ++-
 desktop/src/main/services/watch.ts   |  2 +-
 desktop/src/main/stream.ts           |  5 +-
 desktop/src/main/utils/common.ts     | 35 ++++++++++++++
 desktop/src/main/utils/electron.ts   | 49 -------------------
 desktop/src/main/utils/index.ts      | 70 +++++++++++++++++-----------
 desktop/tsconfig.json                |  6 +--
 13 files changed, 96 insertions(+), 93 deletions(-)
 create mode 100644 desktop/src/main/utils/common.ts
 delete mode 100644 desktop/src/main/utils/electron.ts

diff --git a/desktop/src/main.ts b/desktop/src/main.ts
index 6f8881dd6e..42c5ab7329 100644
--- a/desktop/src/main.ts
+++ b/desktop/src/main.ts
@@ -26,7 +26,7 @@ import { createWatcher } from "./main/services/watch";
 import { userPreferences } from "./main/stores/user-preferences";
 import { migrateLegacyWatchStoreIfNeeded } from "./main/stores/watch";
 import { registerStreamProtocol } from "./main/stream";
-import { isDev } from "./main/utils/electron";
+import { isDev } from "./main/utils";
 
 /**
  * The URL where the renderer HTML is being served from.
diff --git a/desktop/src/main/log.ts b/desktop/src/main/log.ts
index d2421da62e..c1902d8ebd 100644
--- a/desktop/src/main/log.ts
+++ b/desktop/src/main/log.ts
@@ -1,6 +1,6 @@
 import log from "electron-log";
 import util from "node:util";
-import { isDev } from "./utils/electron";
+import { isDev } from "./utils";
 
 /**
  * Initialize logging in the main process.
diff --git a/desktop/src/main/menu.ts b/desktop/src/main/menu.ts
index 990dd40e5d..0693c01dc0 100644
--- a/desktop/src/main/menu.ts
+++ b/desktop/src/main/menu.ts
@@ -8,8 +8,9 @@ import {
 import { allowWindowClose } from "../main";
 import { forceCheckForAppUpdates } from "./services/app-update";
 import autoLauncher from "./services/auto-launcher";
+import { openLogDirectory } from "./services/dir";
 import { userPreferences } from "./stores/user-preferences";
-import { isDev, openLogDirectory } from "./utils/electron";
+import { isDev } from "./utils";
 
 /** Create and return the entries in the app's main menu bar */
 export const createApplicationMenu = async (mainWindow: BrowserWindow) => {
diff --git a/desktop/src/main/services/dir.ts b/desktop/src/main/services/dir.ts
index 4e2a8c65e4..ef3adb013d 100644
--- a/desktop/src/main/services/dir.ts
+++ b/desktop/src/main/services/dir.ts
@@ -1,7 +1,7 @@
 import { shell } from "electron/common";
 import { app, dialog } from "electron/main";
 import path from "node:path";
-import { posixPath } from "../utils/electron";
+import { posixPath } from "../utils";
 
 export const selectDirectory = async () => {
     const result = await dialog.showOpenDialog({
diff --git a/desktop/src/main/services/ffmpeg.ts b/desktop/src/main/services/ffmpeg.ts
index 78b7a9e9a3..dc417c5952 100644
--- a/desktop/src/main/services/ffmpeg.ts
+++ b/desktop/src/main/services/ffmpeg.ts
@@ -2,8 +2,8 @@ import pathToFfmpeg from "ffmpeg-static";
 import fs from "node:fs/promises";
 import type { ZipItem } from "../../types/ipc";
 import log from "../log";
-import { withTimeout } from "../utils";
-import { execAsync } from "../utils/electron";
+import { execAsync } from "../utils";
+import { withTimeout } from "../utils/common";
 import {
     deleteTempFile,
     makeFileForDataOrPathOrZipItem,
diff --git a/desktop/src/main/services/image.ts b/desktop/src/main/services/image.ts
index 957fe81200..d607b0ead3 100644
--- a/desktop/src/main/services/image.ts
+++ b/desktop/src/main/services/image.ts
@@ -4,7 +4,7 @@ import fs from "node:fs/promises";
 import path from "node:path";
 import { CustomErrorMessage, type ZipItem } from "../../types/ipc";
 import log from "../log";
-import { execAsync, isDev } from "../utils/electron";
+import { execAsync, isDev } from "../utils";
 import {
     deleteTempFile,
     makeFileForDataOrPathOrZipItem,
diff --git a/desktop/src/main/services/ml-clip.ts b/desktop/src/main/services/ml-clip.ts
index 99e512aa61..67c6d2db76 100644
--- a/desktop/src/main/services/ml-clip.ts
+++ b/desktop/src/main/services/ml-clip.ts
@@ -22,6 +22,7 @@ const cachedCLIPImageSession = makeCachedInferenceSession(
 export const clipImageEmbedding = async (jpegImageData: Uint8Array) => {
     const tempFilePath = await makeTempFilePath();
     const imageStream = new Response(jpegImageData.buffer).body;
+    if (!imageStream) throw new Error("Missing body that we just fed data to");
     await writeStream(tempFilePath, imageStream);
     try {
         return await clipImageEmbedding_(tempFilePath);
@@ -134,11 +135,9 @@ const cachedCLIPTextSession = makeCachedInferenceSession(
     64173509 /* 61.2 MB */,
 );
 
-let _tokenizer: Tokenizer = null;
+let _tokenizer: Tokenizer | undefined;
 const getTokenizer = () => {
-    if (!_tokenizer) {
-        _tokenizer = new Tokenizer();
-    }
+    if (!_tokenizer) _tokenizer = new Tokenizer();
     return _tokenizer;
 };
 
diff --git a/desktop/src/main/services/watch.ts b/desktop/src/main/services/watch.ts
index 588279b70a..4d7b89e460 100644
--- a/desktop/src/main/services/watch.ts
+++ b/desktop/src/main/services/watch.ts
@@ -5,7 +5,7 @@ import path from "node:path";
 import { FolderWatch, type CollectionMapping } from "../../types/ipc";
 import log from "../log";
 import { watchStore } from "../stores/watch";
-import { posixPath } from "../utils/electron";
+import { posixPath } from "../utils";
 import { fsIsDir } from "./fs";
 
 /**
diff --git a/desktop/src/main/stream.ts b/desktop/src/main/stream.ts
index b37970cfae..be84c022f5 100644
--- a/desktop/src/main/stream.ts
+++ b/desktop/src/main/stream.ts
@@ -99,7 +99,10 @@ const handleReadZip = async (zipPath: string, entryName: string) => {
     try {
         const zip = new StreamZip.async({ file: zipPath });
         const entry = await zip.entry(entryName);
+        if (!entry) return new Response("", { status: 404 });
+
         const stream = await zip.stream(entry);
+
         // TODO(MR): when to call zip.close()
 
         return new Response(Readable.toWeb(new Readable(stream)), {
@@ -122,7 +125,7 @@ const handleReadZip = async (zipPath: string, entryName: string) => {
             `Failed to read entry ${entryName} from zip file at ${zipPath}`,
             e,
         );
-        return new Response(`Failed to read stream: ${e.message}`, {
+        return new Response(`Failed to read stream: ${String(e)}`, {
             status: 500,
         });
     }
diff --git a/desktop/src/main/utils/common.ts b/desktop/src/main/utils/common.ts
new file mode 100644
index 0000000000..100a8ad2d2
--- /dev/null
+++ b/desktop/src/main/utils/common.ts
@@ -0,0 +1,35 @@
+/**
+ * @file grab bag of utility functions.
+ *
+ * These are verbatim copies of functions from web code since there isn't
+ * currently a common package that both of them share.
+ */
+
+/**
+ * Wait for {@link ms} milliseconds
+ *
+ * This function is a promisified `setTimeout`. It returns a promise that
+ * resolves after {@link ms} milliseconds.
+ */
+export const wait = (ms: number) =>
+    new Promise((resolve) => setTimeout(resolve, ms));
+
+/**
+ * Await the given {@link promise} for {@link timeoutMS} milliseconds. If it
+ * does not resolve within {@link timeoutMS}, then reject with a timeout error.
+ */
+export const withTimeout = async <T>(promise: Promise<T>, ms: number) => {
+    let timeoutId: ReturnType<typeof setTimeout>;
+    const rejectOnTimeout = new Promise<T>((_, reject) => {
+        timeoutId = setTimeout(
+            () => reject(new Error("Operation timed out")),
+            ms,
+        );
+    });
+    const promiseAndCancelTimeout = async () => {
+        const result = await promise;
+        clearTimeout(timeoutId);
+        return result;
+    };
+    return Promise.race([promiseAndCancelTimeout(), rejectOnTimeout]);
+};
diff --git a/desktop/src/main/utils/electron.ts b/desktop/src/main/utils/electron.ts
deleted file mode 100644
index d627ec5c46..0000000000
--- a/desktop/src/main/utils/electron.ts
+++ /dev/null
@@ -1,49 +0,0 @@
-import shellescape from "any-shell-escape";
-import { app } from "electron/main";
-import { exec } from "node:child_process";
-import path from "node:path";
-import { promisify } from "node:util";
-import log from "../log";
-
-/** `true` if the app is running in development mode. */
-export const isDev = !app.isPackaged;
-
-/**
- * Convert a file system {@link filePath} that uses the local system specific
- * path separators into a path that uses POSIX file separators.
- */
-export const posixPath = (filePath: string) =>
-    filePath.split(path.sep).join(path.posix.sep);
-
-/**
- * Run a shell command asynchronously.
- *
- * This is a convenience promisified version of child_process.exec. It runs the
- * command asynchronously and returns its stdout and stderr if there were no
- * errors.
- *
- * If the command is passed as a string, then it will be executed verbatim.
- *
- * If the command is passed as an array, then the first argument will be treated
- * as the executable and the remaining (optional) items as the command line
- * parameters. This function will shellescape and join the array to form the
- * command that finally gets executed.
- *
- * > Note: This is not a 1-1 replacement of child_process.exec - if you're
- * > trying to run a trivial shell command, say something that produces a lot of
- * > output, this might not be the best option and it might be better to use the
- * > underlying functions.
- */
-export const execAsync = (command: string | string[]) => {
-    const escapedCommand = Array.isArray(command)
-        ? shellescape(command)
-        : command;
-    const startTime = Date.now();
-    const result = execAsync_(escapedCommand);
-    log.debug(
-        () => `${escapedCommand} (${Math.round(Date.now() - startTime)} ms)`,
-    );
-    return result;
-};
-
-const execAsync_ = promisify(exec);
diff --git a/desktop/src/main/utils/index.ts b/desktop/src/main/utils/index.ts
index 1ae35d55d3..d627ec5c46 100644
--- a/desktop/src/main/utils/index.ts
+++ b/desktop/src/main/utils/index.ts
@@ -1,35 +1,49 @@
-/**
- * @file grab bag of utility functions.
- *
- * Many of these are verbatim copies of functions from web code since there
- * isn't currently a common package that both of them share.
- */
+import shellescape from "any-shell-escape";
+import { app } from "electron/main";
+import { exec } from "node:child_process";
+import path from "node:path";
+import { promisify } from "node:util";
+import log from "../log";
+
+/** `true` if the app is running in development mode. */
+export const isDev = !app.isPackaged;
 
 /**
- * Wait for {@link ms} milliseconds
- *
- * This function is a promisified `setTimeout`. It returns a promise that
- * resolves after {@link ms} milliseconds.
+ * Convert a file system {@link filePath} that uses the local system specific
+ * path separators into a path that uses POSIX file separators.
  */
-export const wait = (ms: number) =>
-    new Promise((resolve) => setTimeout(resolve, ms));
+export const posixPath = (filePath: string) =>
+    filePath.split(path.sep).join(path.posix.sep);
 
 /**
- * Await the given {@link promise} for {@link timeoutMS} milliseconds. If it
- * does not resolve within {@link timeoutMS}, then reject with a timeout error.
+ * Run a shell command asynchronously.
+ *
+ * This is a convenience promisified version of child_process.exec. It runs the
+ * command asynchronously and returns its stdout and stderr if there were no
+ * errors.
+ *
+ * If the command is passed as a string, then it will be executed verbatim.
+ *
+ * If the command is passed as an array, then the first argument will be treated
+ * as the executable and the remaining (optional) items as the command line
+ * parameters. This function will shellescape and join the array to form the
+ * command that finally gets executed.
+ *
+ * > Note: This is not a 1-1 replacement of child_process.exec - if you're
+ * > trying to run a trivial shell command, say something that produces a lot of
+ * > output, this might not be the best option and it might be better to use the
+ * > underlying functions.
  */
-export const withTimeout = async <T>(promise: Promise<T>, ms: number) => {
-    let timeoutId: ReturnType<typeof setTimeout>;
-    const rejectOnTimeout = new Promise<T>((_, reject) => {
-        timeoutId = setTimeout(
-            () => reject(new Error("Operation timed out")),
-            ms,
-        );
-    });
-    const promiseAndCancelTimeout = async () => {
-        const result = await promise;
-        clearTimeout(timeoutId);
-        return result;
-    };
-    return Promise.race([promiseAndCancelTimeout(), rejectOnTimeout]);
+export const execAsync = (command: string | string[]) => {
+    const escapedCommand = Array.isArray(command)
+        ? shellescape(command)
+        : command;
+    const startTime = Date.now();
+    const result = execAsync_(escapedCommand);
+    log.debug(
+        () => `${escapedCommand} (${Math.round(Date.now() - startTime)} ms)`,
+    );
+    return result;
 };
+
+const execAsync_ = promisify(exec);
diff --git a/desktop/tsconfig.json b/desktop/tsconfig.json
index 700ea3fa00..16946bf3fe 100644
--- a/desktop/tsconfig.json
+++ b/desktop/tsconfig.json
@@ -50,12 +50,12 @@
         "outDir": "app",
 
         /* Temporary overrides to get things to compile with the older config */
-        "strict": false,
-        "noImplicitAny": true
+        // "strict": false,
+        "noImplicitAny": true,
 
         /* Below is the state we want */
         /* Enable these one by one */
-        // "strict": true,
+        "strict": true,
 
         /* Require the `type` modifier when importing types */
         // "verbatimModuleSyntax": true

From 72b9113d3045c74740d8310b84cf412ab28ca482 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 13:58:15 +0530
Subject: [PATCH 10/41] ensure

---
 desktop/src/main/services/ffmpeg.ts  | 4 ++--
 desktop/src/main/services/fs.ts      | 1 +
 desktop/src/main/services/ml-clip.ts | 4 ++--
 desktop/src/main/utils/common.ts     | 9 +++++++++
 web/packages/utils/ensure.ts         | 5 +++--
 5 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/desktop/src/main/services/ffmpeg.ts b/desktop/src/main/services/ffmpeg.ts
index dc417c5952..850b70d445 100644
--- a/desktop/src/main/services/ffmpeg.ts
+++ b/desktop/src/main/services/ffmpeg.ts
@@ -3,7 +3,7 @@ import fs from "node:fs/promises";
 import type { ZipItem } from "../../types/ipc";
 import log from "../log";
 import { execAsync } from "../utils";
-import { withTimeout } from "../utils/common";
+import { ensure, withTimeout } from "../utils/common";
 import {
     deleteTempFile,
     makeFileForDataOrPathOrZipItem,
@@ -110,5 +110,5 @@ const ffmpegBinaryPath = () => {
     // This substitution of app.asar by app.asar.unpacked is suggested by the
     // ffmpeg-static library author themselves:
     // https://github.com/eugeneware/ffmpeg-static/issues/16
-    return pathToFfmpeg.replace("app.asar", "app.asar.unpacked");
+    return ensure(pathToFfmpeg).replace("app.asar", "app.asar.unpacked");
 };
diff --git a/desktop/src/main/services/fs.ts b/desktop/src/main/services/fs.ts
index 2428d3a80c..4570a4a33a 100644
--- a/desktop/src/main/services/fs.ts
+++ b/desktop/src/main/services/fs.ts
@@ -1,6 +1,7 @@
 /**
  * @file file system related functions exposed over the context bridge.
  */
+
 import { existsSync } from "node:fs";
 import fs from "node:fs/promises";
 
diff --git a/desktop/src/main/services/ml-clip.ts b/desktop/src/main/services/ml-clip.ts
index 67c6d2db76..149f634b55 100644
--- a/desktop/src/main/services/ml-clip.ts
+++ b/desktop/src/main/services/ml-clip.ts
@@ -11,6 +11,7 @@ import * as ort from "onnxruntime-node";
 import Tokenizer from "../../thirdparty/clip-bpe-ts/mod";
 import log from "../log";
 import { writeStream } from "../stream";
+import { ensure } from "../utils/common";
 import { deleteTempFile, makeTempFilePath } from "../utils/temp";
 import { makeCachedInferenceSession } from "./ml";
 
@@ -22,8 +23,7 @@ const cachedCLIPImageSession = makeCachedInferenceSession(
 export const clipImageEmbedding = async (jpegImageData: Uint8Array) => {
     const tempFilePath = await makeTempFilePath();
     const imageStream = new Response(jpegImageData.buffer).body;
-    if (!imageStream) throw new Error("Missing body that we just fed data to");
-    await writeStream(tempFilePath, imageStream);
+    await writeStream(tempFilePath, ensure(imageStream));
     try {
         return await clipImageEmbedding_(tempFilePath);
     } finally {
diff --git a/desktop/src/main/utils/common.ts b/desktop/src/main/utils/common.ts
index 100a8ad2d2..1f5016e617 100644
--- a/desktop/src/main/utils/common.ts
+++ b/desktop/src/main/utils/common.ts
@@ -5,6 +5,15 @@
  * currently a common package that both of them share.
  */
 
+/**
+ * Throw an exception if the given value is `null` or `undefined`.
+ */
+export const ensure = <T>(v: T | null | undefined): T => {
+    if (v === null) throw new Error("Required value was null");
+    if (v === undefined) throw new Error("Required value was not found");
+    return v;
+};
+
 /**
  * Wait for {@link ms} milliseconds
  *
diff --git a/web/packages/utils/ensure.ts b/web/packages/utils/ensure.ts
index 761cedc992..93706bfb61 100644
--- a/web/packages/utils/ensure.ts
+++ b/web/packages/utils/ensure.ts
@@ -1,7 +1,8 @@
 /**
- * Throw an exception if the given value is undefined.
+ * Throw an exception if the given value is `null` or `undefined`.
  */
-export const ensure = <T>(v: T | undefined): T => {
+export const ensure = <T>(v: T | null | undefined): T => {
+    if (v === null) throw new Error("Required value was null");
     if (v === undefined) throw new Error("Required value was not found");
     return v;
 };

From bee2cd533ce0fece2d221fa9cbdacb55634124f4 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 14:01:28 +0530
Subject: [PATCH 11/41] strict 2

---
 desktop/src/main/services/ml.ts | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/desktop/src/main/services/ml.ts b/desktop/src/main/services/ml.ts
index 8292596a22..6b38bc74dc 100644
--- a/desktop/src/main/services/ml.ts
+++ b/desktop/src/main/services/ml.ts
@@ -34,6 +34,7 @@ import { writeStream } from "../stream";
  * actively trigger a download until the returned function is called.
  *
  * @param modelName The name of the model to download.
+ *
  * @param modelByteSize The size in bytes that we expect the model to have. If
  * the size of the downloaded model does not match the expected size, then we
  * will redownload it.
@@ -99,13 +100,15 @@ const downloadModel = async (saveLocation: string, name: string) => {
     // `mkdir -p` the directory where we want to save the model.
     const saveDir = path.dirname(saveLocation);
     await fs.mkdir(saveDir, { recursive: true });
-    // Download
+    // Download.
     log.info(`Downloading ML model from ${name}`);
     const url = `https://models.ente.io/${name}`;
     const res = await net.fetch(url);
     if (!res.ok) throw new Error(`Failed to fetch ${url}: HTTP ${res.status}`);
-    // Save
-    await writeStream(saveLocation, res.body);
+    const body = res.body;
+    if (!body) throw new Error(`Received an null response for ${url}`);
+    // Save.
+    await writeStream(saveLocation, body);
     log.info(`Downloaded CLIP model ${name}`);
 };
 
@@ -114,9 +117,9 @@ const downloadModel = async (saveLocation: string, name: string) => {
  */
 const createInferenceSession = async (modelPath: string) => {
     return await ort.InferenceSession.create(modelPath, {
-        // Restrict the number of threads to 1
+        // Restrict the number of threads to 1.
         intraOpNumThreads: 1,
-        // Be more conservative with RAM usage
+        // Be more conservative with RAM usage.
         enableCpuMemArena: false,
     });
 };

From 0c312c0ea15d1cfc60f68b93008c619fdc32ba02 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 14:10:59 +0530
Subject: [PATCH 12/41] strict 3

---
 desktop/src/main/services/upload.ts                | 10 +++++++---
 desktop/src/types/ipc.ts                           |  2 +-
 web/apps/photos/src/components/Upload/Uploader.tsx |  6 +-----
 web/packages/next/types/ipc.ts                     |  4 +++-
 4 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/desktop/src/main/services/upload.ts b/desktop/src/main/services/upload.ts
index a1103a748b..c3efbb9f40 100644
--- a/desktop/src/main/services/upload.ts
+++ b/desktop/src/main/services/upload.ts
@@ -35,6 +35,10 @@ export const pathOrZipItemSize = async (
         const [zipPath, entryName] = pathOrZipItem;
         const zip = new StreamZip.async({ file: zipPath });
         const entry = await zip.entry(entryName);
+        if (!entry)
+            throw new Error(
+                `An entry with name ${entryName} does not exist in the zip file at ${zipPath}`,
+            );
         const size = entry.size;
         zip.close();
         return size;
@@ -60,7 +64,7 @@ export const pendingUploads = async (): Promise<PendingUploads | undefined> => {
     // file, but the dedup logic will kick in at that point so no harm will come
     // off it.
     if (allZipItems === undefined) {
-        const allZipPaths = uploadStatusStore.get("filePaths");
+        const allZipPaths = uploadStatusStore.get("filePaths") ?? [];
         const zipPaths = allZipPaths.filter((f) => existsSync(f));
         zipItems = [];
         for (const zip of zipPaths)
@@ -83,7 +87,7 @@ export const setPendingUploads = async (pendingUploads: PendingUploads) =>
 
 export const markUploadedFiles = async (paths: string[]) => {
     const existing = uploadStatusStore.get("filePaths");
-    const updated = existing.filter((p) => !paths.includes(p));
+    const updated = existing?.filter((p) => !paths.includes(p));
     uploadStatusStore.set("filePaths", updated);
 };
 
@@ -91,7 +95,7 @@ export const markUploadedZipItems = async (
     items: [zipPath: string, entryName: string][],
 ) => {
     const existing = uploadStatusStore.get("zipItems");
-    const updated = existing.filter(
+    const updated = existing?.filter(
         (z) => !items.some((e) => z[0] == e[0] && z[1] == e[1]),
     );
     uploadStatusStore.set("zipItems", updated);
diff --git a/desktop/src/types/ipc.ts b/desktop/src/types/ipc.ts
index c02ed17260..c8c7ef6b4a 100644
--- a/desktop/src/types/ipc.ts
+++ b/desktop/src/types/ipc.ts
@@ -28,7 +28,7 @@ export interface FolderWatchSyncedFile {
 export type ZipItem = [zipPath: string, entryName: string];
 
 export interface PendingUploads {
-    collectionName: string;
+    collectionName?: string;
     filePaths: string[];
     zipItems: ZipItem[];
 }
diff --git a/web/apps/photos/src/components/Upload/Uploader.tsx b/web/apps/photos/src/components/Upload/Uploader.tsx
index 90b5f94b4e..0d310d7f90 100644
--- a/web/apps/photos/src/components/Upload/Uploader.tsx
+++ b/web/apps/photos/src/components/Upload/Uploader.tsx
@@ -930,9 +930,5 @@ export const setPendingUploads = async (
         }
     }
 
-    await electron.setPendingUploads({
-        collectionName,
-        filePaths,
-        zipItems: zipItems,
-    });
+    await electron.setPendingUploads({ collectionName, filePaths, zipItems });
 };
diff --git a/web/packages/next/types/ipc.ts b/web/packages/next/types/ipc.ts
index d97a7e5643..895dfcf701 100644
--- a/web/packages/next/types/ipc.ts
+++ b/web/packages/next/types/ipc.ts
@@ -650,8 +650,10 @@ export interface PendingUploads {
      * This is name of the collection (when uploading to a singular collection)
      * or the root collection (when uploading to separate * albums) to which we
      * these uploads are meant to go to. See {@link CollectionMapping}.
+     *
+     * It will not be set if we're just uploading standalone files.
      */
-    collectionName: string;
+    collectionName?: string;
     /**
      * Paths of regular files that need to be uploaded.
      */

From 612d8682b5151b95ab6e345691598f7bceca5773 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 14:19:25 +0530
Subject: [PATCH 13/41] strict

---
 desktop/src/main/services/watch.ts | 19 +++++++++----------
 desktop/src/main/stream.ts         |  7 ++++---
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/desktop/src/main/services/watch.ts b/desktop/src/main/services/watch.ts
index 4d7b89e460..e8e3803902 100644
--- a/desktop/src/main/services/watch.ts
+++ b/desktop/src/main/services/watch.ts
@@ -47,16 +47,15 @@ const eventData = (path: string): [string, FolderWatch] => {
     return [path, watch];
 };
 
-export const watchGet = (watcher: FSWatcher) => {
-    const [valid, deleted] = folderWatches().reduce(
-        ([valid, deleted], watch) => {
-            (fsIsDir(watch.folderPath) ? valid : deleted).push(watch);
-            return [valid, deleted];
-        },
-        [[], []],
-    );
-    if (deleted.length) {
-        for (const watch of deleted) watchRemove(watcher, watch.folderPath);
+export const watchGet = async (watcher: FSWatcher): Promise<FolderWatch[]> => {
+    const valid: FolderWatch[] = [];
+    const deletedPaths: string[] = [];
+    for (const watch of folderWatches()) {
+        if (await fsIsDir(watch.folderPath)) valid.push(watch);
+        else deletedPaths.push(watch.folderPath);
+    }
+    if (deletedPaths.length) {
+        await Promise.all(deletedPaths.map((p) => watchRemove(watcher, p)));
         setFolderWatches(valid);
     }
     return valid;
diff --git a/desktop/src/main/stream.ts b/desktop/src/main/stream.ts
index be84c022f5..26021fdf1f 100644
--- a/desktop/src/main/stream.ts
+++ b/desktop/src/main/stream.ts
@@ -8,6 +8,7 @@ import fs from "node:fs/promises";
 import { Readable } from "node:stream";
 import { pathToFileURL } from "node:url";
 import log from "./log";
+import { ensure } from "./utils/common";
 
 /**
  * Register a protocol handler that we use for streaming large files between the
@@ -89,7 +90,7 @@ const handleRead = async (path: string) => {
         return res;
     } catch (e) {
         log.error(`Failed to read stream at ${path}`, e);
-        return new Response(`Failed to read stream: ${e.message}`, {
+        return new Response(`Failed to read stream: ${String(e)}`, {
             status: 500,
         });
     }
@@ -133,11 +134,11 @@ const handleReadZip = async (zipPath: string, entryName: string) => {
 
 const handleWrite = async (path: string, request: Request) => {
     try {
-        await writeStream(path, request.body);
+        await writeStream(path, ensure(request.body));
         return new Response("", { status: 200 });
     } catch (e) {
         log.error(`Failed to write stream to ${path}`, e);
-        return new Response(`Failed to write stream: ${e.message}`, {
+        return new Response(`Failed to write stream: ${String(e)}`, {
             status: 500,
         });
     }

From 5681f1496765c46a484e72899ca90b21c6d6a984 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 14:31:06 +0530
Subject: [PATCH 14/41] Clarify that entry names are guaranteed to be posixy

---
 web/packages/next/types/ipc.ts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/web/packages/next/types/ipc.ts b/web/packages/next/types/ipc.ts
index 895dfcf701..d5007ea800 100644
--- a/web/packages/next/types/ipc.ts
+++ b/web/packages/next/types/ipc.ts
@@ -632,6 +632,19 @@ export interface FolderWatchSyncedFile {
  * The name of the entry is not just the file name, but rather is the full path
  * of the file within the zip. That is, each entry name uniquely identifies a
  * particular file within the given zip.
+ *
+ * When `entryName` is a path within a nested directory, it is guaranteed to use
+ * the POSIX path separator ("/") since that is the path separator required by
+ * the ZIP format itself
+ *
+ * > 4.4.17.1 The name of the file, with optional relative path.
+ * >
+ * >  The path stored MUST NOT contain a drive or  device letter, or a leading
+ * >  slash. All slashes MUST be forward slashes '/' as opposed to  backwards
+ * >  slashes '\' for compatibility with Amiga and UNIX file systems etc.  If
+ * >  input came from standard input, there is no file name field.
+ * >
+ * > https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT
  */
 export type ZipItem = [zipPath: string, entryName: string];
 

From 9cc730e6a9e1a6bdb5e6dee77e0cde939e2e1705 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 14:56:13 +0530
Subject: [PATCH 15/41] more posix

---
 web/apps/photos/src/components/Upload/Uploader.tsx | 4 +++-
 web/packages/next/types/ipc.ts                     | 2 +-
 web/packages/shared/hooks/useFileInput.tsx         | 4 ++++
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/web/apps/photos/src/components/Upload/Uploader.tsx b/web/apps/photos/src/components/Upload/Uploader.tsx
index 0d310d7f90..cfd674e3f8 100644
--- a/web/apps/photos/src/components/Upload/Uploader.tsx
+++ b/web/apps/photos/src/components/Upload/Uploader.tsx
@@ -324,10 +324,12 @@ export default function Uploader({
     // Trigger an upload when any of the dependencies change.
     useEffect(() => {
         const allItemAndPaths = [
-            // See: [Note: webkitRelativePath]
+            // See: [Note: webkitRelativePath]. In particular, they use POSIX
+            // separators.
             webFiles.map((f) => [f, f.webkitRelativePath ?? f.name]),
             desktopFiles.map((fp) => [fp, fp.path]),
             desktopFilePaths.map((p) => [p, p]),
+            // ze[1], the entry name, uses POSIX separators.
             desktopZipItems.map((ze) => [ze, ze[1]]),
         ].flat() as [UploadItem, string][];
 
diff --git a/web/packages/next/types/ipc.ts b/web/packages/next/types/ipc.ts
index d5007ea800..c851062410 100644
--- a/web/packages/next/types/ipc.ts
+++ b/web/packages/next/types/ipc.ts
@@ -641,7 +641,7 @@ export interface FolderWatchSyncedFile {
  * >
  * >  The path stored MUST NOT contain a drive or  device letter, or a leading
  * >  slash. All slashes MUST be forward slashes '/' as opposed to  backwards
- * >  slashes '\' for compatibility with Amiga and UNIX file systems etc.  If
+ * >  slashes '\' for compatibility with Amiga and UNIX file systems etc. If
  * >  input came from standard input, there is no file name field.
  * >
  * > https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT
diff --git a/web/packages/shared/hooks/useFileInput.tsx b/web/packages/shared/hooks/useFileInput.tsx
index ae1dfcab0a..71f027cefe 100644
--- a/web/packages/shared/hooks/useFileInput.tsx
+++ b/web/packages/shared/hooks/useFileInput.tsx
@@ -60,6 +60,10 @@ export default function useFileInput({
     // containing the relative path to the selected directory.
     //
     // https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory
+    //
+    // These paths use the POSIX path separator ("/").
+    // https://stackoverflow.com/questions/62806233/when-using-webkitrelativepath-is-the-path-separator-operating-system-specific
+    //
     const directoryOpts = directory
         ? { directory: "", webkitdirectory: "" }
         : {};

From 824e73f150b0b02e419e737f499fa41abc859c9a Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 15:30:57 +0530
Subject: [PATCH 16/41] strict

---
 desktop/src/main/stream.ts | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/desktop/src/main/stream.ts b/desktop/src/main/stream.ts
index 26021fdf1f..7b773baed3 100644
--- a/desktop/src/main/stream.ts
+++ b/desktop/src/main/stream.ts
@@ -102,11 +102,23 @@ const handleReadZip = async (zipPath: string, entryName: string) => {
         const entry = await zip.entry(entryName);
         if (!entry) return new Response("", { status: 404 });
 
+        // This returns an "old style" NodeJS.ReadableStream.
         const stream = await zip.stream(entry);
+        // Convert it into a new style NodeJS.Readable.
+        const nodeReadable = new Readable().wrap(stream);
+        // Then convert it into a Web stream.
+        const webReadableStreamAny = Readable.toWeb(nodeReadable);
+        // However, we get a ReadableStream<any> now. This doesn't go into the
+        // `BodyInit` expected by the Response constructor, which wants a
+        // ReadableStream<Uint8Array>. Force a cast.
+        const webReadableStream =
+            webReadableStreamAny as ReadableStream<Uint8Array>;
 
-        // TODO(MR): when to call zip.close()
+        // Close the zip handle when the underlying stream closes.
+        // TODO(MR): Verify
+        stream.on("end", () => zip.close());
 
-        return new Response(Readable.toWeb(new Readable(stream)), {
+        return new Response(webReadableStream, {
             headers: {
                 // We don't know the exact type, but it doesn't really matter,
                 // just set it to a generic binary content-type so that the

From 2f3a2421f796c481e6bfe9f260963c09f26f5585 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 15:44:16 +0530
Subject: [PATCH 17/41] Strict

---
 desktop/src/main/services/ml-clip.ts      | 70 +++++++++++------------
 desktop/src/main/services/ml-face.ts      |  3 +-
 desktop/src/main/stores/upload-status.ts  |  8 +--
 desktop/src/thirdparty/clip-bpe-ts/mod.ts |  3 +
 desktop/src/types/ipc.ts                  |  2 +-
 desktop/tsconfig.json                     | 31 +++++-----
 6 files changed, 58 insertions(+), 59 deletions(-)

diff --git a/desktop/src/main/services/ml-clip.ts b/desktop/src/main/services/ml-clip.ts
index 149f634b55..451cdcb09b 100644
--- a/desktop/src/main/services/ml-clip.ts
+++ b/desktop/src/main/services/ml-clip.ts
@@ -45,7 +45,7 @@ const clipImageEmbedding_ = async (jpegFilePath: string) => {
             `onnx/clip image embedding took ${Date.now() - t1} ms (prep: ${t2 - t1} ms, inference: ${Date.now() - t2} ms)`,
     );
     /* Need these model specific casts to type the result */
-    const imageEmbedding = results["output"].data as Float32Array;
+    const imageEmbedding = ensure(results["output"]).data as Float32Array;
     return normalizeEmbedding(imageEmbedding);
 };
 
@@ -56,19 +56,19 @@ const getRGBData = async (jpegFilePath: string) => {
         formatAsRGBA: false,
     });
 
-    const nx: number = rawImageData.width;
-    const ny: number = rawImageData.height;
-    const inputImage: Uint8Array = rawImageData.data;
+    const nx = rawImageData.width;
+    const ny = rawImageData.height;
+    const inputImage = rawImageData.data;
 
-    const nx2: number = 224;
-    const ny2: number = 224;
-    const totalSize: number = 3 * nx2 * ny2;
+    const nx2 = 224;
+    const ny2 = 224;
+    const totalSize = 3 * nx2 * ny2;
 
     const result: number[] = Array(totalSize).fill(0);
-    const scale: number = Math.max(nx, ny) / 224;
+    const scale = Math.max(nx, ny) / 224;
 
-    const nx3: number = Math.round(nx / scale);
-    const ny3: number = Math.round(ny / scale);
+    const nx3 = Math.round(nx / scale);
+    const ny3 = Math.round(ny / scale);
 
     const mean: number[] = [0.48145466, 0.4578275, 0.40821073];
     const std: number[] = [0.26862954, 0.26130258, 0.27577711];
@@ -77,40 +77,40 @@ const getRGBData = async (jpegFilePath: string) => {
         for (let x = 0; x < nx3; x++) {
             for (let c = 0; c < 3; c++) {
                 // Linear interpolation
-                const sx: number = (x + 0.5) * scale - 0.5;
-                const sy: number = (y + 0.5) * scale - 0.5;
+                const sx = (x + 0.5) * scale - 0.5;
+                const sy = (y + 0.5) * scale - 0.5;
 
-                const x0: number = Math.max(0, Math.floor(sx));
-                const y0: number = Math.max(0, Math.floor(sy));
+                const x0 = Math.max(0, Math.floor(sx));
+                const y0 = Math.max(0, Math.floor(sy));
 
-                const x1: number = Math.min(x0 + 1, nx - 1);
-                const y1: number = Math.min(y0 + 1, ny - 1);
+                const x1 = Math.min(x0 + 1, nx - 1);
+                const y1 = Math.min(y0 + 1, ny - 1);
 
-                const dx: number = sx - x0;
-                const dy: number = sy - y0;
+                const dx = sx - x0;
+                const dy = sy - y0;
 
-                const j00: number = 3 * (y0 * nx + x0) + c;
-                const j01: number = 3 * (y0 * nx + x1) + c;
-                const j10: number = 3 * (y1 * nx + x0) + c;
-                const j11: number = 3 * (y1 * nx + x1) + c;
+                const j00 = 3 * (y0 * nx + x0) + c;
+                const j01 = 3 * (y0 * nx + x1) + c;
+                const j10 = 3 * (y1 * nx + x0) + c;
+                const j11 = 3 * (y1 * nx + x1) + c;
 
-                const v00: number = inputImage[j00];
-                const v01: number = inputImage[j01];
-                const v10: number = inputImage[j10];
-                const v11: number = inputImage[j11];
+                const v00 = inputImage[j00] ?? 0;
+                const v01 = inputImage[j01] ?? 0;
+                const v10 = inputImage[j10] ?? 0;
+                const v11 = inputImage[j11] ?? 0;
 
-                const v0: number = v00 * (1 - dx) + v01 * dx;
-                const v1: number = v10 * (1 - dx) + v11 * dx;
+                const v0 = v00 * (1 - dx) + v01 * dx;
+                const v1 = v10 * (1 - dx) + v11 * dx;
 
-                const v: number = v0 * (1 - dy) + v1 * dy;
+                const v = v0 * (1 - dy) + v1 * dy;
 
-                const v2: number = Math.min(Math.max(Math.round(v), 0), 255);
+                const v2 = Math.min(Math.max(Math.round(v), 0), 255);
 
                 // createTensorWithDataList is dumb compared to reshape and
                 // hence has to be given with one channel after another
-                const i: number = y * nx3 + x + (c % 3) * 224 * 224;
+                const i = y * nx3 + x + (c % 3) * 224 * 224;
 
-                result[i] = (v2 / 255 - mean[c]) / std[c];
+                result[i] = (v2 / 255 - (mean[c] ?? 0)) / (std[c] ?? 1);
             }
         }
     }
@@ -121,11 +121,11 @@ const getRGBData = async (jpegFilePath: string) => {
 const normalizeEmbedding = (embedding: Float32Array) => {
     let normalization = 0;
     for (let index = 0; index < embedding.length; index++) {
-        normalization += embedding[index] * embedding[index];
+        normalization += ensure(embedding[index]) * ensure(embedding[index]);
     }
     const sqrtNormalization = Math.sqrt(normalization);
     for (let index = 0; index < embedding.length; index++) {
-        embedding[index] = embedding[index] / sqrtNormalization;
+        embedding[index] = ensure(embedding[index]) / sqrtNormalization;
     }
     return embedding;
 };
@@ -168,6 +168,6 @@ export const clipTextEmbeddingIfAvailable = async (text: string) => {
         () =>
             `onnx/clip text embedding took ${Date.now() - t1} ms (prep: ${t2 - t1} ms, inference: ${Date.now() - t2} ms)`,
     );
-    const textEmbedding = results["output"].data as Float32Array;
+    const textEmbedding = ensure(results["output"]).data as Float32Array;
     return normalizeEmbedding(textEmbedding);
 };
diff --git a/desktop/src/main/services/ml-face.ts b/desktop/src/main/services/ml-face.ts
index 2309d193cd..e4e43a4b0e 100644
--- a/desktop/src/main/services/ml-face.ts
+++ b/desktop/src/main/services/ml-face.ts
@@ -8,6 +8,7 @@
  */
 import * as ort from "onnxruntime-node";
 import log from "../log";
+import { ensure } from "../utils/common";
 import { makeCachedInferenceSession } from "./ml";
 
 const cachedFaceDetectionSession = makeCachedInferenceSession(
@@ -23,7 +24,7 @@ export const detectFaces = async (input: Float32Array) => {
     };
     const results = await session.run(feeds);
     log.debug(() => `onnx/yolo face detection took ${Date.now() - t} ms`);
-    return results["output"].data;
+    return ensure(results["output"]).data;
 };
 
 const cachedFaceEmbeddingSession = makeCachedInferenceSession(
diff --git a/desktop/src/main/stores/upload-status.ts b/desktop/src/main/stores/upload-status.ts
index 472f38a7f9..f098e9fc5c 100644
--- a/desktop/src/main/stores/upload-status.ts
+++ b/desktop/src/main/stores/upload-status.ts
@@ -6,24 +6,24 @@ export interface UploadStatusStore {
      *
      * Not all pending uploads will have an associated collection.
      */
-    collectionName?: string;
+    collectionName: string | undefined;
     /**
      * Paths to regular files that are pending upload.
      *
      * This should generally be present, albeit empty, but it is marked optional
      * in sympathy with its siblings.
      */
-    filePaths?: string[];
+    filePaths: string[] | undefined;
     /**
      * Each item is the path to a zip file and the name of an entry within it.
      *
      * This is marked optional since legacy stores will not have it.
      */
-    zipItems?: [zipPath: string, entryName: string][];
+    zipItems: [zipPath: string, entryName: string][] | undefined;
     /**
      * @deprecated Legacy paths to zip files, now subsumed into zipItems.
      */
-    zipPaths?: string[];
+    zipPaths: string[] | undefined;
 }
 
 const uploadStatusSchema: Schema<UploadStatusStore> = {
diff --git a/desktop/src/thirdparty/clip-bpe-ts/mod.ts b/desktop/src/thirdparty/clip-bpe-ts/mod.ts
index 6cdf246f75..b59b762e7c 100644
--- a/desktop/src/thirdparty/clip-bpe-ts/mod.ts
+++ b/desktop/src/thirdparty/clip-bpe-ts/mod.ts
@@ -410,6 +410,7 @@ export default class {
                     newWord.push(first + second);
                     i += 2;
                 } else {
+                    // @ts-expect-error "Array indexing can return undefined but not modifying thirdparty code"
                     newWord.push(word[i]);
                     i += 1;
                 }
@@ -434,6 +435,7 @@ export default class {
                 .map((b) => this.byteEncoder[b.charCodeAt(0) as number])
                 .join("");
             bpeTokens.push(
+                // @ts-expect-error "Array indexing can return undefined but not modifying thirdparty code"
                 ...this.bpe(token)
                     .split(" ")
                     .map((bpeToken: string) => this.encoder[bpeToken]),
@@ -458,6 +460,7 @@ export default class {
             .join("");
         text = [...text]
             .map((c) => this.byteDecoder[c])
+            // @ts-expect-error "Array indexing can return undefined but not modifying thirdparty code"
             .map((v) => String.fromCharCode(v))
             .join("")
             .replace(/<\/w>/g, " ");
diff --git a/desktop/src/types/ipc.ts b/desktop/src/types/ipc.ts
index c8c7ef6b4a..f4985bfc71 100644
--- a/desktop/src/types/ipc.ts
+++ b/desktop/src/types/ipc.ts
@@ -28,7 +28,7 @@ export interface FolderWatchSyncedFile {
 export type ZipItem = [zipPath: string, entryName: string];
 
 export interface PendingUploads {
-    collectionName?: string;
+    collectionName: string | undefined;
     filePaths: string[];
     zipItems: ZipItem[];
 }
diff --git a/desktop/tsconfig.json b/desktop/tsconfig.json
index 16946bf3fe..654158a50d 100644
--- a/desktop/tsconfig.json
+++ b/desktop/tsconfig.json
@@ -41,33 +41,28 @@
         "target": "es2022",
         "module": "node16",
 
+        /* Emit the generated JS into `app/` */
+        "outDir": "app",
+
         /* Enable various workarounds to play better with CJS libraries */
         "esModuleInterop": true,
         /* Speed things up by not type checking `node_modules` */
         "skipLibCheck": true,
 
-        /* Emit the generated JS into `app/` */
-        "outDir": "app",
-
-        /* Temporary overrides to get things to compile with the older config */
-        // "strict": false,
-        "noImplicitAny": true,
-
-        /* Below is the state we want */
-        /* Enable these one by one */
-        "strict": true,
-
         /* Require the `type` modifier when importing types */
-        // "verbatimModuleSyntax": true
+        /* We want this, but it causes "ESM syntax is not allowed in a CommonJS
+           module when 'verbatimModuleSyntax' is enabled" currently */
+        /* "verbatimModuleSyntax": true, */
 
+        "strict": true,
         /* Stricter than strict */
-        // "noImplicitReturns": true,
-        // "noUnusedParameters": true,
-        // "noUnusedLocals": true,
-        // "noFallthroughCasesInSwitch": true,
+        "noImplicitReturns": true,
+        "noUnusedParameters": true,
+        "noUnusedLocals": true,
+        "noFallthroughCasesInSwitch": true,
         /* e.g. makes array indexing returns undefined */
-        // "noUncheckedIndexedAccess": true,
-        // "exactOptionalPropertyTypes": true,
+        "noUncheckedIndexedAccess": true,
+        "exactOptionalPropertyTypes": true
     },
     /* Transpile all `.ts` files in `src/` */
     "include": ["src/**/*.ts"]

From 51ffaa4a904551412bd2a82063c722246fe89d80 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 15:59:10 +0530
Subject: [PATCH 18/41] Preempt

---
 desktop/docs/dependencies.md |  3 +++
 desktop/package.json         |  1 +
 desktop/src/main/stream.ts   |  1 +
 desktop/tsconfig.json        | 50 +++++++-----------------------------
 desktop/yarn.lock            |  5 ++++
 5 files changed, 19 insertions(+), 41 deletions(-)

diff --git a/desktop/docs/dependencies.md b/desktop/docs/dependencies.md
index 5c6b222b08..6052357033 100644
--- a/desktop/docs/dependencies.md
+++ b/desktop/docs/dependencies.md
@@ -90,6 +90,9 @@ Some extra ones specific to the code here are:
     Unix commands in our `package.json` scripts. This allows us to use the same
     commands (like `ln`) across different platforms like Linux and Windows.
 
+-   [@tsconfig/recommended](https://github.com/tsconfig/bases) gives us a base
+    tsconfig for the Node.js version that our current Electron version uses.
+
 ## Functionality
 
 ### Format conversion
diff --git a/desktop/package.json b/desktop/package.json
index 69d54f75be..509ee85838 100644
--- a/desktop/package.json
+++ b/desktop/package.json
@@ -34,6 +34,7 @@
         "onnxruntime-node": "^1.17"
     },
     "devDependencies": {
+        "@tsconfig/node20": "^20.1.4",
         "@types/auto-launch": "^5.0",
         "@types/ffmpeg-static": "^3.0",
         "@typescript-eslint/eslint-plugin": "^7",
diff --git a/desktop/src/main/stream.ts b/desktop/src/main/stream.ts
index 7b773baed3..15715c5500 100644
--- a/desktop/src/main/stream.ts
+++ b/desktop/src/main/stream.ts
@@ -6,6 +6,7 @@ import StreamZip from "node-stream-zip";
 import { createWriteStream, existsSync } from "node:fs";
 import fs from "node:fs/promises";
 import { Readable } from "node:stream";
+import { ReadableStream } from "node:stream/web";
 import { pathToFileURL } from "node:url";
 import log from "./log";
 import { ensure } from "./utils/common";
diff --git a/desktop/tsconfig.json b/desktop/tsconfig.json
index 654158a50d..7806cd93a7 100644
--- a/desktop/tsconfig.json
+++ b/desktop/tsconfig.json
@@ -3,52 +3,20 @@
        into JavaScript that'll then be loaded and run by the main (node) process
        of our Electron app. */
 
+    /*
+     * Recommended target, lib and other settings for code running in the
+     * version of Node.js bundled with Electron.
+     *
+     * Currently, with Electron 30, this is Node.js 20.11.1.
+     * https://www.electronjs.org/blog/electron-30-0
+     */
+    "extends": "@tsconfig/node20/tsconfig.json",
+
     /* TSConfig docs: https://aka.ms/tsconfig.json */
-
     "compilerOptions": {
-        /* Recommended target, lib and other settings for code running in the
-           version of Node.js bundled with Electron.
-
-           Currently, with Electron 29, this is Node.js 20.9
-           https://www.electronjs.org/blog/electron-29-0
-
-           Note that we cannot do
-
-               "extends": "@tsconfig/node20/tsconfig.json",
-
-           because that sets "lib": ["es2023"]. However (and I don't fully
-           understand what's going on here), that breaks our compilation since
-           tsc can then not find type definitions of things like ReadableStream.
-
-           Adding "dom" to "lib" (e.g. `"lib": ["es2023", "dom"]`) fixes the
-           issue, but that doesn't sound correct - the main Electron process
-           isn't running in a browser context.
-
-           It is possible that we're using some of the types incorrectly. For
-           now, we just omit the "lib" definition and rely on the defaults for
-           the "target" we've chosen. This is also what the current
-           electron-forge starter does:
-
-               yarn create electron-app electron-forge-starter -- --template=webpack-typescript
-
-           Enhancement: Can revisit this later.
-
-           Refs:
-           - https://github.com/electron/electron/issues/27092
-           - https://github.com/electron/electron/issues/16146
-        */
-
-        "target": "es2022",
-        "module": "node16",
-
         /* Emit the generated JS into `app/` */
         "outDir": "app",
 
-        /* Enable various workarounds to play better with CJS libraries */
-        "esModuleInterop": true,
-        /* Speed things up by not type checking `node_modules` */
-        "skipLibCheck": true,
-
         /* Require the `type` modifier when importing types */
         /* We want this, but it causes "ESM syntax is not allowed in a CommonJS
            module when 'verbatimModuleSyntax' is enabled" currently */
diff --git a/desktop/yarn.lock b/desktop/yarn.lock
index a5b86f1eb3..bf9057d472 100644
--- a/desktop/yarn.lock
+++ b/desktop/yarn.lock
@@ -246,6 +246,11 @@
   resolved "https://registry.yarnpkg.com/@tootallnate/once/-/once-2.0.0.tgz#f544a148d3ab35801c1f633a7441fd87c2e484bf"
   integrity sha512-XCuKFP5PS55gnMVu3dty8KPatLqUoy/ZYzDzAGCQ8JNFCkLXzmI7vNHCR+XpbZaMWQK/vQubr7PkYq8g470J/A==
 
+"@tsconfig/node20@^20.1.4":
+  version "20.1.4"
+  resolved "https://registry.yarnpkg.com/@tsconfig/node20/-/node20-20.1.4.tgz#3457d42eddf12d3bde3976186ab0cd22b85df928"
+  integrity sha512-sqgsT69YFeLWf5NtJ4Xq/xAF8p4ZQHlmGW74Nu2tD4+g5fAsposc4ZfaaPixVu4y01BEiDCWLRDCvDM5JOsRxg==
+
 "@types/auto-launch@^5.0":
   version "5.0.5"
   resolved "https://registry.yarnpkg.com/@types/auto-launch/-/auto-launch-5.0.5.tgz#439ed36aaaea501e2e2cfbddd8a20c366c34863b"

From 9b996ff353d34e8bde539993abfb8d54511a827f Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 16:03:52 +0530
Subject: [PATCH 19/41] Lint+

---
 desktop/.eslintrc.js                      | 2 +-
 desktop/src/thirdparty/clip-bpe-ts/mod.ts | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/desktop/.eslintrc.js b/desktop/.eslintrc.js
index 977071a270..d9c13a4423 100644
--- a/desktop/.eslintrc.js
+++ b/desktop/.eslintrc.js
@@ -4,7 +4,7 @@ module.exports = {
         "eslint:recommended",
         "plugin:@typescript-eslint/eslint-recommended",
         /* What we really want eventually */
-        // "plugin:@typescript-eslint/strict-type-checked",
+        "plugin:@typescript-eslint/strict-type-checked",
         // "plugin:@typescript-eslint/stylistic-type-checked",
     ],
     plugins: ["@typescript-eslint"],
diff --git a/desktop/src/thirdparty/clip-bpe-ts/mod.ts b/desktop/src/thirdparty/clip-bpe-ts/mod.ts
index b59b762e7c..4d00eef0e4 100644
--- a/desktop/src/thirdparty/clip-bpe-ts/mod.ts
+++ b/desktop/src/thirdparty/clip-bpe-ts/mod.ts
@@ -1,3 +1,5 @@
+/* eslint-disable */
+
 import * as htmlEntities from "html-entities";
 import bpeVocabData from "./bpe_simple_vocab_16e6";
 // import ftfy from "https://deno.land/x/ftfy_pyodide@v0.1.1/mod.js";

From a9671481d8d06139a5118b0ee1f48dfe6ba6b7a4 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 16:10:56 +0530
Subject: [PATCH 20/41] Allow numbers to be used in template literals

---
 desktop/.eslintrc.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/desktop/.eslintrc.js b/desktop/.eslintrc.js
index d9c13a4423..8074990af4 100644
--- a/desktop/.eslintrc.js
+++ b/desktop/.eslintrc.js
@@ -1,5 +1,6 @@
 /* eslint-env node */
 module.exports = {
+    root: true,
     extends: [
         "eslint:recommended",
         "plugin:@typescript-eslint/eslint-recommended",
@@ -12,10 +13,17 @@ module.exports = {
     parserOptions: {
         project: true,
     },
-    root: true,
     ignorePatterns: [".eslintrc.js", "app", "out", "dist"],
     env: {
         es2022: true,
         node: true,
     },
+    rules: {
+        "@typescript-eslint/restrict-template-expressions": [
+            "error",
+            {
+                allowNumber: true,
+            },
+        ],
+    },
 };

From 755ee4a0c24ccd8447820b28d58753e3c0d85673 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 16:13:16 +0530
Subject: [PATCH 21/41] hopefully

---
 desktop/.eslintrc.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/desktop/.eslintrc.js b/desktop/.eslintrc.js
index 8074990af4..541ba33a9c 100644
--- a/desktop/.eslintrc.js
+++ b/desktop/.eslintrc.js
@@ -25,5 +25,10 @@ module.exports = {
                 allowNumber: true,
             },
         ],
+        /* Temporary (RIP) */
+        "@typescript-eslint/no-unsafe-return": "off",
+        "@typescript-eslint/no-confusing-void-expression": "off",
+        "@typescript-eslint/no-misused-promises": "off",
+        "@typescript-eslint/no-floating-promises": "off",
     },
 };

From 994ca4b6a3781ca28524aec4128b2c984b9fe2e4 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 16:25:35 +0530
Subject: [PATCH 22/41] That's why cache fails

---
 desktop/src/main.ts | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/desktop/src/main.ts b/desktop/src/main.ts
index 42c5ab7329..4cd25881f0 100644
--- a/desktop/src/main.ts
+++ b/desktop/src/main.ts
@@ -174,7 +174,7 @@ const createMainWindow = async () => {
     if (isDev) window.webContents.openDevTools();
 
     window.webContents.on("render-process-gone", (_, details) => {
-        log.error(`render-process-gone: ${details}`);
+        log.error(`render-process-gone: ${details.reason}`);
         window.webContents.reload();
     });
 
@@ -302,17 +302,19 @@ const setupTrayItem = (mainWindow: BrowserWindow) => {
  * versions.
  */
 const deleteLegacyDiskCacheDirIfExists = async () => {
-    // The existing code was passing "cache" as a parameter to getPath. This is
-    // incorrect if we go by the types - "cache" is not a valid value for the
-    // parameter to `app.getPath`.
+    // The existing code was passing "cache" as a parameter to getPath.
     //
-    // It might be an issue in the types, since at runtime it seems to work. For
-    // example, on macOS I get `~/Library/Caches`.
+    // However, "cache" is not a valid parameter to getPath. It works! (for
+    // example, on macOS I get `~/Library/Caches`), but it is intentionally not
+    // documented as part of the public API:
+    //
+    // - docs: remove "cache" from app.getPath
+    //   https://github.com/electron/electron/pull/33509
     //
     // Irrespective, we replicate the original behaviour so that we get back the
-    // same path that the old got was getting.
+    // same path that the old code was getting.
     //
-    // @ts-expect-error
+    // @ts-expect-error "cache" works but is not part of the public API.
     const cacheDir = path.join(app.getPath("cache"), "ente");
     if (existsSync(cacheDir)) {
         log.info(`Removing legacy disk cache from ${cacheDir}`);

From 9771db6ade1a6230ffe3290dfa49bf9260edae5c Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 16:28:48 +0530
Subject: [PATCH 23/41] Use the built in transformer

---
 desktop/src/main/stream.ts | 39 ++++++--------------------------------
 1 file changed, 6 insertions(+), 33 deletions(-)

diff --git a/desktop/src/main/stream.ts b/desktop/src/main/stream.ts
index 15715c5500..b97900659f 100644
--- a/desktop/src/main/stream.ts
+++ b/desktop/src/main/stream.ts
@@ -163,39 +163,12 @@ const handleWrite = async (path: string, request: Request) => {
  * The returned promise resolves when the write completes.
  *
  * @param filePath The local filesystem path where the file should be written.
- * @param readableStream A [web
- * ReadableStream](https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream)
+ *
+ * @param readableStream A web
+ * [ReadableStream](https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream).
  */
 export const writeStream = (filePath: string, readableStream: ReadableStream) =>
-    writeNodeStream(filePath, convertWebReadableStreamToNode(readableStream));
-
-/**
- * Convert a Web ReadableStream into a Node.js ReadableStream
- *
- * This can be used to, for example, write a ReadableStream obtained via
- * `net.fetch` into a file using the Node.js `fs` APIs
- */
-const convertWebReadableStreamToNode = (readableStream: ReadableStream) => {
-    const reader = readableStream.getReader();
-    const rs = new Readable();
-
-    rs._read = async () => {
-        try {
-            const result = await reader.read();
-
-            if (!result.done) {
-                rs.push(Buffer.from(result.value));
-            } else {
-                rs.push(null);
-                return;
-            }
-        } catch (e) {
-            rs.emit("error", e);
-        }
-    };
-
-    return rs;
-};
+    writeNodeStream(filePath, Readable.fromWeb(readableStream));
 
 const writeNodeStream = async (filePath: string, fileStream: Readable) => {
     const writeable = createWriteStream(filePath);
@@ -208,11 +181,11 @@ const writeNodeStream = async (filePath: string, fileStream: Readable) => {
 
     await new Promise((resolve, reject) => {
         writeable.on("finish", resolve);
-        writeable.on("error", async (e: unknown) => {
+        writeable.on("error", async (err: Error) => {
             if (existsSync(filePath)) {
                 await fs.unlink(filePath);
             }
-            reject(e);
+            reject(err);
         });
     });
 };

From 01c77c39495a06e8c8c29349aad9717dc1afb8d3 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 16:29:24 +0530
Subject: [PATCH 24/41] unk

---
 desktop/src/main/log.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/desktop/src/main/log.ts b/desktop/src/main/log.ts
index c1902d8ebd..c4d2f3cbbe 100644
--- a/desktop/src/main/log.ts
+++ b/desktop/src/main/log.ts
@@ -65,7 +65,7 @@ const logError_ = (message: string) => {
     if (isDev) console.error(`[error] ${message}`);
 };
 
-const logInfo = (...params: any[]) => {
+const logInfo = (...params: unknown[]) => {
     const message = params
         .map((p) => (typeof p == "string" ? p : util.inspect(p)))
         .join(" ");
@@ -73,7 +73,7 @@ const logInfo = (...params: any[]) => {
     if (isDev) console.log(`[info] ${message}`);
 };
 
-const logDebug = (param: () => any) => {
+const logDebug = (param: () => unknown) => {
     if (isDev) {
         const p = param();
         console.log(`[debug] ${typeof p == "string" ? p : util.inspect(p)}`);

From 9e279da6b3f9a530af8f56fc7e85ebc16c67bf00 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 16:30:19 +0530
Subject: [PATCH 25/41] annotations

---
 desktop/src/main/ipc.ts | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/desktop/src/main/ipc.ts b/desktop/src/main/ipc.ts
index eb8b6cdda8..66cfddabd4 100644
--- a/desktop/src/main/ipc.ts
+++ b/desktop/src/main/ipc.ts
@@ -93,18 +93,20 @@ export const attachIPCHandlers = () => {
 
     ipcMain.handle("appVersion", () => appVersion());
 
-    ipcMain.handle("openDirectory", (_, dirPath) => openDirectory(dirPath));
+    ipcMain.handle("openDirectory", (_, dirPath: string) =>
+        openDirectory(dirPath),
+    );
 
     ipcMain.handle("openLogDirectory", () => openLogDirectory());
 
     // See [Note: Catching exception during .send/.on]
-    ipcMain.on("logToDisk", (_, message) => logToDisk(message));
+    ipcMain.on("logToDisk", (_, message: string) => logToDisk(message));
 
     ipcMain.handle("selectDirectory", () => selectDirectory());
 
     ipcMain.on("clearStores", () => clearStores());
 
-    ipcMain.handle("saveEncryptionKey", (_, encryptionKey) =>
+    ipcMain.handle("saveEncryptionKey", (_, encryptionKey: string) =>
         saveEncryptionKey(encryptionKey),
     );
 
@@ -114,21 +116,23 @@ export const attachIPCHandlers = () => {
 
     ipcMain.on("updateAndRestart", () => updateAndRestart());
 
-    ipcMain.on("updateOnNextRestart", (_, version) =>
+    ipcMain.on("updateOnNextRestart", (_, version: string) =>
         updateOnNextRestart(version),
     );
 
-    ipcMain.on("skipAppUpdate", (_, version) => skipAppUpdate(version));
+    ipcMain.on("skipAppUpdate", (_, version: string) => skipAppUpdate(version));
 
     // - FS
 
-    ipcMain.handle("fsExists", (_, path) => fsExists(path));
+    ipcMain.handle("fsExists", (_, path: string) => fsExists(path));
 
     ipcMain.handle("fsRename", (_, oldPath: string, newPath: string) =>
         fsRename(oldPath, newPath),
     );
 
-    ipcMain.handle("fsMkdirIfNeeded", (_, dirPath) => fsMkdirIfNeeded(dirPath));
+    ipcMain.handle("fsMkdirIfNeeded", (_, dirPath: string) =>
+        fsMkdirIfNeeded(dirPath),
+    );
 
     ipcMain.handle("fsRmdir", (_, path: string) => fsRmdir(path));
 

From 7fb912c9dfd55109c7669d3d90dceb8fb2fb966d Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 16:34:48 +0530
Subject: [PATCH 26/41] ensure

---
 desktop/src/main/utils/temp.ts | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/desktop/src/main/utils/temp.ts b/desktop/src/main/utils/temp.ts
index 09071c1573..b336a902f1 100644
--- a/desktop/src/main/utils/temp.ts
+++ b/desktop/src/main/utils/temp.ts
@@ -4,6 +4,7 @@ import { existsSync } from "node:fs";
 import fs from "node:fs/promises";
 import path from "node:path";
 import type { ZipItem } from "../../types/ipc";
+import { ensure } from "./common";
 
 /**
  * Our very own directory within the system temp directory. Go crazy, but
@@ -17,13 +18,10 @@ const enteTempDirPath = async () => {
 
 /** Generate a random string suitable for being used as a file name prefix */
 const randomPrefix = () => {
-    const alphabet =
-        "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
+    const ch = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
+    const randomChar = () => ensure(ch[Math.floor(Math.random() * ch.length)]);
 
-    let result = "";
-    for (let i = 0; i < 10; i++)
-        result += alphabet[Math.floor(Math.random() * alphabet.length)];
-    return result;
+    return Array(10).fill("").map(randomChar).join("");
 };
 
 /**

From 1076471d51fd27dc07e60e5072d32d37abe3ecc5 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 16:42:52 +0530
Subject: [PATCH 27/41] Turn one off

---
 desktop/src/main/stores/watch.ts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/desktop/src/main/stores/watch.ts b/desktop/src/main/stores/watch.ts
index 7ee383038a..6006c28ac6 100644
--- a/desktop/src/main/stores/watch.ts
+++ b/desktop/src/main/stores/watch.ts
@@ -54,8 +54,11 @@ export const watchStore = new Store({
  */
 export const migrateLegacyWatchStoreIfNeeded = () => {
     let needsUpdate = false;
-    const watches = watchStore.get("mappings")?.map((watch) => {
+    const watches = watchStore.get("mappings").map((watch) => {
         let collectionMapping = watch.collectionMapping;
+        // The required type defines the latest schema, but before migration
+        // this'll be undefined, so tell ESLint to calm down.
+        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
         if (!collectionMapping) {
             collectionMapping = watch.uploadStrategy == 1 ? "parent" : "root";
             needsUpdate = true;

From 46d67f0c49dd77a17a63824e89562998a8f05fb5 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 16:49:56 +0530
Subject: [PATCH 28/41] Disentagle map from modifications

---
 desktop/src/main/services/watch.ts |  4 ++--
 desktop/src/main/stores/watch.ts   | 11 ++++++-----
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/desktop/src/main/services/watch.ts b/desktop/src/main/services/watch.ts
index e8e3803902..ca550a787b 100644
--- a/desktop/src/main/services/watch.ts
+++ b/desktop/src/main/services/watch.ts
@@ -73,7 +73,7 @@ export const watchAdd = async (
 ) => {
     const watches = folderWatches();
 
-    if (!fsIsDir(folderPath))
+    if (!(await fsIsDir(folderPath)))
         throw new Error(
             `Attempting to add a folder watch for a folder path ${folderPath} that is not an existing directory`,
         );
@@ -97,7 +97,7 @@ export const watchAdd = async (
     return watches;
 };
 
-export const watchRemove = async (watcher: FSWatcher, folderPath: string) => {
+export const watchRemove = (watcher: FSWatcher, folderPath: string) => {
     const watches = folderWatches();
     const filtered = watches.filter((watch) => watch.folderPath != folderPath);
     if (watches.length == filtered.length)
diff --git a/desktop/src/main/stores/watch.ts b/desktop/src/main/stores/watch.ts
index 6006c28ac6..59032c9acd 100644
--- a/desktop/src/main/stores/watch.ts
+++ b/desktop/src/main/stores/watch.ts
@@ -3,7 +3,7 @@ import { type FolderWatch } from "../../types/ipc";
 import log from "../log";
 
 interface WatchStore {
-    mappings: FolderWatchWithLegacyFields[];
+    mappings?: FolderWatchWithLegacyFields[];
 }
 
 type FolderWatchWithLegacyFields = FolderWatch & {
@@ -54,7 +54,8 @@ export const watchStore = new Store({
  */
 export const migrateLegacyWatchStoreIfNeeded = () => {
     let needsUpdate = false;
-    const watches = watchStore.get("mappings").map((watch) => {
+    const updatedWatches = [];
+    for (const watch of watchStore.get("mappings") ?? []) {
         let collectionMapping = watch.collectionMapping;
         // The required type defines the latest schema, but before migration
         // this'll be undefined, so tell ESLint to calm down.
@@ -67,10 +68,10 @@ export const migrateLegacyWatchStoreIfNeeded = () => {
             delete watch.rootFolderName;
             needsUpdate = true;
         }
-        return { ...watch, collectionMapping };
-    });
+        updatedWatches.push({ ...watch, collectionMapping });
+    }
     if (needsUpdate) {
-        watchStore.set("mappings", watches);
+        watchStore.set("mappings", updatedWatches);
         log.info("Migrated legacy watch store data to new schema");
     }
 };

From 9cce8b379ca468641d876d384e588ece0b41aed3 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 16:51:19 +0530
Subject: [PATCH 29/41] Remove unnecessary asyncs

---
 desktop/src/main/services/upload.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/desktop/src/main/services/upload.ts b/desktop/src/main/services/upload.ts
index c3efbb9f40..cf96399190 100644
--- a/desktop/src/main/services/upload.ts
+++ b/desktop/src/main/services/upload.ts
@@ -82,16 +82,16 @@ export const pendingUploads = async (): Promise<PendingUploads | undefined> => {
     };
 };
 
-export const setPendingUploads = async (pendingUploads: PendingUploads) =>
+export const setPendingUploads = (pendingUploads: PendingUploads) =>
     uploadStatusStore.set(pendingUploads);
 
-export const markUploadedFiles = async (paths: string[]) => {
+export const markUploadedFiles = (paths: string[]) => {
     const existing = uploadStatusStore.get("filePaths");
     const updated = existing?.filter((p) => !paths.includes(p));
     uploadStatusStore.set("filePaths", updated);
 };
 
-export const markUploadedZipItems = async (
+export const markUploadedZipItems = (
     items: [zipPath: string, entryName: string][],
 ) => {
     const existing = uploadStatusStore.get("zipItems");

From f4660baeb8eff59a6feb8336d07e96656e937a06 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 16:58:58 +0530
Subject: [PATCH 30/41] Remove unnecessary awaits

---
 desktop/src/main/services/store.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/desktop/src/main/services/store.ts b/desktop/src/main/services/store.ts
index 9ec65c8c38..1884efbc5d 100644
--- a/desktop/src/main/services/store.ts
+++ b/desktop/src/main/services/store.ts
@@ -14,15 +14,15 @@ export const clearStores = () => {
     watchStore.clear();
 };
 
-export const saveEncryptionKey = async (encryptionKey: string) => {
-    const encryptedKey: Buffer = await safeStorage.encryptString(encryptionKey);
+export const saveEncryptionKey = (encryptionKey: string) => {
+    const encryptedKey = safeStorage.encryptString(encryptionKey);
     const b64EncryptedKey = Buffer.from(encryptedKey).toString("base64");
     safeStorageStore.set("encryptionKey", b64EncryptedKey);
 };
 
-export const encryptionKey = async (): Promise<string | undefined> => {
+export const encryptionKey = (): string | undefined => {
     const b64EncryptedKey = safeStorageStore.get("encryptionKey");
     if (!b64EncryptedKey) return undefined;
     const keyBuffer = Buffer.from(b64EncryptedKey, "base64");
-    return await safeStorage.decryptString(keyBuffer);
+    return safeStorage.decryptString(keyBuffer);
 };

From d308d334f8c9d53abb7fa6cbdb33e9cc3d77eb8c Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 17:01:24 +0530
Subject: [PATCH 31/41] tt

---
 desktop/src/main.ts                        | 6 +++---
 desktop/src/main/services/auto-launcher.ts | 2 +-
 desktop/src/main/services/ml-clip.ts       | 4 ++--
 desktop/src/main/services/ml-face.ts       | 4 +++-
 4 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/desktop/src/main.ts b/desktop/src/main.ts
index 4cd25881f0..b0c51fb937 100644
--- a/desktop/src/main.ts
+++ b/desktop/src/main.ts
@@ -146,7 +146,7 @@ const registerPrivilegedSchemes = () => {
  *
  * This window will show the HTML served from {@link rendererURL}.
  */
-const createMainWindow = async () => {
+const createMainWindow = () => {
     // Create the main window. This'll show our web content.
     const window = new BrowserWindow({
         webPreferences: {
@@ -160,7 +160,7 @@ const createMainWindow = async () => {
         show: false,
     });
 
-    const wasAutoLaunched = await autoLauncher.wasAutoLaunched();
+    const wasAutoLaunched = autoLauncher.wasAutoLaunched();
     if (wasAutoLaunched) {
         // Don't automatically show the app's window if we were auto-launched.
         // On macOS, also hide the dock icon on macOS.
@@ -367,7 +367,7 @@ const main = () => {
     // Note that some Electron APIs can only be used after this event occurs.
     app.on("ready", async () => {
         // Create window and prepare for the renderer.
-        mainWindow = await createMainWindow();
+        mainWindow = createMainWindow();
         attachIPCHandlers();
         attachFSWatchIPCHandlers(createWatcher(mainWindow));
         registerStreamProtocol();
diff --git a/desktop/src/main/services/auto-launcher.ts b/desktop/src/main/services/auto-launcher.ts
index c704f73999..4e97a02257 100644
--- a/desktop/src/main/services/auto-launcher.ts
+++ b/desktop/src/main/services/auto-launcher.ts
@@ -38,7 +38,7 @@ class AutoLauncher {
         }
     }
 
-    async wasAutoLaunched() {
+    wasAutoLaunched() {
         if (this.autoLaunch) {
             return app.commandLine.hasSwitch("hidden");
         } else {
diff --git a/desktop/src/main/services/ml-clip.ts b/desktop/src/main/services/ml-clip.ts
index 451cdcb09b..ddbfb0881d 100644
--- a/desktop/src/main/services/ml-clip.ts
+++ b/desktop/src/main/services/ml-clip.ts
@@ -49,7 +49,7 @@ const clipImageEmbedding_ = async (jpegFilePath: string) => {
     return normalizeEmbedding(imageEmbedding);
 };
 
-const getRGBData = async (jpegFilePath: string) => {
+const getRGBData = async (jpegFilePath: string): Promise<number[]> => {
     const jpegData = await fs.readFile(jpegFilePath);
     const rawImageData = jpeg.decode(jpegData, {
         useTArray: true,
@@ -64,7 +64,7 @@ const getRGBData = async (jpegFilePath: string) => {
     const ny2 = 224;
     const totalSize = 3 * nx2 * ny2;
 
-    const result: number[] = Array(totalSize).fill(0);
+    const result = Array(totalSize).fill(0);
     const scale = Math.max(nx, ny) / 224;
 
     const nx3 = Math.round(nx / scale);
diff --git a/desktop/src/main/services/ml-face.ts b/desktop/src/main/services/ml-face.ts
index e4e43a4b0e..e72f043e06 100644
--- a/desktop/src/main/services/ml-face.ts
+++ b/desktop/src/main/services/ml-face.ts
@@ -47,5 +47,7 @@ export const faceEmbedding = async (input: Float32Array) => {
     const results = await session.run(feeds);
     log.debug(() => `onnx/yolo face embedding took ${Date.now() - t} ms`);
     /* Need these model specific casts to extract and type the result */
-    return (results.embeddings as unknown as any)["cpuData"] as Float32Array;
+    return (results.embeddings as unknown as Record<string, unknown>)[
+        "cpuData"
+    ] as Float32Array;
 };

From 82316ff290f41db23ba380b8c3d67f72a8aa9d74 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 17:43:30 +0530
Subject: [PATCH 32/41] Unawaited promises

---
 desktop/.eslintrc.js                | 2 +-
 desktop/src/main/menu.ts            | 2 +-
 desktop/src/main/services/upload.ts | 4 ++--
 desktop/src/main/utils/temp.ts      | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/desktop/.eslintrc.js b/desktop/.eslintrc.js
index 541ba33a9c..daf2c2838e 100644
--- a/desktop/.eslintrc.js
+++ b/desktop/.eslintrc.js
@@ -29,6 +29,6 @@ module.exports = {
         "@typescript-eslint/no-unsafe-return": "off",
         "@typescript-eslint/no-confusing-void-expression": "off",
         "@typescript-eslint/no-misused-promises": "off",
-        "@typescript-eslint/no-floating-promises": "off",
+        // "@typescript-eslint/no-floating-promises": "off",
     },
 };
diff --git a/desktop/src/main/menu.ts b/desktop/src/main/menu.ts
index 0693c01dc0..5dd2b335ef 100644
--- a/desktop/src/main/menu.ts
+++ b/desktop/src/main/menu.ts
@@ -35,7 +35,7 @@ export const createApplicationMenu = async (mainWindow: BrowserWindow) => {
         );
 
     const toggleAutoLaunch = () => {
-        autoLauncher.toggleAutoLaunch();
+        void autoLauncher.toggleAutoLaunch();
         isAutoLaunchEnabled = !isAutoLaunchEnabled;
     };
 
diff --git a/desktop/src/main/services/upload.ts b/desktop/src/main/services/upload.ts
index cf96399190..96835bfb00 100644
--- a/desktop/src/main/services/upload.ts
+++ b/desktop/src/main/services/upload.ts
@@ -20,7 +20,7 @@ export const listZipItems = async (zipPath: string): Promise<ZipItem[]> => {
         }
     }
 
-    zip.close();
+    await zip.close();
 
     return entryNames.map((entryName) => [zipPath, entryName]);
 };
@@ -40,7 +40,7 @@ export const pathOrZipItemSize = async (
                 `An entry with name ${entryName} does not exist in the zip file at ${zipPath}`,
             );
         const size = entry.size;
-        zip.close();
+        await zip.close();
         return size;
     }
 };
diff --git a/desktop/src/main/utils/temp.ts b/desktop/src/main/utils/temp.ts
index b336a902f1..582f0a2b3d 100644
--- a/desktop/src/main/utils/temp.ts
+++ b/desktop/src/main/utils/temp.ts
@@ -114,7 +114,7 @@ export const makeFileForDataOrPathOrZipItem = async (
                 const [zipPath, entryName] = dataOrPathOrZipItem;
                 const zip = new StreamZip.async({ file: zipPath });
                 await zip.extract(entryName, path);
-                zip.close();
+                await zip.close();
             };
         }
     }

From bda52267967427e7fb73c7614d16a59811293af7 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 18:32:34 +0530
Subject: [PATCH 33/41] More unawaited

---
 desktop/src/main.ts                     | 12 ++++++------
 desktop/src/main/services/app-update.ts |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/desktop/src/main.ts b/desktop/src/main.ts
index b0c51fb937..f5ad891588 100644
--- a/desktop/src/main.ts
+++ b/desktop/src/main.ts
@@ -202,8 +202,8 @@ const createMainWindow = () => {
             app.dock.hide();
     });
 
-    window.on("show", () => {
-        if (process.platform == "darwin") app.dock.show();
+    window.on("show", async () => {
+        if (process.platform == "darwin") await app.dock.show();
     });
 
     // Let ipcRenderer know when mainWindow is in the foreground so that it can
@@ -257,7 +257,7 @@ export const allowExternalLinks = (webContents: WebContents) => {
     // Returning `action` "deny" accomplishes this.
     webContents.setWindowOpenHandler(({ url }) => {
         if (!url.startsWith(rendererURL)) {
-            shell.openExternal(url);
+            void shell.openExternal(url);
             return { action: "deny" };
         } else {
             return { action: "allow" };
@@ -377,7 +377,7 @@ const main = () => {
         allowExternalLinks(mainWindow.webContents);
 
         // Start loading the renderer.
-        mainWindow.loadURL(rendererURL);
+        void mainWindow.loadURL(rendererURL);
 
         // Continue on with the rest of the startup sequence.
         Menu.setApplicationMenu(await createApplicationMenu(mainWindow));
@@ -385,8 +385,8 @@ const main = () => {
         if (!isDev) setupAutoUpdater(mainWindow);
 
         try {
-            deleteLegacyDiskCacheDirIfExists();
-            deleteLegacyKeysStoreIfExists();
+            await deleteLegacyDiskCacheDirIfExists();
+            await deleteLegacyKeysStoreIfExists();
         } catch (e) {
             // Log but otherwise ignore errors during non-critical startup
             // actions.
diff --git a/desktop/src/main/services/app-update.ts b/desktop/src/main/services/app-update.ts
index e20d42fb70..a9e3109342 100644
--- a/desktop/src/main/services/app-update.ts
+++ b/desktop/src/main/services/app-update.ts
@@ -13,7 +13,7 @@ export const setupAutoUpdater = (mainWindow: BrowserWindow) => {
 
     const oneDay = 1 * 24 * 60 * 60 * 1000;
     setInterval(() => checkForUpdatesAndNotify(mainWindow), oneDay);
-    checkForUpdatesAndNotify(mainWindow);
+    void checkForUpdatesAndNotify(mainWindow);
 };
 
 /**
@@ -22,7 +22,7 @@ export const setupAutoUpdater = (mainWindow: BrowserWindow) => {
 export const forceCheckForAppUpdates = (mainWindow: BrowserWindow) => {
     userPreferences.delete("skipAppVersion");
     userPreferences.delete("muteUpdateNotificationVersion");
-    checkForUpdatesAndNotify(mainWindow);
+    void checkForUpdatesAndNotify(mainWindow);
 };
 
 const checkForUpdatesAndNotify = async (mainWindow: BrowserWindow) => {
@@ -56,7 +56,7 @@ const checkForUpdatesAndNotify = async (mainWindow: BrowserWindow) => {
         mainWindow.webContents.send("appUpdateAvailable", update);
 
     log.debug(() => "Attempting auto update");
-    autoUpdater.downloadUpdate();
+    await autoUpdater.downloadUpdate();
 
     let timeoutId: ReturnType<typeof setTimeout>;
     const fiveMinutes = 5 * 60 * 1000;

From 9a281725652ebf96120e71d0426ec938d6deb613 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 18:37:50 +0530
Subject: [PATCH 34/41] iife wrapper

---
 desktop/.eslintrc.js |  2 +-
 desktop/src/main.ts  | 52 +++++++++++++++++++++++---------------------
 2 files changed, 28 insertions(+), 26 deletions(-)

diff --git a/desktop/.eslintrc.js b/desktop/.eslintrc.js
index daf2c2838e..8c1867fc79 100644
--- a/desktop/.eslintrc.js
+++ b/desktop/.eslintrc.js
@@ -28,7 +28,7 @@ module.exports = {
         /* Temporary (RIP) */
         "@typescript-eslint/no-unsafe-return": "off",
         "@typescript-eslint/no-confusing-void-expression": "off",
-        "@typescript-eslint/no-misused-promises": "off",
+        // "@typescript-eslint/no-misused-promises": "off",
         // "@typescript-eslint/no-floating-promises": "off",
     },
 };
diff --git a/desktop/src/main.ts b/desktop/src/main.ts
index f5ad891588..c849c755f7 100644
--- a/desktop/src/main.ts
+++ b/desktop/src/main.ts
@@ -202,8 +202,8 @@ const createMainWindow = () => {
             app.dock.hide();
     });
 
-    window.on("show", async () => {
-        if (process.platform == "darwin") await app.dock.show();
+    window.on("show", () => {
+        if (process.platform == "darwin") void app.dock.show();
     });
 
     // Let ipcRenderer know when mainWindow is in the foreground so that it can
@@ -365,33 +365,35 @@ const main = () => {
     // Emitted once, when Electron has finished initializing.
     //
     // Note that some Electron APIs can only be used after this event occurs.
-    app.on("ready", async () => {
-        // Create window and prepare for the renderer.
-        mainWindow = createMainWindow();
-        attachIPCHandlers();
-        attachFSWatchIPCHandlers(createWatcher(mainWindow));
-        registerStreamProtocol();
+    app.on("ready", () => {
+        void (async () => {
+            // Create window and prepare for the renderer.
+            mainWindow = createMainWindow();
+            attachIPCHandlers();
+            attachFSWatchIPCHandlers(createWatcher(mainWindow));
+            registerStreamProtocol();
 
-        // Configure the renderer's environment.
-        setDownloadPath(mainWindow.webContents);
-        allowExternalLinks(mainWindow.webContents);
+            // Configure the renderer's environment.
+            setDownloadPath(mainWindow.webContents);
+            allowExternalLinks(mainWindow.webContents);
 
-        // Start loading the renderer.
-        void mainWindow.loadURL(rendererURL);
+            // Start loading the renderer.
+            void mainWindow.loadURL(rendererURL);
 
-        // Continue on with the rest of the startup sequence.
-        Menu.setApplicationMenu(await createApplicationMenu(mainWindow));
-        setupTrayItem(mainWindow);
-        if (!isDev) setupAutoUpdater(mainWindow);
+            // Continue on with the rest of the startup sequence.
+            Menu.setApplicationMenu(await createApplicationMenu(mainWindow));
+            setupTrayItem(mainWindow);
+            if (!isDev) setupAutoUpdater(mainWindow);
 
-        try {
-            await deleteLegacyDiskCacheDirIfExists();
-            await deleteLegacyKeysStoreIfExists();
-        } catch (e) {
-            // Log but otherwise ignore errors during non-critical startup
-            // actions.
-            log.error("Ignoring startup error", e);
-        }
+            try {
+                await deleteLegacyDiskCacheDirIfExists();
+                await deleteLegacyKeysStoreIfExists();
+            } catch (e) {
+                // Log but otherwise ignore errors during non-critical startup
+                // actions.
+                log.error("Ignoring startup error", e);
+            }
+        })();
     });
 
     // This is a macOS only event. Show our window when the user activates the

From 7b16fa9f38cc4dcfe64d3c88769d2d3058c57498 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 18:39:18 +0530
Subject: [PATCH 35/41] void

---
 desktop/src/main/menu.ts                | 12 +++++++-----
 desktop/src/main/services/app-update.ts |  2 +-
 desktop/src/main/stream.ts              | 10 +++++-----
 3 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/desktop/src/main/menu.ts b/desktop/src/main/menu.ts
index 5dd2b335ef..1019c7a8fb 100644
--- a/desktop/src/main/menu.ts
+++ b/desktop/src/main/menu.ts
@@ -30,7 +30,7 @@ export const createApplicationMenu = async (mainWindow: BrowserWindow) => {
     const handleCheckForUpdates = () => forceCheckForAppUpdates(mainWindow);
 
     const handleViewChangelog = () =>
-        shell.openExternal(
+        void shell.openExternal(
             "https://github.com/ente-io/ente/blob/main/desktop/CHANGELOG.md",
         );
 
@@ -46,13 +46,15 @@ export const createApplicationMenu = async (mainWindow: BrowserWindow) => {
         shouldHideDockIcon = !shouldHideDockIcon;
     };
 
-    const handleHelp = () => shell.openExternal("https://help.ente.io/photos/");
+    const handleHelp = () =>
+        void shell.openExternal("https://help.ente.io/photos/");
 
-    const handleSupport = () => shell.openExternal("mailto:support@ente.io");
+    const handleSupport = () =>
+        void shell.openExternal("mailto:support@ente.io");
 
-    const handleBlog = () => shell.openExternal("https://ente.io/blog/");
+    const handleBlog = () => void shell.openExternal("https://ente.io/blog/");
 
-    const handleViewLogs = openLogDirectory;
+    const handleViewLogs = () => void openLogDirectory();
 
     return Menu.buildFromTemplate([
         {
diff --git a/desktop/src/main/services/app-update.ts b/desktop/src/main/services/app-update.ts
index a9e3109342..bc4bd38d6d 100644
--- a/desktop/src/main/services/app-update.ts
+++ b/desktop/src/main/services/app-update.ts
@@ -12,7 +12,7 @@ export const setupAutoUpdater = (mainWindow: BrowserWindow) => {
     autoUpdater.autoDownload = false;
 
     const oneDay = 1 * 24 * 60 * 60 * 1000;
-    setInterval(() => checkForUpdatesAndNotify(mainWindow), oneDay);
+    setInterval(() => void checkForUpdatesAndNotify(mainWindow), oneDay);
     void checkForUpdatesAndNotify(mainWindow);
 };
 
diff --git a/desktop/src/main/stream.ts b/desktop/src/main/stream.ts
index b97900659f..3e27de12b4 100644
--- a/desktop/src/main/stream.ts
+++ b/desktop/src/main/stream.ts
@@ -117,7 +117,7 @@ const handleReadZip = async (zipPath: string, entryName: string) => {
 
         // Close the zip handle when the underlying stream closes.
         // TODO(MR): Verify
-        stream.on("end", () => zip.close());
+        stream.on("end", () => void zip.close());
 
         return new Response(webReadableStream, {
             headers: {
@@ -173,17 +173,17 @@ export const writeStream = (filePath: string, readableStream: ReadableStream) =>
 const writeNodeStream = async (filePath: string, fileStream: Readable) => {
     const writeable = createWriteStream(filePath);
 
-    fileStream.on("error", (error) => {
-        writeable.destroy(error); // Close the writable stream with an error
+    fileStream.on("error", (err) => {
+        writeable.destroy(err); // Close the writable stream with an error
     });
 
     fileStream.pipe(writeable);
 
     await new Promise((resolve, reject) => {
         writeable.on("finish", resolve);
-        writeable.on("error", async (err: Error) => {
+        writeable.on("error", (err) => {
             if (existsSync(filePath)) {
-                await fs.unlink(filePath);
+                void fs.unlink(filePath);
             }
             reject(err);
         });

From 7e2ee61a97dc612d88a89b4e993d5500b9de6de9 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 18:46:13 +0530
Subject: [PATCH 36/41] void expressions are fine

---
 desktop/.eslintrc.js | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/desktop/.eslintrc.js b/desktop/.eslintrc.js
index 8c1867fc79..33c458b14c 100644
--- a/desktop/.eslintrc.js
+++ b/desktop/.eslintrc.js
@@ -4,8 +4,8 @@ module.exports = {
     extends: [
         "eslint:recommended",
         "plugin:@typescript-eslint/eslint-recommended",
-        /* What we really want eventually */
         "plugin:@typescript-eslint/strict-type-checked",
+        /* What we really want eventually */
         // "plugin:@typescript-eslint/stylistic-type-checked",
     ],
     plugins: ["@typescript-eslint"],
@@ -19,16 +19,21 @@ module.exports = {
         node: true,
     },
     rules: {
+        /* Allow numbers to be used in template literals */
         "@typescript-eslint/restrict-template-expressions": [
             "error",
             {
                 allowNumber: true,
             },
         ],
+        /* Allow void expressions as the entire body of an arrow function */
+        "@typescript-eslint/no-confusing-void-expression": [
+            "error",
+            {
+                ignoreArrowShorthand: true,
+            },
+        ],
         /* Temporary (RIP) */
         "@typescript-eslint/no-unsafe-return": "off",
-        "@typescript-eslint/no-confusing-void-expression": "off",
-        // "@typescript-eslint/no-misused-promises": "off",
-        // "@typescript-eslint/no-floating-promises": "off",
     },
 };

From 76c98bdf326865e66c411415b7a78ddb465f6ac6 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 18:50:15 +0530
Subject: [PATCH 37/41] handle unsafe returns

---
 desktop/.eslintrc.js                 |  2 -
 desktop/src/main/services/ml-clip.ts |  2 +-
 desktop/src/preload.ts               | 86 +++++++++++-----------------
 3 files changed, 36 insertions(+), 54 deletions(-)

diff --git a/desktop/.eslintrc.js b/desktop/.eslintrc.js
index 33c458b14c..ed16db5264 100644
--- a/desktop/.eslintrc.js
+++ b/desktop/.eslintrc.js
@@ -33,7 +33,5 @@ module.exports = {
                 ignoreArrowShorthand: true,
             },
         ],
-        /* Temporary (RIP) */
-        "@typescript-eslint/no-unsafe-return": "off",
     },
 };
diff --git a/desktop/src/main/services/ml-clip.ts b/desktop/src/main/services/ml-clip.ts
index ddbfb0881d..c9378edf29 100644
--- a/desktop/src/main/services/ml-clip.ts
+++ b/desktop/src/main/services/ml-clip.ts
@@ -64,7 +64,7 @@ const getRGBData = async (jpegFilePath: string): Promise<number[]> => {
     const ny2 = 224;
     const totalSize = 3 * nx2 * ny2;
 
-    const result = Array(totalSize).fill(0);
+    const result = Array<number>(totalSize).fill(0);
     const scale = Math.max(nx, ny) / 224;
 
     const nx3 = Math.round(nx / scale);
diff --git a/desktop/src/preload.ts b/desktop/src/preload.ts
index ecc800db3c..2b5eb8fcc3 100644
--- a/desktop/src/preload.ts
+++ b/desktop/src/preload.ts
@@ -51,26 +51,23 @@ import type {
 
 // - General
 
-const appVersion = (): Promise<string> => ipcRenderer.invoke("appVersion");
+const appVersion = () => ipcRenderer.invoke("appVersion");
 
 const logToDisk = (message: string): void =>
     ipcRenderer.send("logToDisk", message);
 
-const openDirectory = (dirPath: string): Promise<void> =>
+const openDirectory = (dirPath: string) =>
     ipcRenderer.invoke("openDirectory", dirPath);
 
-const openLogDirectory = (): Promise<void> =>
-    ipcRenderer.invoke("openLogDirectory");
+const openLogDirectory = () => ipcRenderer.invoke("openLogDirectory");
 
-const selectDirectory = (): Promise<string | undefined> =>
-    ipcRenderer.invoke("selectDirectory");
+const selectDirectory = () => ipcRenderer.invoke("selectDirectory");
 
 const clearStores = () => ipcRenderer.send("clearStores");
 
-const encryptionKey = (): Promise<string | undefined> =>
-    ipcRenderer.invoke("encryptionKey");
+const encryptionKey = () => ipcRenderer.invoke("encryptionKey");
 
-const saveEncryptionKey = (encryptionKey: string): Promise<void> =>
+const saveEncryptionKey = (encryptionKey: string) =>
     ipcRenderer.invoke("saveEncryptionKey", encryptionKey);
 
 const onMainWindowFocus = (cb?: () => void) => {
@@ -102,39 +99,36 @@ const skipAppUpdate = (version: string) => {
 
 // - FS
 
-const fsExists = (path: string): Promise<boolean> =>
-    ipcRenderer.invoke("fsExists", path);
+const fsExists = (path: string) => ipcRenderer.invoke("fsExists", path);
 
-const fsMkdirIfNeeded = (dirPath: string): Promise<void> =>
+const fsMkdirIfNeeded = (dirPath: string) =>
     ipcRenderer.invoke("fsMkdirIfNeeded", dirPath);
 
-const fsRename = (oldPath: string, newPath: string): Promise<void> =>
+const fsRename = (oldPath: string, newPath: string) =>
     ipcRenderer.invoke("fsRename", oldPath, newPath);
 
-const fsRmdir = (path: string): Promise<void> =>
-    ipcRenderer.invoke("fsRmdir", path);
+const fsRmdir = (path: string) => ipcRenderer.invoke("fsRmdir", path);
 
-const fsRm = (path: string): Promise<void> => ipcRenderer.invoke("fsRm", path);
+const fsRm = (path: string) => ipcRenderer.invoke("fsRm", path);
 
-const fsReadTextFile = (path: string): Promise<string> =>
+const fsReadTextFile = (path: string) =>
     ipcRenderer.invoke("fsReadTextFile", path);
 
-const fsWriteFile = (path: string, contents: string): Promise<void> =>
+const fsWriteFile = (path: string, contents: string) =>
     ipcRenderer.invoke("fsWriteFile", path, contents);
 
-const fsIsDir = (dirPath: string): Promise<boolean> =>
-    ipcRenderer.invoke("fsIsDir", dirPath);
+const fsIsDir = (dirPath: string) => ipcRenderer.invoke("fsIsDir", dirPath);
 
 // - Conversion
 
-const convertToJPEG = (imageData: Uint8Array): Promise<Uint8Array> =>
+const convertToJPEG = (imageData: Uint8Array) =>
     ipcRenderer.invoke("convertToJPEG", imageData);
 
 const generateImageThumbnail = (
     dataOrPathOrZipItem: Uint8Array | string | ZipItem,
     maxDimension: number,
     maxSize: number,
-): Promise<Uint8Array> =>
+) =>
     ipcRenderer.invoke(
         "generateImageThumbnail",
         dataOrPathOrZipItem,
@@ -147,7 +141,7 @@ const ffmpegExec = (
     dataOrPathOrZipItem: Uint8Array | string | ZipItem,
     outputFileExtension: string,
     timeoutMS: number,
-): Promise<Uint8Array> =>
+) =>
     ipcRenderer.invoke(
         "ffmpegExec",
         command,
@@ -158,44 +152,37 @@ const ffmpegExec = (
 
 // - ML
 
-const clipImageEmbedding = (jpegImageData: Uint8Array): Promise<Float32Array> =>
+const clipImageEmbedding = (jpegImageData: Uint8Array) =>
     ipcRenderer.invoke("clipImageEmbedding", jpegImageData);
 
-const clipTextEmbeddingIfAvailable = (
-    text: string,
-): Promise<Float32Array | undefined> =>
+const clipTextEmbeddingIfAvailable = (text: string) =>
     ipcRenderer.invoke("clipTextEmbeddingIfAvailable", text);
 
-const detectFaces = (input: Float32Array): Promise<Float32Array> =>
+const detectFaces = (input: Float32Array) =>
     ipcRenderer.invoke("detectFaces", input);
 
-const faceEmbedding = (input: Float32Array): Promise<Float32Array> =>
+const faceEmbedding = (input: Float32Array) =>
     ipcRenderer.invoke("faceEmbedding", input);
 
 // - Watch
 
-const watchGet = (): Promise<FolderWatch[]> => ipcRenderer.invoke("watchGet");
+const watchGet = () => ipcRenderer.invoke("watchGet");
 
-const watchAdd = (
-    folderPath: string,
-    collectionMapping: CollectionMapping,
-): Promise<FolderWatch[]> =>
+const watchAdd = (folderPath: string, collectionMapping: CollectionMapping) =>
     ipcRenderer.invoke("watchAdd", folderPath, collectionMapping);
 
-const watchRemove = (folderPath: string): Promise<FolderWatch[]> =>
+const watchRemove = (folderPath: string) =>
     ipcRenderer.invoke("watchRemove", folderPath);
 
 const watchUpdateSyncedFiles = (
     syncedFiles: FolderWatch["syncedFiles"],
     folderPath: string,
-): Promise<void> =>
-    ipcRenderer.invoke("watchUpdateSyncedFiles", syncedFiles, folderPath);
+) => ipcRenderer.invoke("watchUpdateSyncedFiles", syncedFiles, folderPath);
 
 const watchUpdateIgnoredFiles = (
     ignoredFiles: FolderWatch["ignoredFiles"],
     folderPath: string,
-): Promise<void> =>
-    ipcRenderer.invoke("watchUpdateIgnoredFiles", ignoredFiles, folderPath);
+) => ipcRenderer.invoke("watchUpdateIgnoredFiles", ignoredFiles, folderPath);
 
 const watchOnAddFile = (f: (path: string, watch: FolderWatch) => void) => {
     ipcRenderer.removeAllListeners("watchAddFile");
@@ -218,34 +205,31 @@ const watchOnRemoveDir = (f: (path: string, watch: FolderWatch) => void) => {
     );
 };
 
-const watchFindFiles = (folderPath: string): Promise<string[]> =>
+const watchFindFiles = (folderPath: string) =>
     ipcRenderer.invoke("watchFindFiles", folderPath);
 
 // - Upload
 
 const pathForFile = (file: File) => webUtils.getPathForFile(file);
 
-const listZipItems = (zipPath: string): Promise<ZipItem[]> =>
+const listZipItems = (zipPath: string) =>
     ipcRenderer.invoke("listZipItems", zipPath);
 
-const pathOrZipItemSize = (pathOrZipItem: string | ZipItem): Promise<number> =>
+const pathOrZipItemSize = (pathOrZipItem: string | ZipItem) =>
     ipcRenderer.invoke("pathOrZipItemSize", pathOrZipItem);
 
-const pendingUploads = (): Promise<PendingUploads | undefined> =>
-    ipcRenderer.invoke("pendingUploads");
+const pendingUploads = () => ipcRenderer.invoke("pendingUploads");
 
-const setPendingUploads = (pendingUploads: PendingUploads): Promise<void> =>
+const setPendingUploads = (pendingUploads: PendingUploads) =>
     ipcRenderer.invoke("setPendingUploads", pendingUploads);
 
-const markUploadedFiles = (paths: PendingUploads["filePaths"]): Promise<void> =>
+const markUploadedFiles = (paths: PendingUploads["filePaths"]) =>
     ipcRenderer.invoke("markUploadedFiles", paths);
 
-const markUploadedZipItems = (
-    items: PendingUploads["zipItems"],
-): Promise<void> => ipcRenderer.invoke("markUploadedZipItems", items);
+const markUploadedZipItems = (items: PendingUploads["zipItems"]) =>
+    ipcRenderer.invoke("markUploadedZipItems", items);
 
-const clearPendingUploads = (): Promise<void> =>
-    ipcRenderer.invoke("clearPendingUploads");
+const clearPendingUploads = () => ipcRenderer.invoke("clearPendingUploads");
 
 /**
  * These objects exposed here will become available to the JS code in our

From 50a14470202512df6d72eea2104a19da7f69fa0f Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 18:53:17 +0530
Subject: [PATCH 38/41] Stylistic

---
 desktop/.eslintrc.js                 |  3 +--
 desktop/src/main/services/ml-clip.ts | 13 ++++++-------
 desktop/src/main/services/ml-face.ts |  7 +++----
 desktop/src/main/services/upload.ts  |  2 +-
 desktop/src/main/utils/temp.ts       |  4 +++-
 5 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/desktop/.eslintrc.js b/desktop/.eslintrc.js
index ed16db5264..44d03ef0c1 100644
--- a/desktop/.eslintrc.js
+++ b/desktop/.eslintrc.js
@@ -5,8 +5,7 @@ module.exports = {
         "eslint:recommended",
         "plugin:@typescript-eslint/eslint-recommended",
         "plugin:@typescript-eslint/strict-type-checked",
-        /* What we really want eventually */
-        // "plugin:@typescript-eslint/stylistic-type-checked",
+        "plugin:@typescript-eslint/stylistic-type-checked",
     ],
     plugins: ["@typescript-eslint"],
     parser: "@typescript-eslint/parser",
diff --git a/desktop/src/main/services/ml-clip.ts b/desktop/src/main/services/ml-clip.ts
index c9378edf29..e3dd99204a 100644
--- a/desktop/src/main/services/ml-clip.ts
+++ b/desktop/src/main/services/ml-clip.ts
@@ -45,7 +45,7 @@ const clipImageEmbedding_ = async (jpegFilePath: string) => {
             `onnx/clip image embedding took ${Date.now() - t1} ms (prep: ${t2 - t1} ms, inference: ${Date.now() - t2} ms)`,
     );
     /* Need these model specific casts to type the result */
-    const imageEmbedding = ensure(results["output"]).data as Float32Array;
+    const imageEmbedding = ensure(results.output).data as Float32Array;
     return normalizeEmbedding(imageEmbedding);
 };
 
@@ -120,13 +120,12 @@ const getRGBData = async (jpegFilePath: string): Promise<number[]> => {
 
 const normalizeEmbedding = (embedding: Float32Array) => {
     let normalization = 0;
-    for (let index = 0; index < embedding.length; index++) {
-        normalization += ensure(embedding[index]) * ensure(embedding[index]);
-    }
+    for (const v of embedding) normalization += v * v;
+
     const sqrtNormalization = Math.sqrt(normalization);
-    for (let index = 0; index < embedding.length; index++) {
+    for (let index = 0; index < embedding.length; index++)
         embedding[index] = ensure(embedding[index]) / sqrtNormalization;
-    }
+
     return embedding;
 };
 
@@ -168,6 +167,6 @@ export const clipTextEmbeddingIfAvailable = async (text: string) => {
         () =>
             `onnx/clip text embedding took ${Date.now() - t1} ms (prep: ${t2 - t1} ms, inference: ${Date.now() - t2} ms)`,
     );
-    const textEmbedding = ensure(results["output"]).data as Float32Array;
+    const textEmbedding = ensure(results.output).data as Float32Array;
     return normalizeEmbedding(textEmbedding);
 };
diff --git a/desktop/src/main/services/ml-face.ts b/desktop/src/main/services/ml-face.ts
index e72f043e06..9765252555 100644
--- a/desktop/src/main/services/ml-face.ts
+++ b/desktop/src/main/services/ml-face.ts
@@ -24,7 +24,7 @@ export const detectFaces = async (input: Float32Array) => {
     };
     const results = await session.run(feeds);
     log.debug(() => `onnx/yolo face detection took ${Date.now() - t} ms`);
-    return ensure(results["output"]).data;
+    return ensure(results.output).data;
 };
 
 const cachedFaceEmbeddingSession = makeCachedInferenceSession(
@@ -47,7 +47,6 @@ export const faceEmbedding = async (input: Float32Array) => {
     const results = await session.run(feeds);
     log.debug(() => `onnx/yolo face embedding took ${Date.now() - t} ms`);
     /* Need these model specific casts to extract and type the result */
-    return (results.embeddings as unknown as Record<string, unknown>)[
-        "cpuData"
-    ] as Float32Array;
+    return (results.embeddings as unknown as Record<string, unknown>)
+        .cpuData as Float32Array;
 };
diff --git a/desktop/src/main/services/upload.ts b/desktop/src/main/services/upload.ts
index 96835bfb00..7871b56fda 100644
--- a/desktop/src/main/services/upload.ts
+++ b/desktop/src/main/services/upload.ts
@@ -14,7 +14,7 @@ export const listZipItems = async (zipPath: string): Promise<ZipItem[]> => {
     for (const entry of Object.values(entries)) {
         const basename = path.basename(entry.name);
         // Ignore "hidden" files (files whose names begins with a dot).
-        if (entry.isFile && basename.length > 0 && basename[0] != ".") {
+        if (entry.isFile && basename.startsWith(".")) {
             // `entry.name` is the path within the zip.
             entryNames.push(entry.name);
         }
diff --git a/desktop/src/main/utils/temp.ts b/desktop/src/main/utils/temp.ts
index 582f0a2b3d..11f7a5d845 100644
--- a/desktop/src/main/utils/temp.ts
+++ b/desktop/src/main/utils/temp.ts
@@ -98,7 +98,9 @@ export const makeFileForDataOrPathOrZipItem = async (
 ): Promise<FileForDataOrPathOrZipItem> => {
     let path: string;
     let isFileTemporary: boolean;
-    let writeToTemporaryFile = async () => {};
+    let writeToTemporaryFile = async () => {
+        /* no-op */
+    };
 
     if (typeof dataOrPathOrZipItem == "string") {
         path = dataOrPathOrZipItem;

From 1eff04fe92bd670708aaa7b70ada9e81458718d6 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 18:57:19 +0530
Subject: [PATCH 39/41] Enable lints

---
 .github/workflows/desktop-lint.yml | 30 ++++++++++++++++++++++++++++++
 desktop/package.json               |  4 ++--
 2 files changed, 32 insertions(+), 2 deletions(-)
 create mode 100644 .github/workflows/desktop-lint.yml

diff --git a/.github/workflows/desktop-lint.yml b/.github/workflows/desktop-lint.yml
new file mode 100644
index 0000000000..0b8263f3d3
--- /dev/null
+++ b/.github/workflows/desktop-lint.yml
@@ -0,0 +1,30 @@
+name: "Lint (desktop)"
+
+on:
+    # Run on every push to a branch other than main that changes desktop/
+    push:
+        branches-ignore: [main, "deploy/**"]
+        paths:
+            - "desktop/**"
+            - ".github/workflows/desktop-lint.yml"
+
+jobs:
+    lint:
+        runs-on: ubuntu-latest
+        defaults:
+            run:
+                working-directory: desktop
+        steps:
+            - name: Checkout code
+              uses: actions/checkout@v4
+
+            - name: Setup node and enable yarn caching
+              uses: actions/setup-node@v4
+              with:
+                  node-version: 20
+                  cache: "yarn"
+                  cache-dependency-path: "desktop/yarn.lock"
+
+            - run: yarn install
+
+            - run: yarn lint
diff --git a/desktop/package.json b/desktop/package.json
index 509ee85838..d4c571cad7 100644
--- a/desktop/package.json
+++ b/desktop/package.json
@@ -15,8 +15,8 @@
         "dev-main": "tsc && electron app/main.js",
         "dev-renderer": "cd ../web && yarn install && yarn dev:photos",
         "postinstall": "electron-builder install-app-deps",
-        "lint": "yarn prettier --check . && eslint --ext .ts src",
-        "lint-fix": "yarn prettier --write . && eslint --fix --ext .ts src"
+        "lint": "yarn prettier --check . && eslint --ext .ts src && yarn tsc",
+        "lint-fix": "yarn prettier --write . && eslint --fix --ext .ts src && yarn tsc"
     },
     "dependencies": {
         "any-shell-escape": "^0.1",

From 54e8d64b9e0ad4ac6d80bd925e012da9686a0ecf Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 22:46:04 +0530
Subject: [PATCH 40/41] Fix the loading of utils/index

Naming it index doesn't cause isDev to be loaded.
---
 desktop/src/main.ts                              | 2 +-
 desktop/src/main/log.ts                          | 2 +-
 desktop/src/main/menu.ts                         | 2 +-
 desktop/src/main/services/dir.ts                 | 2 +-
 desktop/src/main/services/ffmpeg.ts              | 2 +-
 desktop/src/main/services/image.ts               | 2 +-
 desktop/src/main/services/watch.ts               | 2 +-
 desktop/src/main/utils/{index.ts => electron.ts} | 0
 8 files changed, 7 insertions(+), 7 deletions(-)
 rename desktop/src/main/utils/{index.ts => electron.ts} (100%)

diff --git a/desktop/src/main.ts b/desktop/src/main.ts
index c849c755f7..8beb45881b 100644
--- a/desktop/src/main.ts
+++ b/desktop/src/main.ts
@@ -26,7 +26,7 @@ import { createWatcher } from "./main/services/watch";
 import { userPreferences } from "./main/stores/user-preferences";
 import { migrateLegacyWatchStoreIfNeeded } from "./main/stores/watch";
 import { registerStreamProtocol } from "./main/stream";
-import { isDev } from "./main/utils";
+import { isDev } from "./main/utils/electron";
 
 /**
  * The URL where the renderer HTML is being served from.
diff --git a/desktop/src/main/log.ts b/desktop/src/main/log.ts
index c4d2f3cbbe..cf1404a90a 100644
--- a/desktop/src/main/log.ts
+++ b/desktop/src/main/log.ts
@@ -1,6 +1,6 @@
 import log from "electron-log";
 import util from "node:util";
-import { isDev } from "./utils";
+import { isDev } from "./utils/electron";
 
 /**
  * Initialize logging in the main process.
diff --git a/desktop/src/main/menu.ts b/desktop/src/main/menu.ts
index 1019c7a8fb..024a226f11 100644
--- a/desktop/src/main/menu.ts
+++ b/desktop/src/main/menu.ts
@@ -10,7 +10,7 @@ import { forceCheckForAppUpdates } from "./services/app-update";
 import autoLauncher from "./services/auto-launcher";
 import { openLogDirectory } from "./services/dir";
 import { userPreferences } from "./stores/user-preferences";
-import { isDev } from "./utils";
+import { isDev } from "./utils/electron";
 
 /** Create and return the entries in the app's main menu bar */
 export const createApplicationMenu = async (mainWindow: BrowserWindow) => {
diff --git a/desktop/src/main/services/dir.ts b/desktop/src/main/services/dir.ts
index ef3adb013d..4e2a8c65e4 100644
--- a/desktop/src/main/services/dir.ts
+++ b/desktop/src/main/services/dir.ts
@@ -1,7 +1,7 @@
 import { shell } from "electron/common";
 import { app, dialog } from "electron/main";
 import path from "node:path";
-import { posixPath } from "../utils";
+import { posixPath } from "../utils/electron";
 
 export const selectDirectory = async () => {
     const result = await dialog.showOpenDialog({
diff --git a/desktop/src/main/services/ffmpeg.ts b/desktop/src/main/services/ffmpeg.ts
index 850b70d445..0a5c4eed2c 100644
--- a/desktop/src/main/services/ffmpeg.ts
+++ b/desktop/src/main/services/ffmpeg.ts
@@ -2,8 +2,8 @@ import pathToFfmpeg from "ffmpeg-static";
 import fs from "node:fs/promises";
 import type { ZipItem } from "../../types/ipc";
 import log from "../log";
-import { execAsync } from "../utils";
 import { ensure, withTimeout } from "../utils/common";
+import { execAsync } from "../utils/electron";
 import {
     deleteTempFile,
     makeFileForDataOrPathOrZipItem,
diff --git a/desktop/src/main/services/image.ts b/desktop/src/main/services/image.ts
index d607b0ead3..957fe81200 100644
--- a/desktop/src/main/services/image.ts
+++ b/desktop/src/main/services/image.ts
@@ -4,7 +4,7 @@ import fs from "node:fs/promises";
 import path from "node:path";
 import { CustomErrorMessage, type ZipItem } from "../../types/ipc";
 import log from "../log";
-import { execAsync, isDev } from "../utils";
+import { execAsync, isDev } from "../utils/electron";
 import {
     deleteTempFile,
     makeFileForDataOrPathOrZipItem,
diff --git a/desktop/src/main/services/watch.ts b/desktop/src/main/services/watch.ts
index ca550a787b..a56c0cf6c3 100644
--- a/desktop/src/main/services/watch.ts
+++ b/desktop/src/main/services/watch.ts
@@ -5,7 +5,7 @@ import path from "node:path";
 import { FolderWatch, type CollectionMapping } from "../../types/ipc";
 import log from "../log";
 import { watchStore } from "../stores/watch";
-import { posixPath } from "../utils";
+import { posixPath } from "../utils/electron";
 import { fsIsDir } from "./fs";
 
 /**
diff --git a/desktop/src/main/utils/index.ts b/desktop/src/main/utils/electron.ts
similarity index 100%
rename from desktop/src/main/utils/index.ts
rename to desktop/src/main/utils/electron.ts

From a0d44b58e218f5a83adbd9e9138a4d4054f4e391 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Tue, 30 Apr 2024 22:48:10 +0530
Subject: [PATCH 41/41] Fix load

Using .on("ready" was not causing the window to start loading the renderer
unless createWindow was made async.
---
 desktop/src/main.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/desktop/src/main.ts b/desktop/src/main.ts
index 8beb45881b..eb1114cc4c 100644
--- a/desktop/src/main.ts
+++ b/desktop/src/main.ts
@@ -365,7 +365,7 @@ const main = () => {
     // Emitted once, when Electron has finished initializing.
     //
     // Note that some Electron APIs can only be used after this event occurs.
-    app.on("ready", () => {
+    void app.whenReady().then(() => {
         void (async () => {
             // Create window and prepare for the renderer.
             mainWindow = createMainWindow();