From c4fc03d933d49bb28023836db422d7cc68f592d8 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mnvr.in>
Date: Wed, 4 Jun 2025 08:38:37 +0530
Subject: [PATCH] Reset cast dialog view on reopen

---
 .../Collections/AlbumCastDialog.tsx           | 37 +++++++++++++++++--
 1 file changed, 34 insertions(+), 3 deletions(-)

diff --git a/web/apps/photos/src/components/Collections/AlbumCastDialog.tsx b/web/apps/photos/src/components/Collections/AlbumCastDialog.tsx
index fd36f14a12..c2054b24ae 100644
--- a/web/apps/photos/src/components/Collections/AlbumCastDialog.tsx
+++ b/web/apps/photos/src/components/Collections/AlbumCastDialog.tsx
@@ -18,7 +18,7 @@ import {
 } from "ente-new/photos/services/cast";
 import { loadCast } from "ente-new/photos/utils/chromecast-sender";
 import { t } from "i18next";
-import { useCallback, useEffect, useState } from "react";
+import React, { useCallback, useEffect, useState } from "react";
 import { Trans } from "react-i18next";
 
 type AlbumCastDialogProps = ModalVisibilityProps & {
@@ -33,6 +33,37 @@ export const AlbumCastDialog: React.FC<AlbumCastDialogProps> = ({
     open,
     onClose,
     collection,
+}) => (
+    <TitledMiniDialog {...{ open, onClose }} title={t("cast_album_to_tv")}>
+        <AlbumCastDialogContents {...{ open, onClose, collection }} />
+    </TitledMiniDialog>
+);
+
+/**
+ * [Note: MUI dialog state reset]
+ *
+ * Keep the dialog contents in a separate component so that they get rendered
+ * afresh when the dialog is unmounted and then shown again.
+ *
+ * Details:
+ *
+ * Any state we keep inside the React component that a MUI Dialog as a child
+ * gets retained across visibility changes. For example, if the
+ * {@link AlbumCastDialogContents} were inlined into {@link AlbumCastDialog},
+ * then if we were to open the dialog, switch over to the "pin" view, then close
+ * the dialog by clicking on the backdrop, and then reopen it again, then we'd
+ * still remain on the "pin" view.
+ *
+ * This behaviour might be desirable or undesirable, depending on the
+ * circumstance. If it is undesirable, there are multiple approaches:
+ * https://github.com/mui/material-ui/issues/16325
+ *
+ * One of those is to keep the dialog contents in a separate component.
+ */
+export const AlbumCastDialogContents: React.FC<AlbumCastDialogProps> = ({
+    open,
+    onClose,
+    collection,
 }) => {
     const { castURL } = useSettingsSnapshot();
 
@@ -128,7 +159,7 @@ export const AlbumCastDialog: React.FC<AlbumCastDialogProps> = ({
     }, [open]);
 
     return (
-        <TitledMiniDialog {...{ open, onClose }} title={t("cast_album_to_tv")}>
+        <>
             {view == "choose" && (
                 <Stack sx={{ py: 1, gap: 4 }}>
                     {browserCanCast && (
@@ -210,6 +241,6 @@ export const AlbumCastDialog: React.FC<AlbumCastDialogProps> = ({
                     </FocusVisibleButton>
                 </>
             )}
-        </TitledMiniDialog>
+        </>
     );
 };