From c6fdd6352eef81721e6a17b99ba625c6046e206b Mon Sep 17 00:00:00 2001 From: Manav Rathi Date: Tue, 24 Sep 2024 08:33:09 +0530 Subject: [PATCH] Add an exception --- web/packages/build-config/eslintrc-react.js | 4 ++++ web/packages/new/photos/components/Gallery/BarImpl.tsx | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/web/packages/build-config/eslintrc-react.js b/web/packages/build-config/eslintrc-react.js index b1582eddc3..571d37e622 100644 --- a/web/packages/build-config/eslintrc-react.js +++ b/web/packages/build-config/eslintrc-react.js @@ -8,7 +8,11 @@ module.exports = { plugins: ["react-refresh"], settings: { react: { version: "18.2" } }, rules: { + /* The rule is misguided - only the opener should be omitted, not the + referrer. */ "react/jsx-no-target-blank": ["warn", { allowReferrer: true }], + /* Otherwise we need to do unnecessary boilerplating when using memo. */ + "react/display-name": "off", "react-refresh/only-export-components": [ "warn", { allowConstantExport: true }, diff --git a/web/packages/new/photos/components/Gallery/BarImpl.tsx b/web/packages/new/photos/components/Gallery/BarImpl.tsx index ab30c8eb56..10f01c3226 100644 --- a/web/packages/new/photos/components/Gallery/BarImpl.tsx +++ b/web/packages/new/photos/components/Gallery/BarImpl.tsx @@ -423,7 +423,6 @@ const getItemKey = (index: number, data: ItemData) => { } }; -// eslint-disable-next-line react/display-name const ListItem = memo((props: ListChildComponentProps) => { const { data, index, style } = props;