From c8a7152cdc6a450c7c18292da403bf6961fe41cb Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Thu, 30 May 2024 12:01:04 +0530
Subject: [PATCH] Remove unnecessary propagation

---
 .../services/machineLearning/machineLearningService.ts | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/web/apps/photos/src/services/machineLearning/machineLearningService.ts b/web/apps/photos/src/services/machineLearning/machineLearningService.ts
index a452846623..f28c3f76c4 100644
--- a/web/apps/photos/src/services/machineLearning/machineLearningService.ts
+++ b/web/apps/photos/src/services/machineLearning/machineLearningService.ts
@@ -277,13 +277,8 @@ class MachineLearningService {
         localFile?: globalThis.File,
     ) {
         try {
-            const mlFileData = await this.syncFile(
-                enteFile,
-                localFile,
-                syncContext.userAgent,
-            );
+            await this.syncFile(enteFile, localFile, syncContext.userAgent);
             syncContext.nSyncedFiles += 1;
-            return mlFileData;
         } catch (e) {
             log.error("ML syncFile failed", e);
             let error = e;
@@ -320,14 +315,13 @@ class MachineLearningService {
     ) {
         const oldMlFile = await mlIDbStorage.getFile(enteFile.id);
         if (oldMlFile && oldMlFile.mlVersion) {
-            return oldMlFile;
+            return;
         }
 
         const worker = new FaceIndexerWorker();
 
         const newMlFile = await worker.index(enteFile, localFile, userAgent);
         await mlIDbStorage.putFile(newMlFile);
-        return newMlFile;
     }
 
     private async persistMLFileSyncError(enteFile: EnteFile, e: Error) {