diff --git a/.github/workflows/web-deploy.yml b/.github/workflows/web-deploy.yml index 7427893af5..6f6a113f24 100644 --- a/.github/workflows/web-deploy.yml +++ b/.github/workflows/web-deploy.yml @@ -1,4 +1,4 @@ -name: "Deploy (photos)" +name: "Deploy (web)" on: schedule: diff --git a/web/apps/photos/src/worker/ffmpeg.worker.ts b/web/apps/photos/src/worker/ffmpeg.worker.ts index aa1d1437ef..408c2197c5 100644 --- a/web/apps/photos/src/worker/ffmpeg.worker.ts +++ b/web/apps/photos/src/worker/ffmpeg.worker.ts @@ -7,6 +7,24 @@ import { inputPathPlaceholder, outputPathPlaceholder, } from "constants/ffmpeg"; + +// When we run tsc on CI, the line below errors out +// +// > Error: src/worker/ffmpeg.worker.ts(10,38): error TS2307: Cannot find module +// 'ffmpeg-wasm' or its corresponding type declarations. +// +// Building and running works fine. And this error does not occur when running +// tsc locally either. +// +// Of course, there is some misconfiguration, but we plan to move off our old +// fork and onto upstream ffmpeg-wasm, and the reason can be figured out then. +// For now, disable the error to allow the CI lint to complete. +// +// Note that we can't use @ts-expect-error since it doesn't error out when +// actually building! +// +// eslint-disable-next-line @typescript-eslint/ban-ts-comment +// @ts-ignore import { FFmpeg, createFFmpeg } from "ffmpeg-wasm"; export class DedicatedFFmpegWorker { diff --git a/web/package.json b/web/package.json index 647ee3ba3a..cae1c3a1a6 100644 --- a/web/package.json +++ b/web/package.json @@ -27,8 +27,8 @@ "dev:payments": "yarn workspace payments dev", "dev:photos": "yarn workspace photos next dev", "dev:staff": "yarn workspace staff dev", - "lint": "yarn prettier --check --log-level warn . && yarn workspaces run eslint --report-unused-disable-directives .", - "lint-fix": "yarn prettier --write --log-level warn . && yarn workspaces run eslint --fix .", + "lint": "yarn prettier --check --log-level warn . && yarn workspaces run eslint --report-unused-disable-directives . && yarn workspaces run tsc", + "lint-fix": "yarn prettier --write --log-level warn . && yarn workspaces run eslint --fix . && yarn workspaces run tsc", "preview": "yarn preview:photos", "preview:accounts": "yarn build:accounts && python3 -m http.server -d apps/accounts/out 3001", "preview:auth": "yarn build:auth && python3 -m http.server -d apps/auth/out 3000",