From d7f9851bb25e16c0f7bff817bdb491cdf2d8bb38 Mon Sep 17 00:00:00 2001 From: Manav Rathi Date: Tue, 20 Aug 2024 22:56:11 +0530 Subject: [PATCH] Show ML option to public beta --- .../src/components/Sidebar/Preferences.tsx | 35 +++++++------------ web/packages/new/photos/services/ml/index.ts | 5 --- 2 files changed, 13 insertions(+), 27 deletions(-) diff --git a/web/apps/photos/src/components/Sidebar/Preferences.tsx b/web/apps/photos/src/components/Sidebar/Preferences.tsx index 2c6e5d204e..41c8a5886d 100644 --- a/web/apps/photos/src/components/Sidebar/Preferences.tsx +++ b/web/apps/photos/src/components/Sidebar/Preferences.tsx @@ -1,4 +1,3 @@ -import { isDesktop } from "@/base/app"; import { EnteDrawer } from "@/base/components/EnteDrawer"; import { MenuItemGroup, MenuSectionTitle } from "@/base/components/Menu"; import { Titlebar } from "@/base/components/Titlebar"; @@ -9,7 +8,6 @@ import { type SupportedLocale, } from "@/base/i18n"; import { MLSettings } from "@/new/photos/components/MLSettings"; -import { canEnableML } from "@/new/photos/services/ml"; import { EnteMenuItem } from "@ente/shared/components/Menu/EnteMenuItem"; import ChevronRight from "@mui/icons-material/ChevronRight"; import ScienceIcon from "@mui/icons-material/Science"; @@ -17,7 +15,7 @@ import { Box, DialogProps, Stack } from "@mui/material"; import DropdownInput from "components/DropdownInput"; import { t } from "i18next"; import { AppContext } from "pages/_app"; -import React, { useContext, useEffect, useState } from "react"; +import React, { useContext, useState } from "react"; import { AdvancedSettings } from "./AdvancedSettings"; import { MapSettings } from "./MapSetting"; import type { SettingsDrawerProps } from "./types"; @@ -31,13 +29,8 @@ export const Preferences: React.FC = ({ const [advancedSettingsView, setAdvancedSettingsView] = useState(false); const [mapSettingsView, setMapSettingsView] = useState(false); - const [showMLSettings, setShowMLSettings] = useState(false); const [openMLSettings, setOpenMLSettings] = useState(false); - useEffect(() => { - if (isDesktop) void canEnableML().then(setShowMLSettings); - }, []); - const openAdvancedSettings = () => setAdvancedSettingsView(true); const closeAdvancedSettings = () => setAdvancedSettingsView(false); @@ -85,21 +78,19 @@ export const Preferences: React.FC = ({ endIcon={} label={t("advanced")} /> - {showMLSettings && ( - - } + + } + /> + + } + onClick={() => setOpenMLSettings(true)} + label={t("ml_search")} /> - - } - onClick={() => setOpenMLSettings(true)} - label={t("ml_search")} - /> - - - )} + + diff --git a/web/packages/new/photos/services/ml/index.ts b/web/packages/new/photos/services/ml/index.ts index c9e6ac4e08..8c141ac396 100644 --- a/web/packages/new/photos/services/ml/index.ts +++ b/web/packages/new/photos/services/ml/index.ts @@ -149,11 +149,6 @@ const createMLWorker = (electron: Electron): Promise => { */ export const isMLSupported = isDesktop; -/** - * TODO-ML: This will not be needed when we move to a public beta. - */ -export const canEnableML = async () => await isInternalUser(); - /** * Initialize the ML subsystem if the user has enabled it in preferences. */