From d904b9318a3fbf59c6137e57e7ec4a724b0bdea0 Mon Sep 17 00:00:00 2001 From: Manav Rathi Date: Thu, 10 Oct 2024 11:41:39 +0530 Subject: [PATCH] Remove unnecessary setter deps > React guarantees that setState function identity is stable and won't change on > re-renders. Thus it is safe to omit it from the useEffect or useCallback > dependency list. > > https://legacy.reactjs.org/docs/hooks-reference.html#usestate --- web/apps/photos/src/pages/_app.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/apps/photos/src/pages/_app.tsx b/web/apps/photos/src/pages/_app.tsx index c0047b83eb..5b68b6839b 100644 --- a/web/apps/photos/src/pages/_app.tsx +++ b/web/apps/photos/src/pages/_app.tsx @@ -5,7 +5,6 @@ import { AttributedMiniDialog } from "@/base/components/MiniDialog"; import { ActivityIndicator } from "@/base/components/mui/ActivityIndicator"; import { AppNavbar } from "@/base/components/Navbar"; import { setupI18n } from "@/base/i18n"; -import ErrorOutline from "@mui/icons-material/ErrorOutline"; import log from "@/base/log"; import { logStartupBanner, @@ -37,6 +36,7 @@ import { getTheme } from "@ente/shared/themes"; import { THEME_COLOR } from "@ente/shared/themes/constants"; import type { User } from "@ente/shared/user/types"; import ArrowForward from "@mui/icons-material/ArrowForward"; +import ErrorOutline from "@mui/icons-material/ErrorOutline"; import { CssBaseline } from "@mui/material"; import { ThemeProvider } from "@mui/material/styles"; import Notification from "components/Notification"; @@ -251,7 +251,7 @@ export default function App({ Component, pageProps }: AppProps) { close: { variant: "critical" }, content: t("generic_error_retry"), }), - [setDialogMessage], + [], ); const onGenericError = useCallback( @@ -264,7 +264,7 @@ export default function App({ Component, pageProps }: AppProps) { close: { variant: "critical" }, }) ), - [setDialogBoxAttributesV2], + [], ); const logout = useCallback(() => {