From e2c0aed2e4fdb2f8e8d6438457b4d286a04487ae Mon Sep 17 00:00:00 2001 From: Manav Rathi Date: Sat, 28 Sep 2024 17:22:44 +0530 Subject: [PATCH] Remove early exit threshold It did not appear to be obviously helping the speed (or hurting the quality), so remove it to reduce the number of concepts at play. --- web/packages/new/photos/services/ml/cluster.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/web/packages/new/photos/services/ml/cluster.ts b/web/packages/new/photos/services/ml/cluster.ts index c0d81173b9..50c53bcc8e 100644 --- a/web/packages/new/photos/services/ml/cluster.ts +++ b/web/packages/new/photos/services/ml/cluster.ts @@ -301,10 +301,6 @@ const clusterBatchLinear = async ( if (csim > nnCosineSimilarity && csim >= threshold) { nnIndex = j; nnCosineSimilarity = csim; - - // If we've find something above our early exit threshold, stop - // looking for a better match (A way to speed up clustering). - if (csim >= 0.9) break; } }