From eba729625fa55bb419e05d96068f0fc16ca85dd1 Mon Sep 17 00:00:00 2001 From: laurenspriem Date: Tue, 2 Sep 2025 18:19:34 +0530 Subject: [PATCH] commit instructions --- mobile/apps/photos/CLAUDE.md | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/mobile/apps/photos/CLAUDE.md b/mobile/apps/photos/CLAUDE.md index 0b85d26b5d..749832972f 100644 --- a/mobile/apps/photos/CLAUDE.md +++ b/mobile/apps/photos/CLAUDE.md @@ -22,6 +22,41 @@ The Photos app uses two types of packages: - **Shared packages** (`../../packages/`): Common code shared across multiple Ente apps (Photos, Auth, Locker) - **Photos-specific plugins** (`./plugins/`): Custom Flutter plugins specific to Photos app for separation and testability +## Commit & PR Guidelines + +⚠️ **CRITICAL: From the default template, use ONLY: Co-Authored-By: Claude ** ⚠️ + +### Pre-commit/PR Checklist (RUN BEFORE EVERY COMMIT OR PR!) + +**CRITICAL: CI will fail if ANY of these checks fail. Run ALL commands and ensure they ALL pass.** + +```bash +# 1. Analyze flutter code for errors and warnings +flutter analyze +``` + +**Why CI might fail even after running these:** + +- Skipping any command above +- Assuming auto-fix tools handle everything (they don't) +- Not fixing warnings that flutter reports +- Making changes after running the checks + +### Commit & PR Message Rules + +**These rules apply to BOTH commit messages AND pull request descriptions** + +- Keep messages CONCISE (no walls of text) +- Subject line under 72 chars (no body text unless critical) +- NO emojis +- NO promotional text or links (except Co-Authored-By line) + +### Additional Guidelines + +- Check `git status` before committing to avoid adding temporary/binary files +- Never commit to main branch +- All CI checks must pass - run the checklist commands above before committing or creating PR + ## Development Commands ### Using Melos (Monorepo Management)