From 66c88fa067b2d1500ae0541c792efcf42ac8cca7 Mon Sep 17 00:00:00 2001 From: Neeraj Gupta <254676+ua741@users.noreply.github.com> Date: Sat, 24 Aug 2024 12:57:23 +0530 Subject: [PATCH 1/2] [mob] Fix type error --- .../face_ml/face_clustering/face_clustering_service.dart | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mobile/lib/services/machine_learning/face_ml/face_clustering/face_clustering_service.dart b/mobile/lib/services/machine_learning/face_ml/face_clustering/face_clustering_service.dart index 1319c65409..f3064dbb60 100644 --- a/mobile/lib/services/machine_learning/face_ml/face_clustering/face_clustering_service.dart +++ b/mobile/lib/services/machine_learning/face_ml/face_clustering/face_clustering_service.dart @@ -263,8 +263,8 @@ class FaceClusteringService { Future predictWithinClusterComputer( Map input, { Map? fileIDToCreationTime, - Map oldClusterSummaries = - const {}, + Map oldClusterSummaries = + const {}, double distanceThreshold = kRecommendedDistanceThreshold, }) async { _logger.info( @@ -366,7 +366,7 @@ class FaceClusteringService { Future predictCompleteComputer( Map input, { Map? fileIDToCreationTime, - required Map oldClusterSummaries, + required Map oldClusterSummaries, double distanceThreshold = kRecommendedDistanceThreshold, double mergeThreshold = 0.30, }) async { From 63e21126f5747331f880eb897847b0f39ced4b82 Mon Sep 17 00:00:00 2001 From: Neeraj Gupta <254676+ua741@users.noreply.github.com> Date: Sat, 24 Aug 2024 12:58:40 +0530 Subject: [PATCH 2/2] [mob] Show delete face option on face group page --- mobile/lib/models/gallery_type.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mobile/lib/models/gallery_type.dart b/mobile/lib/models/gallery_type.dart index b73c0e080f..fb07f23a0a 100644 --- a/mobile/lib/models/gallery_type.dart +++ b/mobile/lib/models/gallery_type.dart @@ -82,13 +82,13 @@ extension GalleyTypeExtension on GalleryType { case GalleryType.locationTag: case GalleryType.quickLink: case GalleryType.peopleTag: + case GalleryType.cluster: return true; case GalleryType.trash: case GalleryType.archive: case GalleryType.hiddenSection: case GalleryType.hiddenOwnedCollection: case GalleryType.sharedCollection: - case GalleryType.cluster: return false; } }