From ff6d0d32cf409ff6ece7d82f4e6cd1b250ed3379 Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Thu, 4 Apr 2024 13:58:30 +0530
Subject: [PATCH] Remove unused 404 handler

The default appType == 'spa' in vite redirects all (unclaimed) paths to /index.html.

If needed, this can be disabled:
https://stackoverflow.com/questions/69701743/how-can-i-configure-vites-dev-server-to-give-404-errors/69711988#69711988
---
 web/apps/payments/src/pages/404.tsx          | 9 ---------
 web/apps/payments/src/utils/strings.ts       | 1 -
 web/apps/payments/src/vite-env.d.ts          | 4 ++++
 web/packages/build-config/tsconfig-vite.json | 3 +++
 4 files changed, 7 insertions(+), 10 deletions(-)
 delete mode 100644 web/apps/payments/src/pages/404.tsx

diff --git a/web/apps/payments/src/pages/404.tsx b/web/apps/payments/src/pages/404.tsx
deleted file mode 100644
index 8654d4ed71..0000000000
--- a/web/apps/payments/src/pages/404.tsx
+++ /dev/null
@@ -1,9 +0,0 @@
-import { Container } from "components/Container";
-import React from "react";
-import S from "utils/strings";
-
-const Page: React.FC = () => {
-    return <Container>{S.error_404}</Container>;
-};
-
-export default Page;
diff --git a/web/apps/payments/src/utils/strings.ts b/web/apps/payments/src/utils/strings.ts
index 68f5be9214..7285ea8be9 100644
--- a/web/apps/payments/src/utils/strings.ts
+++ b/web/apps/payments/src/utils/strings.ts
@@ -7,7 +7,6 @@
  */
 const S = {
     error_generic: "Oops, something went wrong.",
-    error_404: "404 | This page could not be found.",
 };
 
 export default S;
diff --git a/web/apps/payments/src/vite-env.d.ts b/web/apps/payments/src/vite-env.d.ts
index 73878f4326..90af95a138 100644
--- a/web/apps/payments/src/vite-env.d.ts
+++ b/web/apps/payments/src/vite-env.d.ts
@@ -1,5 +1,9 @@
+/* Type shims provided by vite, e.g. for asset imports
+   https://vitejs.dev/guide/features.html#client-types */
+
 /// <reference types="vite/client" />
 
+/** Types for the vite injected environment variables */
 interface ImportMetaEnv {
     /**
      * Override the origin (scheme://host:port) of Ente's API to connect to.
diff --git a/web/packages/build-config/tsconfig-vite.json b/web/packages/build-config/tsconfig-vite.json
index 5f8f539f41..8a0d12f15f 100644
--- a/web/packages/build-config/tsconfig-vite.json
+++ b/web/packages/build-config/tsconfig-vite.json
@@ -4,6 +4,9 @@
      * The base configuration was generated using `yarn create vite`. This was
      * already almost the same as the `tsconfig-typecheck.json` we use
      * elsewhere, with one or two differences.
+     *
+     * For more details about the flags vite cares about, see
+     * https://vitejs.dev/guide/features.html#typescript-compiler-options
      */
     "compilerOptions": {
         "target": "ES2020",