Manav Rathi
|
8813b0cf1c
|
[meta] Run PRs lint checks for pull requests from external forks
Currently, for PRs opened by external contributors, the various lint checks
don't run (sometimes causing code that fails basic lint checks to be committed
to main).
From my current understanding (I find the docs around this confusing), we need
to instead use the "pull_request" target. Refs:
* https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request
* https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/
Note that even then, we will need a manual step to approve running the lints for
first time contributors. Which is fine, at least we'll see the option, unlike
right now where they just can't be run until the code hits main.
|
2024-08-26 21:50:04 +05:30 |
|