These comments were earlier written to match the way prettier formatted
markdown, but they've changed that upstream with 3.4, so revert back to the more
natural style that prettier also uses.
Mobile app crash
[DiffFetcher] [SEVERE] [2024-09-14 01:03:33.632159] type 'List<dynamic>' is not a subtype of type 'int?'
⤷ type: _StackTrace
⤷ error: #0 PubMagicMetadata.fromMap (package:photos/models/metadata/file_magic.dart:91)
ce5354e19d/mobile/lib/models/metadata/file_magic.dart (L91)
From the docs: https://www.typescriptlang.org/tsconfig/#include
> If the last path segment in a pattern does not contain a file extension or
wildcard character, then it is treated as a directory, and files with
supported extensions inside that directory are included (e.g. .ts, .tsx, and
d.ts by default).
The methods are trivial, and we cannot centralize the keys since they will be
different for different apps. So an abstraction for this is not beneficial.
Also move the next specific dev build check to @/next
Sentry has a measurable impact on page load, a metric that I'm keen to
improve. Apparently by default it loses us 8-9 page speed points, though that
can be reduced to 3-4
(https://github.com/getsentry/sentry-javascript/issues/9179).
All of this is doable, but there are bigger tasks to deal with. This is not to
say that Sentry won't be useful again at some point, when we have time to deal
with it better. But right now, we discussed that it's just better to remove
Sentry instead of piling on to the sunk cost.
