Commit Graph

2836 Commits

Author SHA1 Message Date
Crowdin Bot
60f5d91f45 New Crowdin translations by GitHub Action 2024-11-18 01:05:19 +00:00
Prateek Sunal
e0ffde3f25 [mob][image-editor] dismiss page on save edits (#4036)
## Description

Previously saving edits would not close the page, this PR fixes that.

## Tests
2024-11-15 19:48:55 +05:30
laurenspriem
93986461dd [mob][photos] Copy changes 2024-11-15 16:06:11 +05:30
laurenspriem
4ce2d0a1e2 [mob][photos] ml section empty copy 2024-11-15 16:02:45 +05:30
laurenspriem
d4479a1a66 [mob][photos] Extract to string 2024-11-15 15:49:58 +05:30
laurenspriem
0f3e490699 [mob][photos] Don't keep showing the banner 2024-11-15 15:45:23 +05:30
laurenspriem
8a7e11e4af [mob][photos] Enable ml banner 2024-11-15 15:37:35 +05:30
laurenspriem
8d2288fbb4 [mob][photos] super key 2024-11-15 15:22:27 +05:30
Prateek Sunal
120053f61d fix: dismiss image editor on save edits 2024-11-15 02:24:13 +05:30
laurenspriem
f1ca5ccbd0 [mob][photos] Copy change for model download 2024-11-13 16:38:17 +05:30
Neeraj Gupta
c2380de406 [mob] Clean up multipart upload on put or update error (#4021)
## Description

## Tests
2024-11-13 12:01:23 +05:30
Neeraj Gupta
ff218c3e4d [mob] Clean up multipart upload on put or update error 2024-11-13 11:16:19 +05:30
Neeraj Gupta
306978291b [mob] Handle 401 during multipart failure 2024-11-12 14:28:00 +05:30
Crowdin Bot
0b5f9a4b18 New Crowdin translations by GitHub Action 2024-11-11 01:05:17 +00:00
Ashil
d25b1f7b65 [mob][photos] Concatenate strings more efficiently (#3985)
## Description

If number of iterations are high, concatenating a list of values to a
string using `str1 += str2` can block the UI thread.
Using `List.join()` is a much more efficient way to do this.
2024-11-09 09:34:49 +05:30
Neeraj Gupta
d2788d66d4 [mob] Add logs 2024-11-09 08:44:59 +05:30
Neeraj Gupta
619476892a [mob] Update local feedback on remote data change 2024-11-09 08:41:03 +05:30
Neeraj Gupta
d769cfad55 [mob] Refactor 2024-11-09 08:27:52 +05:30
ashilkn
1e9188f510 [mob][photos] Replace string concatenation happening in loop using '+' with more efficient alternative of by using 'List.join(). If number of iterations are very large, using '+' for concatenation can block the UI thread' 2024-11-08 21:38:33 +05:30
ashilkn
214dcce6ad [mob][photos] Remove unused methods 2024-11-08 19:05:19 +05:30
ashilkn
10f9638f24 [mob][photos] Chore 2024-11-08 18:30:29 +05:30
ashilkn
8965f1cd09 [mob][photos] Fix: Cast not working on android (Pair with PIN option) 2024-11-08 18:27:35 +05:30
ashilkn
65131a15ef [mob][photos] Fix 2024-11-07 23:59:18 +05:30
ashilkn
25b26ec303 [mob][photos] Workaround for a UX issue 2024-11-07 23:31:48 +05:30
ashilkn
88440400c2 [mob][photos] Fix loading state not appearing when the first filter is added in hierarchical search 2024-11-07 23:29:24 +05:30
ashilkn
88f613187d Revert "[mob] Render people section in GridView (#3958)"
This reverts commit 7a99c8be63, reversing
changes made to 287d4b00e1.
2024-11-07 23:15:17 +05:30
ashilkn
b108785979 [mob][photos] Bump up to v0.9.58 2024-11-07 22:58:57 +05:30
ashilkn
899c1d7041 [mob][photos] Remove unnecessary check 2024-11-07 22:55:35 +05:30
ashilkn
219ff7d2e9 Revert "[mob][photos] Add option to make 'only them' filter work a little different only for testing, for feedback on which option is better"
This reverts commit ebae813ee3.
2024-11-07 22:34:09 +05:30
ashilkn
65e8ff4da8 [mob][photos] Resolve merge conflicts and merge main 2024-11-07 22:21:44 +05:30
ashilkn
9becee9a85 [mob][photos] Remove unnecessary clipping 2024-11-07 22:09:03 +05:30
ashilkn
52663ae218 [mob][photos] Add comment 2024-11-07 22:00:34 +05:30
ashilkn
c5aecaf501 [mob][photos] Remove unused method 2024-11-07 21:54:11 +05:30
ashilkn
655d9602e0 [mob][photos] Dispose all notifiers of SearchFilterDataProvider after use 2024-11-07 21:47:58 +05:30
ashilkn
b83b7ad295 [mob][photos] Use better names 2024-11-07 20:23:34 +05:30
ashilkn
ae3b784463 [mob][photos] Improvements on PeopleBanner shown in hierarchical search 2024-11-07 19:59:14 +05:30
ashilkn
93fd05818a [mob][photos] Show 'Add a name' banner if an unnamed cluster is applied in hierarchical search
If there are multiple applied unnamed clusters, the banner will be shown for the first one
2024-11-07 18:35:21 +05:30
ashilkn
68fa429611 [mob][photos] Make PeopleBanner UI better and minimal 2024-11-07 18:07:00 +05:30
ashilkn
4b2a845fd0 [mob][photos] Give a more subtle shadow for PeopleBanner 2024-11-07 17:35:11 +05:30
Neeraj Gupta
fd24628f7a [mob] Only return indexed files if local indexing is disabled 2024-11-07 16:57:35 +05:30
Neeraj Gupta
19ccc5338f [mob] Skip deleting downloaded models 2024-11-07 16:56:23 +05:30
Neeraj Gupta
214dcddb65 [mob] Prioritize fetch for already indexed files. 2024-11-07 16:18:33 +05:30
ashilkn
0815bfd7b7 [mob][photos] Use better name 2024-11-07 15:12:24 +05:30
Neeraj Gupta
6edacd2f1d [mob] FDStatus: Store objectID and nonce 2024-11-07 14:53:24 +05:30
Neeraj Gupta
f543f32df2 Merge branch 'main' into file_data_v2 2024-11-07 13:34:33 +05:30
ashilkn
f2e99d5efd [mob][photos] Keep the galleryType as GalleryType.peopleTag when an 'Only them' filter is applied when, the initial filter is a face filter so that the selection option are of the inital face filter's
Needed to write extra code to make it work for 'Only them' face since the current logic checks if inital filter is in applied list, and if yes keep the gallery type unchanged and if not, change gallery type to GalleryType.searchResults. Since an 'Only them' filter is not exactly the same as a Face filter, had to write more code to handle this case since the 'Only them' filter can have the inital Face filter in it
2024-11-06 22:03:40 +05:30
ashilkn
d355d4c1f0 [mob][photos] Fix null check operator used on null value exception right after adding name to a person 2024-11-06 21:39:14 +05:30
ashilkn
b4f192fac1 [mob][photos] Minor fix 2024-11-06 21:17:06 +05:30
ashilkn
042cbdeee7 [mob][photos] Refactor 2024-11-06 21:16:24 +05:30
ashilkn
ca3c7ae526 [mob][photos] UI tweaks on pricing page 2024-11-06 19:13:44 +05:30