This reverts commit 4ed194f397.
Two main functional issues was:
- When trying to upload files, if I would search something without results, the
dialog would just close.
- As a user, I expect to be able to move out of the search bar with
escape. However, pressing escape closes the whole dialog, causing the user's
drag and dropped or selected files to be lost. This is not specifically a
problem with the code added in this commit, however this UX will need to be
fixed in some way before introducing the search bar.
One medium issue:
- The dialog box kept changing size when I searched. This is visually jarring.
Other minor issues:
- The input element did not match the look and feel for the rest of the search
input elements in the app. Aligning the search bar to the left and right of
the album thumbnails and using the MUI Input element (as our code uses MUI
elements in other places) might've fixed it.
- There were various debugging console.logs left over, once of which even seemed
like a case we need to handle.
- The strings were not localized.
Ente's web apps
Source code for Ente's various web apps and supporting websites.
Live versions are at:
- Ente Photos: web.ente.io
- Ente Auth: auth.ente.io
To know more about Ente, see our main README or visit ente.io.
Building from source
Fetch submodules
git submodule update --init --recursive
Install dependencies
yarn install
Start a local development server
yarn dev
That's it. The web app will automatically hot reload when you make changes.
If you're new to web development and unsure about how to get started, or are facing some problems when running the above steps, see docs/new.
Other apps
By default, yarn dev builds the Photos app. You can build the auth app by
doing yarn dev:auth.
To see the full list of apps you can run (and other scripts that you can use),
use yarn run.
For more details about development workflows, see docs/dev.
Directory structure
As a brief overview, this directory contains the following apps:
apps/photos: A fully functional web client for Ente Photos.apps/auth: A view only client for Ente Auth. Currently you can only view your 2FA codes using this web app. For adding and editing your 2FA codes, please use the Ente Auth mobile/desktop app instead.
These two are the public facing apps. There are other part of the code which are accessed as features within the main apps, but in terms of code are independently maintained and deployed:
apps/accounts: Passkey support (Coming soon)apps/cast: Chromecast support (Coming soon)
Note
This folder is supposed to contain all our web related code. Most of it is already here, but some code which is being deployed from our other repositories like the family portal (https://github.com/ente-io/families) still needs to be brought here. Also, some of the Cloudflare workers we use for fixing headers etc too. Hang tight, we're on it, will bring in the remaining bits one by one.
You might also find this overview of dependencies useful.
Attributions
City coordinates from Simple Maps
🌍 Translate
If you're interested in helping out with translation, please visit our Crowdin project to get started. Thank you for your support.
If your language is not listed for translation, please create a GitHub issue to have it added.
Contribute
For more ways to contribute, see ../CONTRIBUTING.md.