TerribleDev/DowntownerArchive
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Agent query: Are the newsletter images loading correctly now without proxy?

Browse Source 
Fix: Remove image proxy and enable CORS for direct image loading.

Screenshot: https://storage.googleapis.com/screenshot-production-us-central1/9dda30b6-4149-4bce-89dc-76333005952c/4212b3ba-6655-43b4-895d-e173d82da5ca.jpg
This commit is contained in:
TerribleDev
2025-02-15 18:30:36 +00:00
parent 51871e7f8f
commit b87dfb7622
2 changed files with 9 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
client/src/lib/newsletter-data.ts
View File

@@ -1,11 +1,6 @@
import { useQuery } from "@tanstack/react-query"; import { useQuery } from "@tanstack/react-query";
import type { Newsletter } from "@shared/schema"; import type { Newsletter } from "@shared/schema";
function getProxiedImageUrl(url: string | null) {
if (!url) return null;
return `/api/proxy-image?url=${encodeURIComponent(url)}`;
}
export interface Newsletter { export interface Newsletter {
// ... other properties // ... other properties
thumbnail: string | null; thumbnail: string | null;
@@ -13,21 +8,13 @@ export interface Newsletter {
export function useNewsletters() { export function useNewsletters() {
return useQuery<Newsletter[]>({ return useQuery<Newsletter[]>({
queryKey: ['/api/newsletters'], queryKey: ['/api/newsletters']
select: data => data.map(newsletter => ({
...newsletter,
thumbnail: getProxiedImageUrl(newsletter.thumbnail)
}))
}); });
} }
export function useNewsletterSearch(query: string) { export function useNewsletterSearch(query: string) {
return useQuery<Newsletter[]>({ return useQuery<Newsletter[]>({
queryKey: ['/api/newsletters/search', query], queryKey: ['/api/newsletters/search', query],
enabled: query.length > 0, enabled: query.length > 0
select: data => data.map(newsletter => ({
...newsletter,
thumbnail: getProxiedImageUrl(newsletter.thumbnail)
}))
}); });
} }

10
server/index.ts
View File

@@ -6,14 +6,18 @@ const app = express();
app.use(express.json()); app.use(express.json());
app.use(express.urlencoded({ extended: false })); app.use(express.urlencoded({ extended: false }));
// Add security headers to prevent script injection // Add security headers to prevent script injection and allow images from any domain
app.use((req, res, next) => { app.use((req, res, next) => {
// Prevent content injection // Prevent content injection but allow images from any domain
res.setHeader('Content-Security-Policy', "default-src 'self'; img-src 'self' https: data:; script-src 'self' 'unsafe-inline'; style-src 'self' 'unsafe-inline';"); res.setHeader('Content-Security-Policy', "default-src 'self'; img-src * data: https:; script-src 'self' 'unsafe-inline'; style-src 'self' 'unsafe-inline';");
// Prevent browsers from MIME-sniffing // Prevent browsers from MIME-sniffing
res.setHeader('X-Content-Type-Options', 'nosniff'); res.setHeader('X-Content-Type-Options', 'nosniff');
// XSS protection // XSS protection
res.setHeader('X-XSS-Protection', '1; mode=block'); res.setHeader('X-XSS-Protection', '1; mode=block');
// Allow CORS for images
res.setHeader('Access-Control-Allow-Origin', '*');
res.setHeader('Access-Control-Allow-Methods', 'GET, OPTIONS');
res.setHeader('Access-Control-Allow-Headers', 'Origin, X-Requested-With, Content-Type, Accept');
next(); next();
}); });