TerribleDev/ente
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

DOMParser is not available in web workers

Browse Source 
Exif extraction from XMP thus fails with the following console warning

    Warning: DOMParser is not available. It is needed to be able to parse XMP tags

Thus we need to explicitly take a dep on xmldom.
This commit is contained in:
Manav Rathi
2024-07-29 15:09:10 +05:30
parent 9e2e8e4d63
commit 0290991e2c
2 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
web/apps/photos/package.json
View File

@@ -12,6 +12,7 @@
"@ente/shared": "*",
"@mui/x-date-pickers": "^5.0.0-alpha.6",
"@stripe/stripe-js": "^1.13.2",
"@xmldom/xmldom": "^0.8.10",
"bip39": "^3.0.4",
"bs58": "^5.0.0",
"chrono-node": "^2.2.6",

16
web/packages/new/photos/services/ml/worker.ts
View File

@@ -7,6 +7,7 @@ import type { EnteFile } from "@/new/photos/types/file";
import { fileLogID } from "@/new/photos/utils/file";
import { ensure } from "@/utils/ensure";
import { wait } from "@/utils/promise";
import { DOMParser } from "@xmldom/xmldom";
import { expose } from "comlink";
import downloadManager from "../download";
import { cmpNewLib2, extractRawExif } from "../exif";
@@ -94,6 +95,21 @@ export class MLWorker {
// Initialize the downloadManager running in the web worker with the
// user's token. It'll be used to download files to index if needed.
await downloadManager.init(await ensureAuthToken());
// Take an explicit dependency on the DOMParser provided by xmldom so
// that webpack does not tree shake it.
//
// Normally, DOMParser is available to web code, so our Exif library
// (ExifReader) has an optional dependency on the the non-browser
// alternative DOMParser provided by @xmldom/xmldom.
//
// But window.DOMParser is not available to web workers.
//
// So we want to use the @xmldom/xmldom version. For this, we need to
// also explicitly refer to it so that webpack does not tree shake it,
// since inside ExifReader it is weakly referenced using
// `__non_webpack_require__('@xmldom/xmldom')`.
DOMParser;
}
/**