TerribleDev/ente
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[mob][photos] Fix jank when scrolling gallery when lot of selected items are in view (#6913)

Browse Source 
## Description

Using `ColorFiltered` with `Blendmode.darken` introduces a performance
[issue](https://github.com/flutter/flutter/issues/174118) with flutter's
new rendering engine Impeller.

The fix uses an alternative method to that maintains the same UI
appearance as before.
This commit is contained in:
Ashil
2025-08-20 19:09:46 +05:30
committed by GitHub
parent 6955788724 5533e6a71d
commit 2ac1d58dac
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
mobile/apps/photos/lib/ui/viewer/gallery/component/gallery_file_widget.dart
View File

@@ -36,6 +36,7 @@ class GalleryFileWidget extends StatefulWidget {
}
class _GalleryFileWidgetState extends State<GalleryFileWidget> {
static const borderRadius = BorderRadius.all(Radius.circular(1));
late bool _isFileSelected;
@override
@@ -92,7 +93,7 @@ class _GalleryFileWidgetState extends State<GalleryFileWidget> {
children: [
ClipRRect(
key: ValueKey(heroTag),
borderRadius: BorderRadius.circular(1),
borderRadius: borderRadius,
child: Hero(
tag: heroTag,
flightShuttleBuilder: (
@@ -104,13 +105,13 @@ class _GalleryFileWidgetState extends State<GalleryFileWidget> {
) =>
thumbnailWidget,
transitionOnUserGestures: true,
child: ColorFiltered(
colorFilter: const ColorFilter.mode(
Color.fromARGB(102, 0, 0, 0),
BlendMode.darken,
),
child: thumbnailWidget,
),
child: thumbnailWidget,
),
),
Container(
decoration: const BoxDecoration(
color: Color.fromARGB(102, 0, 0, 0),
borderRadius: borderRadius,
),
),
Positioned(
@@ -126,7 +127,7 @@ class _GalleryFileWidgetState extends State<GalleryFileWidget> {
)
: ClipRRect(
key: ValueKey(heroTag),
borderRadius: BorderRadius.circular(1),
borderRadius: borderRadius,
child: Hero(
tag: heroTag,
flightShuttleBuilder: (