TerribleDev/ente
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[mob][photos] Remove hero animation from People section because when it's enabled, there is a UI glitch because of an issue in flutter

Browse Source 
https://github.com/flutter/flutter/issues/47991
This commit is contained in:
ashilkn
2024-11-15 20:57:15 +05:30
parent 102929a5d6
commit 392ec34f25
1 changed files with 13 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
mobile/lib/ui/viewer/search_tab/people_section.dart
View File

@@ -198,9 +198,7 @@ class PersonSearchExample extends StatelessWidget {
Widget build(BuildContext context) {
final bool isCluster = (searchResult.type() == ResultType.faces &&
int.tryParse(searchResult.name()) != null);
final heroTag = searchResult.heroTag() +
(searchResult.previewThumbnail()?.tag ?? "") +
searchResult.resultFiles().length.toString();
return GestureDetector(
onTap: () {
RecentSearches().add(searchResult.name());
@@ -238,21 +236,18 @@ class PersonSearchExample extends StatelessWidget {
width: size - 2,
height: size - 2,
child: searchResult.previewThumbnail() != null
? Hero(
tag: heroTag,
child: ClipPath(
clipper: ShapeBorderClipper(
shape: ContinuousRectangleBorder(
borderRadius: BorderRadius.circular(80),
),
? ClipPath(
clipper: ShapeBorderClipper(
shape: ContinuousRectangleBorder(
borderRadius: BorderRadius.circular(80),
),
child: searchResult.type() != ResultType.faces
? ThumbnailWidget(
searchResult.previewThumbnail()!,
shouldShowSyncStatus: false,
)
: FaceSearchResult(searchResult, heroTag),
),
child: searchResult.type() != ResultType.faces
? ThumbnailWidget(
searchResult.previewThumbnail()!,
shouldShowSyncStatus: false,
)
: FaceSearchResult(searchResult),
)
: ClipPath(
clipper: ShapeBorderClipper(
@@ -324,8 +319,8 @@ class PersonSearchExample extends StatelessWidget {
class FaceSearchResult extends StatelessWidget {
final SearchResult searchResult;
final String heroTagPrefix;
const FaceSearchResult(this.searchResult, this.heroTagPrefix, {super.key});
const FaceSearchResult(this.searchResult, {super.key});
@override
Widget build(BuildContext context) {