Fix type errors by ensuring single react types

This commit is contained in:
Manav Rathi
2025-04-09 07:45:37 +05:30
parent 75385a6e02
commit 60b484a2ad
5 changed files with 8 additions and 12 deletions

View File

@@ -267,8 +267,6 @@ const AllAlbumsContent: React.FC<AllAlbumsContentProps> = ({
itemSize={CollectionRowItemSize}
itemData={itemData}
>
{/* eslint-disable-next-line @typescript-eslint/ban-ts-comment */
/* @ts-ignore TODO deal with this new react-window type error */}
{AlbumsRow}
</FixedSizeList>
)}

View File

@@ -908,8 +908,6 @@ export const FileList: React.FC<FileListProps> = ({
overscanCount={3}
useIsScrolling
>
{/* eslint-disable-next-line @typescript-eslint/ban-ts-comment */
/* @ts-ignore TODO deal with this new react-window type error */}
{PhotoListRow}
</List>
);

View File

@@ -93,6 +93,9 @@ DOM.
> package.jsons to avoid the unmet peer dependency warnings printed by yarn.
> Ideally, the react dependencies can be specified just in the _ente-base_
> package. For now, we manually ensure that all of them use the same version.
> Additionally, we pin the versions of the react types using the resolutions
> field in the top level `package.json`, otherwise we end up with type errors
> because of multiple versions of react types being in scope.
### MUI and Material Icons

View File

@@ -23,6 +23,10 @@
"lint": "concurrently --names 'prettier,eslint,tsc' \"yarn prettier --check --log-level warn .\" \"yarn workspaces run eslint\" \"yarn workspaces run tsc\"",
"lint-fix": "concurrently --names 'prettier,eslint,tsc' \"yarn prettier --write --log-level warn .\" \"yarn workspaces run eslint --fix\" \"yarn workspaces run tsc\""
},
"resolutions": {
"@types/react": "^19.1.0",
"@types/react-dom": "^19.1.1"
},
"devDependencies": {
"concurrently": "^9.1.2",
"eslint": "^9.21.0",

View File

@@ -1131,14 +1131,7 @@
dependencies:
"@types/react" "*"
"@types/react@*":
version "19.0.2"
resolved "https://registry.yarnpkg.com/@types/react/-/react-19.0.2.tgz#9363e6b3ef898c471cb182dd269decc4afc1b4f6"
integrity sha512-USU8ZI/xyKJwFTpjSVIrSeHBVAGagkHQKPNbxeWwql/vDmnTIBgx+TJnhFnj1NXgz8XfprU0egV2dROLGpsBEg==
dependencies:
csstype "^3.0.2"
"@types/react@^19.1.0":
"@types/react@*", "@types/react@^19.1.0":
version "19.1.0"
resolved "https://registry.yarnpkg.com/@types/react/-/react-19.1.0.tgz#73c43ad9bc43496ca8184332b111e2aef63fc9da"
integrity sha512-UaicktuQI+9UKyA4njtDOGBD/67t8YEBt2xdfqu8+gP9hqPUPsiXlNPcpS2gVdjmis5GKPG3fCxbQLVgxsQZ8w==