Improve err

This commit is contained in:
Neeraj Gupta
2025-01-02 12:41:12 +05:30
parent 48a0bce211
commit 6898f0dbcb
2 changed files with 5 additions and 5 deletions

View File

@@ -43,7 +43,6 @@ func (c controllerImpl) CanAccessFile(ctx *gin.Context, req *CanAccessFileParams
// Only fetch shared collections once when needed
var sharedCollections []int64
for owner, fileIDs := range ownerToFilesMap {
if owner == req.ActorUserID {
continue
@@ -56,10 +55,12 @@ func (c controllerImpl) CanAccessFile(ctx *gin.Context, req *CanAccessFileParams
return stacktrace.Propagate(err, "failed to get shared collections")
}
}
if err := c.CollectionRepo.DoAllFilesExistInGivenCollections(fileIDs, sharedCollections); err != nil {
if existsErr := c.CollectionRepo.DoAllFilesExistInGivenCollections(fileIDs, sharedCollections); existsErr != nil {
log.WithFields(log.Fields{
"req_id": requestid.Get(ctx),
}).WithError(err).Error("access check failed")
"req_id": requestid.Get(ctx),
"sharedCollections": sharedCollections,
"fileIDs": fileIDs,
}).WithError(existsErr).Error("access check failed")
return stacktrace.Propagate(ente.ErrPermissionDenied, "access denied")
}
}

View File

@@ -439,7 +439,6 @@ func (repo *CollectionRepository) DoAllFilesExistInGivenCollections(fileIDs []in
}
}
if len(missingFiles) > 0 {
logrus.WithField("missingFiles", missingFiles).Info("missing files")
return stacktrace.Propagate(fmt.Errorf("missing files %v", missingFiles), "")
}
return nil