Start using it

desktop/src/main.ts

@@ -127,15 +127,7 @@ const registerPrivilegedSchemes = () => {
         {
             scheme: "stream",
             privileges: {
-                // TODO(MR): Remove the commented bits if we don't end up
-                // needing them by the time the IPC refactoring is done.
-
-                // Prevent the insecure origin issues when fetching this
-                // secure: true,
-                // Allow the web fetch API in the renderer to use this scheme.
                 supportFetchAPI: true,
-                // Allow it to be used with video tags.
-                // stream: true,
             },
         },
     ]);

web/apps/photos/src/utils/native-stream.ts

@@ -93,40 +93,21 @@ export const writeStream = async (
     const params = new URLSearchParams({ path });
     const url = new URL(`stream://write?${params.toString()}`);
 
-    // TODO(MR): This doesn't currently work.
-    //
-    // Not sure what I'm doing wrong here; I've opened an issue upstream
-    // https://github.com/electron/electron/issues/41872
-    //
-    // A gist with a minimal reproduction
-    // https://gist.github.com/mnvr/e08d9f4876fb8400b7615347b4d268eb
-    //
-    // Meanwhile, write the complete body in one go (this'll eventually run into
-    // memory failures with large files - just a temporary stopgap to get the
-    // code to work).
-
-    /*
     // The duplex parameter needs to be set to 'half' when streaming requests.
     //
     // Currently browsers, and specifically in our case, since this code runs
     // only within our desktop (Electron) app, Chromium, don't support 'full'
     // duplex mode (i.e. streaming both the request and the response).
     // https://developer.chrome.com/docs/capabilities/web-apis/fetch-streaming-requests
-    const req = new Request(`stream://write${path}`, {
+    const req = new Request(url, {
         // GET can't have a body
         method: "POST",
         body: stream,
-        // --@ts-expect-error TypeScript's libdom.d.ts does not include the
+        // @ts-expect-error TypeScript's libdom.d.ts does not include the
         // "duplex" parameter, e.g. see
         // https://github.com/node-fetch/node-fetch/issues/1769.
         duplex: "half",
     });
-    */
-
-    const req = new Request(url, {
-        method: "POST",
-        body: await new Response(stream).blob(),
-    });
 
     const res = await fetch(req);
     if (!res.ok)