TerribleDev/ente
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[mob][photos] Caching fix (#5531)

Browse Source 
## Description

Fix incorrect cache reading for incorrect utf8 encoding for memories and
magic cache.

## Tests

Tested in debug mode on my pixel phone.
This commit is contained in:
Laurens Priem
2025-04-08 14:24:41 +05:30
committed by GitHub
parent 8363b7b7d3 15ec21f3c8
commit 7002d2b464
2 changed files with 27 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
mobile/lib/services/magic_cache_service.dart
View File

@@ -305,15 +305,22 @@ class MagicCacheService {
_logger.info("No magic cache found");
return [];
}
final jsonString = file.readAsStringSync();
return MagicCache.decodeJsonToList(jsonString);
try {
final bytes = await file.readAsBytes();
final jsonString = String.fromCharCodes(bytes);
return MagicCache.decodeJsonToList(jsonString);
} catch (e, s) {
_logger.severe("Error reading or decoding cache file", e, s);
await file.delete();
rethrow;
}
}
Future<void> clearMagicCache() async {
final file = File(await _getCachePath());
if (file.existsSync()) {
await file.delete();
}
if (file.existsSync()) {
await file.delete();
}
}
Future<List<GenericSearchResult>> getMagicGenericSearchResult(

20
mobile/lib/services/memories_cache_service.dart
View File

@@ -428,15 +428,25 @@ class MemoriesCacheService {
allFileIdsToFile[file.uploadedFileID!] = file;
}
}
final jsonString = file.readAsStringSync();
return MemoriesCache.decodeFromJsonString(jsonString, allFileIdsToFile);
try {
final bytes = await file.readAsBytes();
final jsonString = String.fromCharCodes(bytes);
final cache =
MemoriesCache.decodeFromJsonString(jsonString, allFileIdsToFile);
_logger.info("Reading memories cache result from disk done");
return cache;
} catch (e, s) {
_logger.severe("Error reading or decoding cache file", e, s);
await file.delete();
return null;
}
}
Future<void> clearMemoriesCache() async {
final file = File(await _getCachePath());
if (file.existsSync()) {
await file.delete();
}
if (file.existsSync()) {
await file.delete();
}
_cachedMemories = null;
}
}