TerribleDev/ente
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[mob][photos] Decode heic using flutter compress (#3658)

Browse Source 
## Description

Change decode method for heic for ML to using flutter_image_compress.

## Tests

Tested in debug mode on my pixel 8.
This commit is contained in:
Laurens Priem
2024-10-10 19:08:39 +05:30
committed by GitHub
parent 54662a34ea 1cdc7aa594
commit 8dfd7b5921
1 changed files with 23 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
mobile/lib/utils/image_ml_util.dart
View File

@@ -5,7 +5,7 @@ import "dart:typed_data" show Float32List, Uint8List;
import "dart:ui";
import 'package:flutter/painting.dart' as paint show decodeImageFromList;
import "package:heif_converter/heif_converter.dart";
import "package:flutter_image_compress/flutter_image_compress.dart";
import "package:logging/logging.dart";
import 'package:ml_linalg/linalg.dart';
import "package:photos/models/ml/face/box.dart";
@@ -40,27 +40,29 @@ Future<(Image, Uint8List)> decodeImageFromPath(String imagePath) async {
return (image, rawRgbaBytes);
} catch (e, s) {
final format = imagePath.split('.').last;
if (Platform.isAndroid) {
_logger.info('Cannot decode $format, converting to JPG on Android');
final String? jpgPath =
await HeifConverter.convert(imagePath, format: 'jpg');
if (jpgPath != null) {
_logger.info('Conversion successful, decoding JPG');
final imageData = await File(jpgPath).readAsBytes();
final image = await decodeImageFromData(imageData);
final rawRgbaBytes = await _getRawRgbaBytes(image);
return (image, rawRgbaBytes);
}
_logger.info('Unable to convert $format to JPG');
_logger.info(
'Cannot decode $format on ${Platform.isAndroid ? "Android" : "iOS"}, converting to jpeg',
);
try {
final Uint8List? convertedData =
await FlutterImageCompress.compressWithFile(
imagePath,
format: CompressFormat.jpeg,
);
final image = await decodeImageFromData(convertedData!);
final rawRgbaBytes = await _getRawRgbaBytes(image);
_logger.info('Conversion successful, jpeg decoded');
return (image, rawRgbaBytes);
} catch (e) {
_logger.severe(
'Error decoding image of format $format on ${Platform.isAndroid ? "Android" : "iOS"}',
e,
s,
);
throw Exception(
'InvalidImageFormatException: Error decoding image of format $format',
);
}
_logger.severe(
'Error decoding image of format $format (Android: ${Platform.isAndroid})',
e,
s,
);
throw Exception(
'InvalidImageFormatException: Error decoding image of format $format',
);
}
}