+fav

web/apps/photos/src/components/Collections/CollectionHeader.tsx

@@ -48,7 +48,6 @@ import {
     clearLocalTrash,
     emptyTrash,
 } from "ente-new/photos/services/collections";
-import { settingsSnapshot } from "ente-new/photos/services/settings";
 import { usePhotosAppContext } from "ente-new/photos/types/context";
 import { t } from "i18next";
 import { GalleryContext } from "pages/gallery";
@@ -334,18 +333,13 @@ const CollectionOptions: React.FC<CollectionHeaderProps> = ({
                 >
                     {t("download_favorites")}
                 </DownloadOption>,
-                // TODO(FAV):
-                ...(settingsSnapshot().isInternalUser
-                    ? [
-                          <OverflowMenuOption
-                              key="share"
-                              onClick={onCollectionShare}
-                              startIcon={<PeopleIcon />}
-                          >
-                              {t("share_favorites")}
-                          </OverflowMenuOption>,
-                      ]
-                    : []),
+                <OverflowMenuOption
+                    key="share"
+                    onClick={onCollectionShare}
+                    startIcon={<PeopleIcon />}
+                >
+                    {t("share_favorites")}
+                </OverflowMenuOption>,
             ];
             break;
 
@@ -621,8 +615,7 @@ const DownloadQuickOption: React.FC<DownloadQuickOptionProps> = ({
 const showShareQuickOption = (type: CollectionSummaryType) =>
     type == "album" ||
     type == "folder" ||
-    (type == "favorites" &&
-        /* TODO(FAV): */ settingsSnapshot().isInternalUser) ||
+    type == "favorites" ||
     type == "outgoingShare" ||
     type == "sharedOnlyViaLink" ||
     type == "archived" ||