Remove out of date comment
This commit is contained in:
@@ -897,25 +897,8 @@ const clusterLivePhotos = async (
|
||||
};
|
||||
|
||||
/**
|
||||
* [Note: Memory pressure when uploading video files]
|
||||
*
|
||||
* A user (Fedora 39 VM on Qubes OS with 32 GB RAM, both AppImage and RPM) has
|
||||
* reported that their app runs out of memory when the app tries to upload
|
||||
* multiple large videos simultaneously. For example, 4 parallel uploads of 4
|
||||
* 700 MB videos.
|
||||
*
|
||||
* I am unable to reproduce this: tested on macOS and Linux, with videos up to
|
||||
* 3.8 G x 1 + 3 x 700 M uploaded in parallel. The memory usage remains constant
|
||||
* as expected (hovering around 2 G), since we don't pull the entire videos in
|
||||
* memory and instead do a streaming disk read + encryption + upload.
|
||||
*
|
||||
* The JavaScript heap for the renderer process (when we're running in the
|
||||
* context of our desktop app) is limited to 4 GB. See
|
||||
* https://www.electronjs.org/blog/v8-memory-cage.
|
||||
*
|
||||
* For now, add logs if our usage increases some high water mark. This is solely
|
||||
* so we can better understand the issue if it arises again (and can deal with
|
||||
* it in an informed manner).
|
||||
* Add logs if our usage increases some high water mark. This is solely so that
|
||||
* we have some indication in the logs if we get a user report of OOM crashes.
|
||||
*/
|
||||
const logAboutMemoryPressureIfNeeded = () => {
|
||||
if (!globalThis.electron) return;
|
||||
|
||||
Reference in New Issue
Block a user