TerribleDev/ente
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Direct

Browse Source
This commit is contained in:
Manav Rathi
2025-06-23 10:25:11 +05:30
parent 8ae29074c5
commit a840950fbb
2 changed files with 19 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
web/packages/gallery/services/video.ts
View File

@@ -516,16 +516,7 @@ const blobToDataURL = (blob: Blob) =>
* an array.
*/
const savedProcessedVideoFileIDs = () =>
// [Note: Avoiding Zod parsing overhead for DB arrays]
//
// Validating that the value we read from the DB is indeed the same as the
// type we expect can be done using Zod, but for potentially very large
// arrays, this has an overhead that is perhaps not justified when dealing
// with DB entries we ourselves wrote.
//
// As an optimization, we skip the runtime check here and cast. This might
// not be the most optimal choice in the future, so (a) use it sparingly,
// and (b) mark all such cases with the title of this note.
// See: [Note: Avoiding Zod parsing for large DB arrays]
getKV("videoPreviewProcessedFileIDs").then((v) => new Set(v as number[]));
/**
@@ -535,7 +526,7 @@ const savedProcessedVideoFileIDs = () =>
* @see also {@link savedProcessedVideoFileIDs}.
*/
const savedFailedVideoFileIDs = () =>
// See: [Note: Avoiding Zod parsing overhead for DB arrays]
// See: [Note: Avoiding Zod parsing for large DB arrays]
getKV("videoPreviewFailedFileIDs").then((v) => new Set(v as number[]));
/**

31
web/packages/new/photos/services/photos-fdb.ts
View File

@@ -2,10 +2,7 @@
* @file Photos app specific files DB. See: [Note: Files DB].
*/
import {
LocalCollections,
LocalEnteFiles,
} from "ente-gallery/services/files-db";
import { LocalCollections } from "ente-gallery/services/files-db";
import { type Collection } from "ente-media/collection";
import type { EnteFile } from "ente-media/file";
import localForage from "ente-shared/storage/localForage";
@@ -123,13 +120,19 @@ export const savedFiles = async (): Promise<EnteFile[]> => {
*
* Use {@link saveNormalFiles} to update the database.
*/
export const savedNormalFiles = async (): Promise<EnteFile[]> => {
const files: EnteFile[] =
(await localForage.getItem<EnteFile[]>("files")) ?? [];
const fmany = Array(10000).fill(files).flat();
console.time("file parse");
const f2 = LocalEnteFiles.parse(fmany);
console.timeEnd("file parse");
console.log(f2.length);
return files;
};
export const savedNormalFiles = async (): Promise<EnteFile[]> =>
// [Note: Avoiding Zod parsing for large DB arrays]
//
// Zod can be used to validate that the value we read from the DB is indeed
// the same as the type we expect, but for potentially very large arrays,
// this has an overhead that is perhaps not justified when dealing with DB
// entries we ourselves wrote.
//
// For example (as a non-rigorous benchmark) parsing 200k files took one
// second. Zod is fast, just that these arrays are big and might be accessed
// frequently, and the schemas are, while not too complicated, non-trivial.
//
// As an optimization, we skip the runtime check here and cast. This might
// not be the most optimal choice in the future, so (a) use it sparingly,
// and (b) mark all such cases with the title of this note.
(await localForage.getItem<EnteFile[]>("files")) ?? [];