TerribleDev/ente
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve UX on web

Browse Source
This commit is contained in:
Manav Rathi
2024-06-13 11:30:20 +05:30
parent d513019e1b
commit af3f2280d6
2 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
web/packages/accounts/pages/credentials.tsx
View File

@@ -276,9 +276,12 @@ const Page: React.FC<PageProps> = ({ appContext }) => {
);
}
if (passkeyVerificationURL) {
// We reach this case only when running in the desktop app, because in
// the web app we already would've redirected to passkeyVerificationURL.
if (passkeyVerificationURL && globalThis.electron) {
// We only need when running in the desktop app, because in the web app
// we just redirect to passkeyVerificationURL. However, still we add an
// additional `globalThis.electron` check is to prevent this state from
// being shown for a fraction of a second as the redirect happens on the
// web app.
//
// See: [Note: Passkey verification in the desktop app]

11
web/packages/accounts/pages/verify.tsx
View File

@@ -6,6 +6,7 @@ import FormPaper from "@ente/shared/components/Form/FormPaper";
import FormPaperFooter from "@ente/shared/components/Form/FormPaper/Footer";
import FormPaperTitle from "@ente/shared/components/Form/FormPaper/Title";
import LinkButton from "@ente/shared/components/LinkButton";
import { VerifyingPasskey } from "@ente/shared/components/LoginComponents";
import SingleInputForm, {
type SingleInputFormProps,
} from "@ente/shared/components/SingleInputForm";
@@ -34,7 +35,6 @@ import {
import { configureSRP } from "../services/srp";
import type { PageProps } from "../types/page";
import type { SRPSetupAttributes } from "../types/srp";
import { VerifyingPasskey } from "@ente/shared/components/LoginComponents";
const Page: React.FC<PageProps> = ({ appContext }) => {
const { appName, logout } = appContext;
@@ -174,9 +174,12 @@ const Page: React.FC<PageProps> = ({ appContext }) => {
);
}
if (passkeyVerificationURL) {
// We reach this case only when running in the desktop app, because in
// the web app we already would've redirected to passkeyVerificationURL.
if (passkeyVerificationURL && globalThis.electron) {
// We only need when running in the desktop app, because in the web app
// we just redirect to passkeyVerificationURL. However, still we add an
// additional `globalThis.electron` check is to prevent this state from
// being shown for a fraction of a second as the redirect happens on the
// web app.
//
// See: [Note: Passkey verification in the desktop app]