TerribleDev/ente
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Wrap EnteLoadingWidget with RepaintBoundary to avoid unnecessary repaints

Browse Source
This commit is contained in:
ashilkn
2025-05-15 08:39:47 +05:30
parent f4531ef088
commit c56d9b312d
4 changed files with 18 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
mobile/lib/ui/common/loading_widget.dart
View File

@@ -22,10 +22,12 @@ class EnteLoadingWidget extends StatelessWidget {
padding: EdgeInsets.all(padding),
child: SizedBox.fromSize(
size: Size.square(size),
child: CircularProgressIndicator(
strokeWidth: 2,
color: color ?? getEnteColorScheme(context).strokeBase,
strokeCap: StrokeCap.round,
child: RepaintBoundary(
child: CircularProgressIndicator(
strokeWidth: 2,
color: color ?? getEnteColorScheme(context).strokeBase,
strokeCap: StrokeCap.round,
),
),
),
),

12
mobile/lib/ui/viewer/location/add_location_sheet.dart
View File

@@ -192,13 +192,11 @@ class _AddLocationSheetState extends State<AddLocationSheet> {
builder: (context, int? value, _) {
Widget widget;
if (value == null) {
widget = RepaintBoundary(
child: EnteLoadingWidget(
size: 14,
color: colorScheme.strokeMuted,
alignment: Alignment.centerLeft,
padding: 3,
),
widget = EnteLoadingWidget(
size: 14,
color: colorScheme.strokeMuted,
alignment: Alignment.centerLeft,
padding: 3,
);
} else {
widget = Column(

12
mobile/lib/ui/viewer/location/edit_location_sheet.dart
View File

@@ -184,13 +184,11 @@ class _EditLocationSheetState extends State<EditLocationSheet> {
builder: (context, int? value, _) {
Widget widget;
if (value == null) {
widget = RepaintBoundary(
child: EnteLoadingWidget(
size: 14,
color: colorScheme.strokeMuted,
alignment: Alignment.centerLeft,
padding: 3,
),
widget = EnteLoadingWidget(
size: 14,
color: colorScheme.strokeMuted,
alignment: Alignment.centerLeft,
padding: 3,
);
} else {
widget = Column(

8
mobile/lib/ui/viewer/people/save_or_edit_person.dart
View File

@@ -911,13 +911,9 @@ class _EmailSectionState extends State<_EmailSection> {
"Error getting isMeAssigned",
snapshot.error,
);
return const RepaintBoundary(
child: EnteLoadingWidget(),
);
return const EnteLoadingWidget();
} else {
return const RepaintBoundary(
child: EnteLoadingWidget(),
);
return const EnteLoadingWidget();
}
},
),