TerribleDev/ente
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[web] Embeddings diff improvements

Browse Source 
- Do not rely on the server sending back exactly as many entries as we
  requested, it may return less in case some of the embeddings cannot be
  fetched temporarily.

- Stop relying on the sort order - Instead of the last value, take the max from
  amongst all returned values.
This commit is contained in:
Manav Rathi
2024-05-16 10:09:12 +05:30
parent aa6b904b0b
commit c8a4fa16a1
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
web/apps/photos/src/services/embeddingService.ts
View File

@@ -141,15 +141,16 @@ export const syncCLIPEmbeddings = async () => {
...allEmbeddings,
...newEmbeddings,
]);
if (response.diff.length) {
modelLastSinceTime = response.diff.slice(-1)[0].updatedAt;
}
modelLastSinceTime = response.diff.reduce(
(max, { updatedAt }) => Math.max(max, updatedAt),
modelLastSinceTime,
);
await localForage.setItem(clipEmbeddingsLSKey, allEmbeddings);
await setModelEmbeddingSyncTime(model, modelLastSinceTime);
log.info(
`Syncing embeddings syncedEmbeddingsCount: ${allEmbeddings.length}`,
);
} while (response.diff.length === DIFF_LIMIT);
} while (response.diff.length > 0);
} catch (e) {
log.error("Sync embeddings failed", e);
}
@@ -218,15 +219,16 @@ export const syncFaceEmbeddings = async () => {
...allEmbeddings,
...newEmbeddings,
]);
if (response.diff.length) {
modelLastSinceTime = response.diff.slice(-1)[0].updatedAt;
}
modelLastSinceTime = response.diff.reduce(
(max, { updatedAt }) => Math.max(max, updatedAt),
modelLastSinceTime,
);
await localForage.setItem(FILE_EMBEDING_TABLE, allEmbeddings);
await setModelEmbeddingSyncTime(model, modelLastSinceTime);
log.info(
`Syncing embeddings syncedEmbeddingsCount: ${allEmbeddings.length}`,
);
} while (response.diff.length === DIFF_LIMIT);
} while (response.diff.length > 0);
} catch (e) {
log.error("Sync embeddings failed", e);
}